From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B5DC4332F for ; Fri, 16 Dec 2022 18:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbiLPSJF (ORCPT ); Fri, 16 Dec 2022 13:09:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbiLPSJE (ORCPT ); Fri, 16 Dec 2022 13:09:04 -0500 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9458933C26; Fri, 16 Dec 2022 10:09:03 -0800 (PST) Received: by mail-io1-f43.google.com with SMTP id q190so1618474iod.10; Fri, 16 Dec 2022 10:09:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1eFLCni2OGFsB0YPow85ffGtmX+w7qQ59Jc5KJ46+aE=; b=0io4IvVsIbTgKpEMxDIdRt97bamCXj4PjZZlsNs4TB8vGiklQ9fjBWawQsPykqIp/d qcnK72/FtzIOCDIbAsIHlQxMUHm0nDr8P/hgO2hbsVNayPqnJP53oylt6YaJhwvb6/2q 5aOI9OFOzKvLY96w7e5lKa7PneEv/AOCSOlzPqOLgIMzOUADXQA45334zoMAWFlg4aC8 Eo09w10OerPwKIAXvzdRQ/G4EMg8lr3kvX++RdVsTThS7UQ8AUNEYiiZkmltZEra0uFK fDIfloP9/gnLT28ilywR0Mkw70jUFk7B68CtZF9LVQvVjm6FZh9t3WBqHDJYTv8Ud63s kHQA== X-Gm-Message-State: ANoB5pmwmGOebPtZ6VPN0BOIyEYBQWuC7FS06iCMqAksIEb+VMGKGQbk Y3Ol8xLXWtBKPSw/ZdOI5UCvLIIoWZr+002p32E= X-Google-Smtp-Source: AA0mqf7Mc1qsy89MJIB/mEQA6FG/Nz7IiVG09NMLeNxXxYuGoobuOTsg29OmNVQkAFXcY8wxtZHZQOdUgi+7+UTQcNQ= X-Received: by 2002:a02:3f48:0:b0:376:2a35:3b21 with SMTP id c8-20020a023f48000000b003762a353b21mr37069879jaf.284.1671214142116; Fri, 16 Dec 2022 10:09:02 -0800 (PST) MIME-Version: 1.0 References: <20221215192817.2734573-1-namhyung@kernel.org> <20221215192817.2734573-3-namhyung@kernel.org> <18594a2a-553a-c2b8-2c4f-6f7563ae3727@linux.intel.com> In-Reply-To: <18594a2a-553a-c2b8-2c4f-6f7563ae3727@linux.intel.com> From: Namhyung Kim Date: Fri, 16 Dec 2022 10:08:50 -0800 Message-ID: Subject: Re: [PATCH 2/9] perf report: Ignore SIGPIPE for srcline To: Andi Kleen Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Milian Wolff , Leo Yan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi Andi, On Thu, Dec 15, 2022 at 11:25 PM Andi Kleen wrote: > > > On 12/15/2022 9:28 PM, Namhyung Kim wrote: > > It can get SIGPIPE when it uses an external addr2line process and the > > process was terminated unexpectedly. Let's ignore the signal and move > > on to the next sample. The sample will get the default srcline value > > anyway. > > > That's a bit dangerous -- if perf report output is piped to something > else you really want to stop on SIGPIPE. Maybe we can handle the pipe write errors gracefully, but it'd require more changes in many places. > > You would need to find a way to distinguish those cases. Hmm.. ok. I guess we can just drop this for now. With checking the .debug_line section, problematic cases should be gone mostly. Thanks, Namhyung