From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67599C77B7E for ; Thu, 25 May 2023 20:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241648AbjEYUxG convert rfc822-to-8bit (ORCPT ); Thu, 25 May 2023 16:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235214AbjEYUxF (ORCPT ); Thu, 25 May 2023 16:53:05 -0400 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67E05D3; Thu, 25 May 2023 13:53:04 -0700 (PDT) Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-456f1cc1791so1223e0c.2; Thu, 25 May 2023 13:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685047983; x=1687639983; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zpw7RNcTReU2qScwvfTVSMvkxHzv4Yt97VJVzcEC3uQ=; b=mIKan7oWD5ARYO0WX6l2CZRO0NCM/wl++M3vTVWDPrtD5WaQn8VvK9pv/d5ylNG0DO r8bltCfYdvQ43GMwwZQEfcWMYfaD9hXzRVJUhukknLfiJk2yb4OFKqR9dQv36SkC/Maw e756iXiGniDFFTNlzfdKFufPauL/uqYHLsMKvSPnvLVfIUlyJdP45eo1F7AHKVmml1bs GyRi/IEPS8vWcyRJT6J3TtbFHiapy05Kwys9UzdjGzV/vDATKQpe12SqwKiZD2oqzoNi Rr0Ad74NpTCzEYzfR+FxMxpXfd2GotbrM8viNwFZRV7K4icbomRXeBb46fzTj+hyXv30 CQhA== X-Gm-Message-State: AC+VfDyRzm4vgxpHWv7naKPmTg/YIn3D9gjHmFCVKTwM9s0U1gUzG9k8 F4Lkjl5sf+JFiIy25w3jSBZnqdou5gnhVoptnVk= X-Google-Smtp-Source: ACHHUZ5VsbV9KqpUNKJtWCFvi06cBt1kkTz+ekt+Wul+Uvb51lK85gIkefG2pchGbvxj6VU8XQdRQuMYk/OW5meTk2s= X-Received: by 2002:a1f:438d:0:b0:44f:ef57:c49a with SMTP id q135-20020a1f438d000000b0044fef57c49amr7372307vka.11.1685047983337; Thu, 25 May 2023 13:53:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Namhyung Kim Date: Thu, 25 May 2023 13:52:52 -0700 Message-ID: Subject: Re: [RFC] Adding Support for Firefox's Gecko Profile Format To: Anup Sharma Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi Anup, On Wed, May 24, 2023 at 12:25 PM Anup Sharma wrote: > > Hello everyone, > > I'm happy to share that I'll be working on adding support for Firefox's Gecko profile format. > This format is utilized by the Firefox profiler, which is a powerful tool for performance analysis > and debugging. By enhancing the perf data command to generate perf.data files in the Gecko > profile format, it will allow us to leverage the capabilities of the Firefox profiler for visualizing > and analyzing the performance data. > > As a starter task, I have created a test for testing the perf data JSON converter command. > I'm also looking for a few more starter tasks related to this project. I would greatly appreciate > your advice and guidance. > > In my effort to identify any existing bugs, I have enabled flags like 'fsanitize=address' to detect > potential issues but have not found any :). Additionally, I am running perf data commands to ensure > that all use cases are handled properly. Great, good to know it works well with asan for the basic use cases at least. > > I have one question regarding the installation process. Typically, I navigate to the perf directory, > run 'make', and then cp 'perf' to '/usr/bin'. However, I noticed that by default, perf is installed in > the '~/bin/perf' directory. Could someone please clarify why this is the case? Furthermore, I would > like to know how all of you compile the perf tree. I guess $HOME is the default prefix unless you set it to other, then make install will put the binary there. You can make sure if your PATH contains the ~/bin and use it. But it's also possible you can run the perf without installing. I have a symlink in my tmp directory to point to the recent build of the binary and use it always. :) To build, you can either 'cd tools/perf; make' or 'make -C tools/perf' in the top level linux source tree. I also pass "BUILD_BPF_SKEL=1" to enable BPF. Thanks, Namhyung > > Thank you for your support and I'm looking forward to collaborating with you on this project!