From: Namhyung Kim <namhyung@kernel.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: acme@kernel.org, peterz@infradead.org, irogers@google.com,
jolsa@kernel.org, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
sandipan.das@amd.com, ananth.narayan@amd.com,
santosh.shukla@amd.com
Subject: Re: [PATCH v3] perf evsel amd: Fix IBS error message
Date: Sat, 1 Jul 2023 18:03:30 -0700 [thread overview]
Message-ID: <CAM9d7ciV--mPi_MFQdsa8eoGp82NB0B5BmVccP_kMB65wGJafg@mail.gmail.com> (raw)
In-Reply-To: <CAM9d7chYnT2s1V1juP+EyewJfRD+2qHGs2pwghh=k3kFf1P9BA@mail.gmail.com>
On Sat, Jul 1, 2023 at 11:17 AM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hi Ravi,
>
> On Fri, Jun 30, 2023 at 1:53 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
> >
> > AMD IBS can do per-process profiling[1] and is no longer restricted to
> > per-cpu or systemwide only. Remove stale error message. Also, checking
> > just exclude_kernel is not sufficient since IBS does not support any
> > privilege filters. So include all exclude_* checks. And finally, move
> > these checks under tools/perf/arch/x86/ from generic code.
> >
> > Before:
> > $ sudo ./perf record -e ibs_op//k -C 0
> > Error:
> > AMD IBS may only be available in system-wide/per-cpu mode. Try
> > using -a, or -C and workload affinity
> >
> > After:
> > $ sudo ./perf record -e ibs_op//k -C 0
> > Error:
> > AMD IBS doesn't support privilege filtering. Try again without
> > the privilege modifiers (like 'k') at the end.
> >
> > [1] https://git.kernel.org/torvalds/c/30093056f7b2
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Applied to perf-tools-next, thanks!
prev parent reply other threads:[~2023-07-02 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 8:52 [PATCH v3] perf evsel amd: Fix IBS error message Ravi Bangoria
2023-07-01 18:17 ` Namhyung Kim
2023-07-02 1:03 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7ciV--mPi_MFQdsa8eoGp82NB0B5BmVccP_kMB65wGJafg@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ananth.narayan@amd.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).