From: Namhyung Kim <namhyung@gmail.com>
To: Michael Petlan <mpetlan@redhat.com>
Cc: vmolnaro@redhat.com, linux-perf-users@vger.kernel.org,
acme@kernel.org, acme@redhat.com
Subject: Re: [PATCH 1/2] perf test stat+shadow_stat.sh: Add threshold for rounding errors
Date: Tue, 26 Sep 2023 15:54:17 -0700 [thread overview]
Message-ID: <CAM9d7cievN+Jry0EwLB0FrTr3hjTmXMoCwsv8fZbRn0TTW1nMA@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.20.2309201256480.3810@Diego>
On Wed, Sep 20, 2023 at 5:39 AM Michael Petlan <mpetlan@redhat.com> wrote:
>
> On Tue, 19 Sep 2023, vmolnaro@redhat.com wrote:
> > From: Veronika Molnarova <vmolnaro@redhat.com>
> >
> > The test was failing in specific scenarios due to imperfection of FP
> > arithmetics. The `bc` command wasn't correctly rounding the result of
> > division causing the failure.
> >
> > Replace the `bc` with `awk` which should work with more decimal places
> > and add a threshold to catch any possible rounding errors. The
> > acceptable rounding error is set to 0.01 when the test passes with a
> > warning message.
> >
> > Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
>
> Acked-by: Michael Petlan <mpetlan@redhat.com>
Applied both to perf-tools-next, thanks!
prev parent reply other threads:[~2023-09-26 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 15:02 [PATCH 1/2] perf test stat+shadow_stat.sh: Add threshold for rounding errors vmolnaro
2023-09-19 15:02 ` [PATCH 2/2] perf test lock_contention.sh: Skip test if not enough CPUs vmolnaro
2023-09-20 10:57 ` Michael Petlan
2023-09-20 10:57 ` [PATCH 1/2] perf test stat+shadow_stat.sh: Add threshold for rounding errors Michael Petlan
2023-09-26 22:54 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cievN+Jry0EwLB0FrTr3hjTmXMoCwsv8fZbRn0TTW1nMA@mail.gmail.com \
--to=namhyung@gmail.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
--cc=vmolnaro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).