Re: [PATCH 2/2] perf test: Fix JSON format linter test checks

[Namhyung Kim <namhyung@gmail.com>]

On Tue, Jan 24, 2023 at 8:49 AM Michael Petlan <mpetlan@redhat.com> wrote:
>
> On Sun, 22 Jan 2023, Namhyung Kim wrote:
> > On Fri, Jan 20, 2023 at 6:00 AM Michael Petlan <mpetlan@redhat.com> wrote:
> > >
> > > The test fails on CPUs with topdown metrics, where it is common to print
> > > two metrics per line. Since these are included in default event set for
> > > `perf stat -- something`, it causes the "no args" subtest to fail due to
> > > unexpected member count. We need to accept 7 or 9 members in that case.
> > >
> > > Coming to that, counting commas in the JSON line and consider it a number
> > > of elements is incorrect and misleading. There should be +1 element than
> > > the count of commas, while also, commas can potentially appear in the
> > > event names. Count " : " substrings rather, since these better fit to
> > > what should be actually counted.
> >
> > I'm also curious if ":" could appear in the event/metric names.
> > Probably more chances to have ":" than "," in the name, no?
>
> Yes, ':' can appear in the event names, but not " : " (with the spaces
> around).

Ah, ok.  Missed the whitespaces. :)

Thanks,
Namhyung