From: Namhyung Kim <namhyung@kernel.org>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
pc@us.ibm.com, Jiri Olsa <jolsa@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Yao Jin <yao.jin@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields.
Date: Thu, 3 Sep 2020 23:54:54 +0900 [thread overview]
Message-ID: <CAM9d7cjDRGDuZhbZ1BJ2tF_hyrS0-b61kaL2=0VHtSFUcJN7sg@mail.gmail.com> (raw)
In-Reply-To: <20200902160439.335232-3-kjain@linux.ibm.com>
Hello,
On Thu, Sep 3, 2020 at 1:05 AM Kajol Jain <kjain@linux.ibm.com> wrote:
>
> This patch adds new structure called 'json_event' inside jevents.h
jevents.c ?
Thanks
Namhyung
> file to improve the callback prototype inside jevent files.
> Initially, whenever user want to add new field, they need to update
> in all function callback which make it more and more complex with
> increased number of parmeters.
> With this change, we just need to add it in new structure 'json_event'.
>
> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
next prev parent reply other threads:[~2020-09-03 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:04 [PATCH v7 0/5] powerpc/perf: Add json file support for hv_24x7 core level events Kajol Jain
2020-09-02 16:04 ` [PATCH v7 1/5] perf/jevents: Remove jevents.h file Kajol Jain
2020-09-02 17:00 ` John Garry
2020-09-02 16:04 ` [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields Kajol Jain
2020-09-02 17:05 ` John Garry
2020-09-04 8:29 ` kajoljain
2020-09-03 14:54 ` Namhyung Kim [this message]
2020-09-04 8:30 ` kajoljain
2020-09-02 16:04 ` [PATCH v7 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-09-02 16:04 ` [PATCH v7 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-09-02 16:04 ` [PATCH v7 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7cjDRGDuZhbZ1BJ2tF_hyrS0-b61kaL2=0VHtSFUcJN7sg@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).