From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Kajol Jain <kjain@linux.ibm.com>,
John Garry <john.g.garry@oracle.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Sohom Datta <sohomdatta1@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Edward Baker <edward.baker@intel.com>
Subject: Re: [PATCH v2 00/12] Add metric has_event, update intel vendor events
Date: Fri, 30 Jun 2023 14:03:35 -0700 [thread overview]
Message-ID: <CAM9d7cjVChbQThcMx7ptp-FRCrrwgV97fVJ0FpasC20M1+yLbQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9d7cgX-vnwkrQMMHn2C1sCjm3YO=xaigmMTsrbkg+fHk2H2g@mail.gmail.com>
On Thu, Jun 29, 2023 at 2:31 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hi Ian,
>
> On Fri, Jun 23, 2023 at 8:10 AM Ian Rogers <irogers@google.com> wrote:
> >
> > Add a new has_event function for metrics so that events that can be
> > disabled by the kernel/firmware don't cause metrics to fail. Use this
> > function for Intel transaction metrics fixing "perf all metrics test"
> > on systems with TSX disabled. The update conversion script is posted in:
> > https://github.com/intel/perfmon/pull/90
> >
> > Re-generate Intel vendor events using:
> > https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> > Adding rocketlake support, uncore and many core events for meteorlake,
> > and smaller updates for cascakelakex, icelake, icelakex,
> > sapphirerapids, skylake, skylakex and tigerlake.
> >
> > v2. Handle failed memory allocated for evlist, John Garry.
> >
> > Ian Rogers (12):
> > perf expr: Add has_event function
> > perf jevents: Support for has_event function
> > perf vendor metrics intel: Make transaction metrics conditional
> > perf vendor events intel: Add rocketlake events/metrics
> > perf vendor events intel: Update meteorlake to 1.03
> > perf vendor events intel: Update cascadelakex to 1.19
> > perf vendor events intel: Update icelake to 1.19
> > perf vendor events intel: Update icelakex to 1.21
> > perf vendor events intel: Update sapphirerapids to 1.14
> > perf vendor events intel: Update skylake to 57
> > perf vendor events intel: Update skylakex to 1.31
> > perf vendor events intel: Update tigerlake to 1.13
>
> My tigerlake laptop now passes the all metrics test with this.
> It used to fail like below:
>
> event syntax error:
> '{cpu/cycles-t,metric-id=cpu!3cycles!1t!3/,cpu/tx-start,m..'
> \___ unknown term 'cycles-t' for pmu 'cpu'
>
> Tested-by: Namhyung Kim <namhyung@kernel.org>
Applied to perf-tools-next, thanks!
prev parent reply other threads:[~2023-06-30 21:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 15:10 [PATCH v2 00/12] Add metric has_event, update intel vendor events Ian Rogers
2023-06-23 15:10 ` [PATCH v2 01/12] perf expr: Add has_event function Ian Rogers
2023-06-23 15:10 ` [PATCH v2 02/12] perf jevents: Support for " Ian Rogers
2023-06-23 15:10 ` [PATCH v2 03/12] perf vendor metrics intel: Make transaction metrics conditional Ian Rogers
2023-06-23 15:10 ` [PATCH v2 06/12] perf vendor events intel: Update cascadelakex to 1.19 Ian Rogers
2023-06-23 15:10 ` [PATCH v2 07/12] perf vendor events intel: Update icelake " Ian Rogers
2023-06-23 16:04 ` Vince Weaver
2023-06-23 16:08 ` Ian Rogers
2023-06-23 15:10 ` [PATCH v2 08/12] perf vendor events intel: Update icelakex to 1.21 Ian Rogers
2023-06-23 15:10 ` [PATCH v2 09/12] perf vendor events intel: Update sapphirerapids to 1.14 Ian Rogers
2023-06-23 15:10 ` [PATCH v2 10/12] perf vendor events intel: Update skylake to 57 Ian Rogers
2023-06-23 15:10 ` [PATCH v2 11/12] perf vendor events intel: Update skylakex to 1.31 Ian Rogers
2023-06-23 15:10 ` [PATCH v2 12/12] perf vendor events intel: Update tigerlake to 1.13 Ian Rogers
2023-06-29 21:31 ` [PATCH v2 00/12] Add metric has_event, update intel vendor events Namhyung Kim
2023-06-30 21:03 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cjVChbQThcMx7ptp-FRCrrwgV97fVJ0FpasC20M1+yLbQ@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=caleb.biggers@intel.com \
--cc=eddyz87@gmail.com \
--cc=edward.baker@intel.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=samantha.alt@intel.com \
--cc=sohomdatta1@gmail.com \
--cc=weilin.wang@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).