From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
James Clark <james.clark@arm.com>,
Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
Kan Liang <kan.liang@linux.intel.com>,
Yang Jihong <yangjihong1@huawei.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v4 0/8] Run tests in parallel
Date: Fri, 16 Feb 2024 11:57:23 -0800 [thread overview]
Message-ID: <CAM9d7cjXAKARq_7x0nif+vaiAfHHRhWEWHLYT3jkVugeXMncag@mail.gmail.com> (raw)
In-Reply-To: <20240214045356.748330-1-irogers@google.com>
Hi Ian,
On Tue, Feb 13, 2024 at 8:54 PM Ian Rogers <irogers@google.com> wrote:
>
> If command line option '-p' is provided, start/fork all tests in the
> main thread and then gather them in order at the end. On a laptop test
> time was reduced from 5 minutes 21 seconds to 1 minute 50 seconds. The
> option isn't default as the test shows up perf and test flakes.
It's a bit sad that tests flake when run in parallel but I think we can
work on improving it later. So
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> The '-v' option is modified so that 'perf test -v' will give verbose
> output only from failing tests.
>
> v4 - fix bug in width computation.
> v3 - fix a crash if shell test directory isn't found, remove merged patch.
> v2 - fix parallel test output/verbose issue
> v1 - initial PoC
>
> Ian Rogers (8):
> perf thread_map: Skip exited threads when scanning /proc
> perf list: Add scandirat compatibility function
> perf tests: Avoid fork in perf_has_symbol test
> tools subcmd: Add a no exec function call option
> perf test: Rename builtin-test-list and add missed header guard
> perf tests: Use scandirat for shell script finding
> perf tests: Run time generate shell test suites
> perf tests: Add option to run tests in parallel
>
> tools/lib/subcmd/run-command.c | 2 +
> tools/lib/subcmd/run-command.h | 2 +
> tools/perf/tests/Build | 2 +-
> tools/perf/tests/builtin-test-list.c | 207 ----------
> tools/perf/tests/builtin-test-list.h | 12 -
> tools/perf/tests/builtin-test.c | 378 ++++++++++--------
> tools/perf/tests/shell/lib/perf_has_symbol.sh | 2 +-
> tools/perf/tests/tests-scripts.c | 257 ++++++++++++
> tools/perf/tests/tests-scripts.h | 9 +
> tools/perf/util/print-events.c | 12 +-
> tools/perf/util/thread_map.c | 9 +-
> tools/perf/util/util.c | 19 +
> tools/perf/util/util.h | 8 +
> 13 files changed, 509 insertions(+), 410 deletions(-)
> delete mode 100644 tools/perf/tests/builtin-test-list.c
> delete mode 100644 tools/perf/tests/builtin-test-list.h
> create mode 100644 tools/perf/tests/tests-scripts.c
> create mode 100644 tools/perf/tests/tests-scripts.h
>
> --
> 2.43.0.687.g38aa6559b0-goog
>
prev parent reply other threads:[~2024-02-16 19:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 4:53 [PATCH v4 0/8] Run tests in parallel Ian Rogers
2024-02-14 4:53 ` [PATCH v4 1/8] perf thread_map: Skip exited threads when scanning /proc Ian Rogers
2024-02-14 4:53 ` [PATCH v4 2/8] perf list: Add scandirat compatibility function Ian Rogers
2024-02-14 4:53 ` [PATCH v4 3/8] perf tests: Avoid fork in perf_has_symbol test Ian Rogers
2024-02-14 4:53 ` [PATCH v4 4/8] tools subcmd: Add a no exec function call option Ian Rogers
2024-02-14 4:53 ` [PATCH v4 5/8] perf test: Rename builtin-test-list and add missed header guard Ian Rogers
2024-02-14 4:53 ` [PATCH v4 6/8] perf tests: Use scandirat for shell script finding Ian Rogers
2024-02-16 20:22 ` Namhyung Kim
2024-02-16 22:53 ` Ian Rogers
2024-02-14 4:53 ` [PATCH v4 7/8] perf tests: Run time generate shell test suites Ian Rogers
2024-02-14 4:53 ` [PATCH v4 8/8] perf tests: Add option to run tests in parallel Ian Rogers
2024-02-16 19:57 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cjXAKARq_7x0nif+vaiAfHHRhWEWHLYT3jkVugeXMncag@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).