linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: baomingtong001@208suo.com
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, zhengjun.xing@linux.intel.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf parse-events: Remove unneeded semicolon
Date: Wed, 21 Jun 2023 10:24:19 -0700	[thread overview]
Message-ID: <CAM9d7cjZQa531P8gn03QErYLx79yQ_9axtMTLdx9jEcRpLNoqQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9d7chMMQcnV+hTwyEDbcQrO0ELtQTnhQ5bZptF6g_k+m0mAg@mail.gmail.com>

On Tue, Jun 20, 2023 at 3:50 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@208suo.com> wrote:
> >
> > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
> >
> > Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> > ---
> >   tools/perf/util/parse-events.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-events.c
> > b/tools/perf/util/parse-events.c
> > index 629f7bd9fd59..42f84f61fabc 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> > parse_events_state *parse_state,
> >       if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> > PERF_TYPE_HW_CACHE)) {
>
> The format is broken, please fix your mail client not fix wrap long lines.
> This time I fixed it manually, but you need to update your config.

Also there were other whitespace breakages, but applied to
perf-tools-next anyway, thanks!

      reply	other threads:[~2023-06-21 17:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230614080937.54937-1-luojianhong@cdjrlc.com>
2023-06-14  8:13 ` [PATCH] perf parse-events: Remove unneeded semicolon baomingtong001
2023-06-14 13:55   ` Arnaldo Carvalho de Melo
2023-06-20 22:50   ` Namhyung Kim
2023-06-21 17:24     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM9d7cjZQa531P8gn03QErYLx79yQ_9axtMTLdx9jEcRpLNoqQ@mail.gmail.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=baomingtong001@208suo.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).