From: Namhyung Kim <namhyung@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Like Xu <like.xu.linux@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V2 0/2] perf symbols: Slightly improve module file executable section mappings
Date: Wed, 7 Feb 2024 21:26:09 -0800 [thread overview]
Message-ID: <CAM9d7cjiCT7C=WHd9EmPRRRQY=1aq8-NAGgRcZPWz-s=7Js3mw@mail.gmail.com> (raw)
In-Reply-To: <20240206130458.8867-1-adrian.hunter@intel.com>
Hi Adrian,
On Tue, Feb 6, 2024 at 5:05 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Hi
>
> Currently perf does not record module section addresses except for
> the .text section. In general that means perf cannot get module section
> mappings correct (except for .text) when loading symbols from a kernel
> module file. (Note using --kcore does not have this issue)
>
> Here are a couple of patches to help shed light upon and slightly improve
> the situation.
>
>
> Changes in V2:
>
> perf tools: Make it possible to see perf's kernel and module memory mappings
> - add dump to perf report (if no browser) as well as perf script
> - add 'perf --debug kmaps' option also to dump kmaps
>
>
> Adrian Hunter (2):
> perf tools: Make it possible to see perf's kernel and module memory mappings
> perf symbols: Slightly improve module file executable section mappings
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> tools/perf/Documentation/perf.txt | 2 ++
> tools/perf/builtin-report.c | 2 ++
> tools/perf/builtin-script.c | 3 ++
> tools/perf/util/debug.c | 3 ++
> tools/perf/util/debug.h | 1 +
> tools/perf/util/python.c | 1 +
> tools/perf/util/session.c | 11 ++++++
> tools/perf/util/session.h | 2 ++
> tools/perf/util/symbol-elf.c | 75 +++++++++++++++++++++++++++++++++++++--
> 9 files changed, 98 insertions(+), 2 deletions(-)
>
>
> Regards
> Adrian
next prev parent reply other threads:[~2024-02-08 5:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 13:04 [PATCH V2 0/2] perf symbols: Slightly improve module file executable section mappings Adrian Hunter
2024-02-06 13:04 ` [PATCH V2 1/2] perf tools: Make it possible to see perf's kernel and module memory mappings Adrian Hunter
2024-02-06 13:04 ` [PATCH V2 2/2] perf symbols: Slightly improve module file executable section mappings Adrian Hunter
2024-02-08 5:26 ` Namhyung Kim [this message]
2024-02-08 5:29 ` [PATCH V2 0/2] " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7cjiCT7C=WHd9EmPRRRQY=1aq8-NAGgRcZPWz-s=7Js3mw@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).