Re: [PATCH] perf build: Make minimal shellcheck version to v0.6.0

[Namhyung Kim <namhyung@kernel.org>]

Adding Athira to CC.

Thanks,
Namhyung

On Mon, Jan 22, 2024 at 12:08 AM Yicong Yang <yangyicong@huawei.com> wrote:
>
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> perf build failed due to the shellcheck on my machine (v0.4.6 on Ubuntu
> 18.04.1 LTS) doesn't support -a/--check-sourced and -S/--severity option.
> These two options are introduced in shellcheck v0.4.7 and v0.6.0
> respectively. So restrict the minimal version of shellcheck to v0.6.0.
>
> Fixes: b809fc656e76 ("perf build: Shellcheck support for OUTPUT directory")
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
>  tools/perf/Makefile.perf | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 27e7c478880f..f8774a9b1377 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -236,6 +236,16 @@ else
>    SHELLCHECK := $(shell which shellcheck 2> /dev/null)
>  endif
>
> +# shellcheck is using in tools/perf/tests/Build with option -a/--check-sourced (
> +# introduced in v0.4.7) and -S/--severity (introduced in v0.6.0). So make the
> +# minimal shellcheck version as v0.6.0.
> +ifneq ($(SHELLCHECK),)
> +  ifeq ($(shell expr $(shell $(SHELLCHECK) --version | grep version: | \
> +        sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \< 060), 1)
> +    SHELLCHECK :=
> +  endif
> +endif
> +
>  export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK
>  export HOSTCC HOSTLD HOSTAR HOSTCFLAGS SHELLCHECK
>
> --
> 2.24.0
>