* [PATCH v5 1/7] dt-bindings: serial: sh-sci: don't required "reset" for r8a78000
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
@ 2025-09-18 6:25 ` Kuninori Morimoto
2025-09-18 9:19 ` Geert Uytterhoeven
2025-09-18 6:26 ` [PATCH v5 2/7] dt-bindings: serial: sh-sci: don't required "power-domain" Kuninori Morimoto
` (6 subsequent siblings)
7 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:25 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
commit 6ac1d6047372 ("dt-bindings: serial: sh-sci: Document r8a78000
bindings") added r8a78000 DT bindings for Renesas serial, and it sets
"resets" as "required", but it is not mandatory, because driver doesn't
use it. Remove it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
I'm not sure this is acceptable. This is optional patch.
If it was acceptable, I think we can remove "resets" from required not only for X5H...
Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 1 -
Documentation/devicetree/bindings/serial/renesas,scif.yaml | 1 -
2 files changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
index 4b3f98a46cd9d..d05a83b9513b7 100644
--- a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
@@ -126,7 +126,6 @@ if:
- renesas,rcar-gen2-hscif
- renesas,rcar-gen3-hscif
- renesas,rcar-gen4-hscif
- - renesas,rcar-gen5-hscif
then:
required:
- resets
diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index e925cd4c3ac8a..47cb99ba03607 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -181,7 +181,6 @@ allOf:
- renesas,rcar-gen2-scif
- renesas,rcar-gen3-scif
- renesas,rcar-gen4-scif
- - renesas,rcar-gen5-scif
- renesas,scif-r9a07g044
- renesas,scif-r9a09g057
then:
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 1/7] dt-bindings: serial: sh-sci: don't required "reset" for r8a78000
2025-09-18 6:25 ` [PATCH v5 1/7] dt-bindings: serial: sh-sci: don't required "reset" for r8a78000 Kuninori Morimoto
@ 2025-09-18 9:19 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2025-09-18 9:19 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Ian Rogers, Ingo Molnar, James Clark, Jiri Olsa,
John Garry, Krzysztof Kozlowski, Leo Yan, Lorenzo Pieralisi,
Mark Rutland, Mike Leach, Namhyung Kim, Oliver Upton,
Peter Zijlstra, Rob Herring, Shameer Kolothum, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier
Hi Morimoto-san,
On Thu, 18 Sept 2025 at 08:25, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> commit 6ac1d6047372 ("dt-bindings: serial: sh-sci: Document r8a78000
> bindings") added r8a78000 DT bindings for Renesas serial, and it sets
> "resets" as "required", but it is not mandatory, because driver doesn't
> use it. Remove it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks for your patch!
> I'm not sure this is acceptable. This is optional patch.
> If it was acceptable, I think we can remove "resets" from required not only for X5H...
The question is not "Does the driver use the reset signal?", but
"Does the hardware have a reset signal?".
According to Table 12.1 "Reset Categories and Reset Source" and Note 2,
the Module Controller takes care of Software Module Reset. However,
I couldn't find information about the individual module resets in the
documentation for the Module Controller.
> --- a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> @@ -126,7 +126,6 @@ if:
> - renesas,rcar-gen2-hscif
> - renesas,rcar-gen3-hscif
> - renesas,rcar-gen4-hscif
> - - renesas,rcar-gen5-hscif
> then:
> required:
> - resets
> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -181,7 +181,6 @@ allOf:
> - renesas,rcar-gen2-scif
> - renesas,rcar-gen3-scif
> - renesas,rcar-gen4-scif
> - - renesas,rcar-gen5-scif
> - renesas,scif-r9a07g044
> - renesas,scif-r9a09g057
> then:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 2/7] dt-bindings: serial: sh-sci: don't required "power-domain"
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
2025-09-18 6:25 ` [PATCH v5 1/7] dt-bindings: serial: sh-sci: don't required "reset" for r8a78000 Kuninori Morimoto
@ 2025-09-18 6:26 ` Kuninori Morimoto
2025-09-18 9:26 ` Geert Uytterhoeven
2025-09-18 6:26 ` [PATCH v5 3/7] tools: arm64: Add Cortex-A720AE definitions Kuninori Morimoto
` (5 subsequent siblings)
7 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:26 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
{H}SCIF is in the always-on power area. "power-domain" property is not
mandatory. Remove it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
I'm not sure this is acceptable patch. This is optional patch.
Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 1 -
Documentation/devicetree/bindings/serial/renesas,scif.yaml | 1 -
2 files changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
index d05a83b9513b7..7a7836c1409e9 100644
--- a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
@@ -116,7 +116,6 @@ required:
- interrupts
- clocks
- clock-names
- - power-domains
if:
properties:
diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index 47cb99ba03607..5dfcc408455ab 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -168,7 +168,6 @@ required:
- interrupts
- clocks
- clock-names
- - power-domains
allOf:
- $ref: serial.yaml#
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 2/7] dt-bindings: serial: sh-sci: don't required "power-domain"
2025-09-18 6:26 ` [PATCH v5 2/7] dt-bindings: serial: sh-sci: don't required "power-domain" Kuninori Morimoto
@ 2025-09-18 9:26 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2025-09-18 9:26 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
Hi Morimoto-san,
On Thu, 18 Sept 2025 at 08:26, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> {H}SCIF is in the always-on power area. "power-domain" property is not
> mandatory. Remove it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks for your patch!
> I'm not sure this is acceptable patch. This is optional patch.
(H)SCIF is indeed part of the always-on power area. However, like
for many other modules, its power management is handled similarly
through a clock/module controller. Hence it falls under the PM Domain
abstraction, and the power-domains property is justified.
What this power-domains property will point to on R-ar X5H is a
different question, as there are no DT bindings and no driver for the
clock/module controller yet...
> --- a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> @@ -116,7 +116,6 @@ required:
> - interrupts
> - clocks
> - clock-names
> - - power-domains
>
> if:
> properties:
> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -168,7 +168,6 @@ required:
> - interrupts
> - clocks
> - clock-names
> - - power-domains
>
> allOf:
> - $ref: serial.yaml#
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 3/7] tools: arm64: Add Cortex-A720AE definitions
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
2025-09-18 6:25 ` [PATCH v5 1/7] dt-bindings: serial: sh-sci: don't required "reset" for r8a78000 Kuninori Morimoto
2025-09-18 6:26 ` [PATCH v5 2/7] dt-bindings: serial: sh-sci: don't required "power-domain" Kuninori Morimoto
@ 2025-09-18 6:26 ` Kuninori Morimoto
2025-09-18 10:37 ` Will Deacon
2025-09-18 6:26 ` [PATCH v5 4/7] arm64: cputype: " Kuninori Morimoto
` (4 subsequent siblings)
7 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:26 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
Add cputype definitions for Cortex-A720AE. These will be used for errata
detection in subsequent patches.
These values can be found in the Cortex-A720AE TRM:
https://developer.arm.com/documentation/102828/0001/
... in Table A-187
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
tools/arch/arm64/include/asm/cputype.h | 2 ++
tools/perf/util/arm-spe.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/tools/arch/arm64/include/asm/cputype.h b/tools/arch/arm64/include/asm/cputype.h
index 139d5e87dc959..0192dc7ec9ca9 100644
--- a/tools/arch/arm64/include/asm/cputype.h
+++ b/tools/arch/arm64/include/asm/cputype.h
@@ -96,6 +96,7 @@
#define ARM_CPU_PART_NEOVERSE_V3 0xD84
#define ARM_CPU_PART_CORTEX_X925 0xD85
#define ARM_CPU_PART_CORTEX_A725 0xD87
+#define ARM_CPU_PART_CORTEX_A720AE 0xD89
#define ARM_CPU_PART_NEOVERSE_N3 0xD8E
#define APM_CPU_PART_XGENE 0x000
@@ -185,6 +186,7 @@
#define MIDR_NEOVERSE_V3 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_V3)
#define MIDR_CORTEX_X925 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_X925)
#define MIDR_CORTEX_A725 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A725)
+#define MIDR_CORTEX_A720AE MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A720AE)
#define MIDR_NEOVERSE_N3 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N3)
#define MIDR_THUNDERX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX)
#define MIDR_THUNDERX_81XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_81XX)
diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 228ed52e653d7..8acb4bdad0fb5 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -544,6 +544,7 @@ static int arm_spe__synth_instruction_sample(struct arm_spe_queue *speq,
static const struct midr_range common_ds_encoding_cpus[] = {
MIDR_ALL_VERSIONS(MIDR_CORTEX_A720),
+ MIDR_ALL_VERSIONS(MIDR_CORTEX_A720AE),
MIDR_ALL_VERSIONS(MIDR_CORTEX_A725),
MIDR_ALL_VERSIONS(MIDR_CORTEX_X1C),
MIDR_ALL_VERSIONS(MIDR_CORTEX_X3),
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 3/7] tools: arm64: Add Cortex-A720AE definitions
2025-09-18 6:26 ` [PATCH v5 3/7] tools: arm64: Add Cortex-A720AE definitions Kuninori Morimoto
@ 2025-09-18 10:37 ` Will Deacon
0 siblings, 0 replies; 21+ messages in thread
From: Will Deacon @ 2025-09-18 10:37 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier
On Thu, Sep 18, 2025 at 06:26:39AM +0000, Kuninori Morimoto wrote:
> Add cputype definitions for Cortex-A720AE. These will be used for errata
> detection in subsequent patches.
>
> These values can be found in the Cortex-A720AE TRM:
>
> https://developer.arm.com/documentation/102828/0001/
>
> ... in Table A-187
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> tools/arch/arm64/include/asm/cputype.h | 2 ++
> tools/perf/util/arm-spe.c | 1 +
> 2 files changed, 3 insertions(+)
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 4/7] arm64: cputype: Add Cortex-A720AE definitions
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
` (2 preceding siblings ...)
2025-09-18 6:26 ` [PATCH v5 3/7] tools: arm64: Add Cortex-A720AE definitions Kuninori Morimoto
@ 2025-09-18 6:26 ` Kuninori Morimoto
2025-09-18 10:46 ` Mark Rutland
2025-09-18 6:27 ` [PATCH v5 5/7] arm64: errata: Expand speculative SSBS workaround for Cortex-A720AE Kuninori Morimoto
` (3 subsequent siblings)
7 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:26 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
Add cputype definitions for Cortex-A720AE. These will be used for errata
detection in subsequent patches.
These values can be found in the Cortex-A720AE TRM:
https://developer.arm.com/documentation/102828/0001/
... in Table A-187
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm64/include/asm/cputype.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
index 661735616787e..b10eba7f52476 100644
--- a/arch/arm64/include/asm/cputype.h
+++ b/arch/arm64/include/asm/cputype.h
@@ -96,6 +96,7 @@
#define ARM_CPU_PART_NEOVERSE_V3 0xD84
#define ARM_CPU_PART_CORTEX_X925 0xD85
#define ARM_CPU_PART_CORTEX_A725 0xD87
+#define ARM_CPU_PART_CORTEX_A720AE 0xD89
#define ARM_CPU_PART_NEOVERSE_N3 0xD8E
#define APM_CPU_PART_XGENE 0x000
@@ -185,6 +186,7 @@
#define MIDR_NEOVERSE_V3 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_V3)
#define MIDR_CORTEX_X925 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_X925)
#define MIDR_CORTEX_A725 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A725)
+#define MIDR_CORTEX_A720AE MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A720AE)
#define MIDR_NEOVERSE_N3 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N3)
#define MIDR_THUNDERX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX)
#define MIDR_THUNDERX_81XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_81XX)
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 4/7] arm64: cputype: Add Cortex-A720AE definitions
2025-09-18 6:26 ` [PATCH v5 4/7] arm64: cputype: " Kuninori Morimoto
@ 2025-09-18 10:46 ` Mark Rutland
0 siblings, 0 replies; 21+ messages in thread
From: Mark Rutland @ 2025-09-18 10:46 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mike Leach, Namhyung Kim, Oliver Upton,
Peter Zijlstra, Rob Herring, Shameer Kolothum, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier
On Thu, Sep 18, 2025 at 06:26:55AM +0000, Kuninori Morimoto wrote:
> Add cputype definitions for Cortex-A720AE. These will be used for errata
> detection in subsequent patches.
>
> These values can be found in the Cortex-A720AE TRM:
>
> https://developer.arm.com/documentation/102828/0001/
>
> ... in Table A-187
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/include/asm/cputype.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index 661735616787e..b10eba7f52476 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -96,6 +96,7 @@
> #define ARM_CPU_PART_NEOVERSE_V3 0xD84
> #define ARM_CPU_PART_CORTEX_X925 0xD85
> #define ARM_CPU_PART_CORTEX_A725 0xD87
> +#define ARM_CPU_PART_CORTEX_A720AE 0xD89
> #define ARM_CPU_PART_NEOVERSE_N3 0xD8E
>
> #define APM_CPU_PART_XGENE 0x000
> @@ -185,6 +186,7 @@
> #define MIDR_NEOVERSE_V3 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_V3)
> #define MIDR_CORTEX_X925 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_X925)
> #define MIDR_CORTEX_A725 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A725)
> +#define MIDR_CORTEX_A720AE MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A720AE)
> #define MIDR_NEOVERSE_N3 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N3)
> #define MIDR_THUNDERX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX)
> #define MIDR_THUNDERX_81XX MIDR_CPU_MODEL(ARM_CPU_IMP_CAVIUM, CAVIUM_CPU_PART_THUNDERX_81XX)
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 5/7] arm64: errata: Expand speculative SSBS workaround for Cortex-A720AE
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
` (3 preceding siblings ...)
2025-09-18 6:26 ` [PATCH v5 4/7] arm64: cputype: " Kuninori Morimoto
@ 2025-09-18 6:27 ` Kuninori Morimoto
2025-09-18 10:49 ` Mark Rutland
2025-09-18 6:27 ` [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs Kuninori Morimoto
` (2 subsequent siblings)
7 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:27 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
It is same as Cortex-A720.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm64/kernel/cpu_errata.c | 1 +
arch/arm64/kernel/proton-pack.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 59d723c9ab8f5..7ff6b49beaaff 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -531,6 +531,7 @@ static const struct midr_range erratum_spec_ssbs_list[] = {
MIDR_ALL_VERSIONS(MIDR_CORTEX_A710),
MIDR_ALL_VERSIONS(MIDR_CORTEX_A715),
MIDR_ALL_VERSIONS(MIDR_CORTEX_A720),
+ MIDR_ALL_VERSIONS(MIDR_CORTEX_A720AE),
MIDR_ALL_VERSIONS(MIDR_CORTEX_A725),
MIDR_ALL_VERSIONS(MIDR_CORTEX_X1),
MIDR_ALL_VERSIONS(MIDR_CORTEX_X1C),
diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c
index edf1783ffc817..f9a32dfde0067 100644
--- a/arch/arm64/kernel/proton-pack.c
+++ b/arch/arm64/kernel/proton-pack.c
@@ -884,6 +884,7 @@ static u8 spectre_bhb_loop_affected(void)
static const struct midr_range spectre_bhb_k38_list[] = {
MIDR_ALL_VERSIONS(MIDR_CORTEX_A715),
MIDR_ALL_VERSIONS(MIDR_CORTEX_A720),
+ MIDR_ALL_VERSIONS(MIDR_CORTEX_A720AE),
{},
};
static const struct midr_range spectre_bhb_k32_list[] = {
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 5/7] arm64: errata: Expand speculative SSBS workaround for Cortex-A720AE
2025-09-18 6:27 ` [PATCH v5 5/7] arm64: errata: Expand speculative SSBS workaround for Cortex-A720AE Kuninori Morimoto
@ 2025-09-18 10:49 ` Mark Rutland
0 siblings, 0 replies; 21+ messages in thread
From: Mark Rutland @ 2025-09-18 10:49 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mike Leach, Namhyung Kim, Oliver Upton,
Peter Zijlstra, Rob Herring, Shameer Kolothum, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier
On Thu, Sep 18, 2025 at 06:27:12AM +0000, Kuninori Morimoto wrote:
> It is same as Cortex-A720.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
It might be worth saying that Cortex-A720AE is explciitly describedon
Arm's "Arm CPU Security Bulletin: Spectre/Meltdown" page at:
https://developer.arm.com/documentation/110280/3-0/
... and is described identially to Cortex-A720.
No need to respin for that, Will can choose to add that if he wants.
Either way:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/kernel/cpu_errata.c | 1 +
> arch/arm64/kernel/proton-pack.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 59d723c9ab8f5..7ff6b49beaaff 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -531,6 +531,7 @@ static const struct midr_range erratum_spec_ssbs_list[] = {
> MIDR_ALL_VERSIONS(MIDR_CORTEX_A710),
> MIDR_ALL_VERSIONS(MIDR_CORTEX_A715),
> MIDR_ALL_VERSIONS(MIDR_CORTEX_A720),
> + MIDR_ALL_VERSIONS(MIDR_CORTEX_A720AE),
> MIDR_ALL_VERSIONS(MIDR_CORTEX_A725),
> MIDR_ALL_VERSIONS(MIDR_CORTEX_X1),
> MIDR_ALL_VERSIONS(MIDR_CORTEX_X1C),
> diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c
> index edf1783ffc817..f9a32dfde0067 100644
> --- a/arch/arm64/kernel/proton-pack.c
> +++ b/arch/arm64/kernel/proton-pack.c
> @@ -884,6 +884,7 @@ static u8 spectre_bhb_loop_affected(void)
> static const struct midr_range spectre_bhb_k38_list[] = {
> MIDR_ALL_VERSIONS(MIDR_CORTEX_A715),
> MIDR_ALL_VERSIONS(MIDR_CORTEX_A720),
> + MIDR_ALL_VERSIONS(MIDR_CORTEX_A720AE),
> {},
> };
> static const struct midr_range spectre_bhb_k32_list[] = {
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
` (4 preceding siblings ...)
2025-09-18 6:27 ` [PATCH v5 5/7] arm64: errata: Expand speculative SSBS workaround for Cortex-A720AE Kuninori Morimoto
@ 2025-09-18 6:27 ` Kuninori Morimoto
2025-09-18 9:53 ` Geert Uytterhoeven
2025-09-18 10:01 ` Marc Zyngier
2025-09-18 6:27 ` [PATCH v5 7/7] arm64: dts: renesas: R8A78000: Add initial Ironhide support Kuninori Morimoto
2025-09-18 11:06 ` [PATCH v5 0/7] arm64: add R8A78000 support Will Deacon
7 siblings, 2 replies; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:27 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
From: Hai Pham <hai.pham.ud@renesas.com>
Add initial DT support for R8A78000 (R-Car X5H) SoC.
[Kuninori: tidyup for upstreaming]
Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@renesas.com>
Signed-off-by: Minh Le <minh.le.aj@renesas.com>
Signed-off-by: Huy Bui <huy.bui.wm@renesas.com>
Signed-off-by: Khanh Le <khanh.le.xr@renesas.com>
Signed-off-by: Phong Hoang <phong.hoang.wz@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a78000.dtsi | 787 ++++++++++++++++++++++
1 file changed, 787 insertions(+)
create mode 100644 arch/arm64/boot/dts/renesas/r8a78000.dtsi
diff --git a/arch/arm64/boot/dts/renesas/r8a78000.dtsi b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
new file mode 100644
index 0000000000000..96d87d5b50859
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
@@ -0,0 +1,787 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/*
+ * Device Tree Source for the R-Car X5H (R8A78000) SoC
+ *
+ * Copyright (C) 2025 Renesas Electronics Corp.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+/ {
+ compatible = "renesas,r8a78000";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ interrupt-parent = <&gic>;
+
+ cpus {
+ #address-cells = <2>;
+ #size-cells = <0>;
+
+ cpu-map {
+ cluster0 {
+ core0 {
+ cpu = <&a720_0>;
+ };
+ core1 {
+ cpu = <&a720_1>;
+ };
+ core2 {
+ cpu = <&a720_2>;
+ };
+ core3 {
+ cpu = <&a720_3>;
+ };
+ };
+
+ cluster1 {
+ core0 {
+ cpu = <&a720_4>;
+ };
+ core1 {
+ cpu = <&a720_5>;
+ };
+ core2 {
+ cpu = <&a720_6>;
+ };
+ core3 {
+ cpu = <&a720_7>;
+ };
+ };
+
+ cluster2 {
+ core0 {
+ cpu = <&a720_8>;
+ };
+ core1 {
+ cpu = <&a720_9>;
+ };
+ core2 {
+ cpu = <&a720_10>;
+ };
+ core3 {
+ cpu = <&a720_11>;
+ };
+ };
+
+ cluster3 {
+ core0 {
+ cpu = <&a720_12>;
+ };
+ core1 {
+ cpu = <&a720_13>;
+ };
+ core2 {
+ cpu = <&a720_14>;
+ };
+ core3 {
+ cpu = <&a720_15>;
+ };
+ };
+
+ cluster4 {
+ core0 {
+ cpu = <&a720_16>;
+ };
+ core1 {
+ cpu = <&a720_17>;
+ };
+ core2 {
+ cpu = <&a720_18>;
+ };
+ core3 {
+ cpu = <&a720_19>;
+ };
+ };
+
+ cluster5 {
+ core0 {
+ cpu = <&a720_20>;
+ };
+ core1 {
+ cpu = <&a720_21>;
+ };
+ core2 {
+ cpu = <&a720_22>;
+ };
+ core3 {
+ cpu = <&a720_23>;
+ };
+ };
+
+ cluster6 {
+ core0 {
+ cpu = <&a720_24>;
+ };
+ core1 {
+ cpu = <&a720_25>;
+ };
+ core2 {
+ cpu = <&a720_26>;
+ };
+ core3 {
+ cpu = <&a720_27>;
+ };
+ };
+
+ cluster7 {
+ core0 {
+ cpu = <&a720_28>;
+ };
+ core1 {
+ cpu = <&a720_29>;
+ };
+ core2 {
+ cpu = <&a720_30>;
+ };
+ core3 {
+ cpu = <&a720_31>;
+ };
+ };
+ };
+
+ a720_0: cpu@0 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x0>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_0>;
+ };
+
+ a720_1: cpu@100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_1>;
+ };
+
+ a720_2: cpu@200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_2>;
+ };
+
+ a720_3: cpu@300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_3>;
+ };
+
+ a720_4: cpu@10000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x10000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_4>;
+ };
+
+ a720_5: cpu@10100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x10100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_5>;
+ };
+
+ a720_6: cpu@10200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x10200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_6>;
+ };
+
+ a720_7: cpu@10300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x10300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_7>;
+ };
+
+ a720_8: cpu@20000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x20000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_8>;
+ };
+
+ a720_9: cpu@20100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x20100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_9>;
+ };
+
+ a720_10: cpu@20200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x20200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_10>;
+ };
+
+ a720_11: cpu@20300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x20300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_11>;
+ };
+
+ a720_12: cpu@30000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x30000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_12>;
+ };
+
+ a720_13: cpu@30100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x30100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_13>;
+ };
+
+ a720_14: cpu@30200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x30200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_14>;
+ };
+
+ a720_15: cpu@30300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x30300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_15>;
+ };
+
+ a720_16: cpu@40000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x40000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_16>;
+ };
+
+ a720_17: cpu@40100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x40100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_17>;
+ };
+
+ a720_18: cpu@40200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x40200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_18>;
+ };
+
+ a720_19: cpu@40300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x40300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_19>;
+ };
+
+ a720_20: cpu@50000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x50000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_20>;
+ };
+
+ a720_21: cpu@50100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x50100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_21>;
+ };
+
+ a720_22: cpu@50200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x50200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_22>;
+ };
+
+ a720_23: cpu@50300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x50300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_23>;
+ };
+
+ a720_24: cpu@60000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x60000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_24>;
+ };
+
+ a720_25: cpu@60100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x60100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_25>;
+ };
+
+ a720_26: cpu@60200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x60200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_26>;
+ };
+
+ a720_27: cpu@60300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x60300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_27>;
+ };
+
+ a720_28: cpu@70000 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x70000>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_28>;
+ };
+
+ a720_29: cpu@70100 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x70100>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_29>;
+ };
+
+ a720_30: cpu@70200 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x70200>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_30>;
+ };
+
+ a720_31: cpu@70300 {
+ compatible = "arm,cortex-a720ae";
+ reg = <0x0 0x70300>;
+ device_type = "cpu";
+ next-level-cache = <&L2_CA720_31>;
+ };
+
+ L2_CA720_0: cache-controller-200 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_0>;
+ };
+
+ L2_CA720_1: cache-controller-201 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_0>;
+ };
+
+ L2_CA720_2: cache-controller-202 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_0>;
+ };
+
+ L2_CA720_3: cache-controller-203 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_0>;
+ };
+
+ L2_CA720_4: cache-controller-204 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_1>;
+ };
+
+ L2_CA720_5: cache-controller-205 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_1>;
+ };
+
+ L2_CA720_6: cache-controller-206 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_1>;
+ };
+
+ L2_CA720_7: cache-controller-207 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_1>;
+ };
+
+ L2_CA720_8: cache-controller-208 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_2>;
+ };
+
+ L2_CA720_9: cache-controller-209 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_2>;
+ };
+
+ L2_CA720_10: cache-controller-210 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_2>;
+ };
+
+ L2_CA720_11: cache-controller-211 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_2>;
+ };
+
+ L2_CA720_12: cache-controller-212 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_3>;
+ };
+
+ L2_CA720_13: cache-controller-213 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_3>;
+ };
+
+ L2_CA720_14: cache-controller-214 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_3>;
+ };
+
+ L2_CA720_15: cache-controller-215 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_3>;
+ };
+
+ L2_CA720_16: cache-controller-216 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_4>;
+ };
+
+ L2_CA720_17: cache-controller-217 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_4>;
+ };
+
+ L2_CA720_18: cache-controller-218 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_4>;
+ };
+
+ L2_CA720_19: cache-controller-219 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_4>;
+ };
+
+ L2_CA720_20: cache-controller-220 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_5>;
+ };
+
+ L2_CA720_21: cache-controller-221 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_5>;
+ };
+
+ L2_CA720_22: cache-controller-222 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_5>;
+ };
+
+ L2_CA720_23: cache-controller-223 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_5>;
+ };
+
+ L2_CA720_24: cache-controller-224 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_6>;
+ };
+
+ L2_CA720_25: cache-controller-225 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_6>;
+ };
+
+ L2_CA720_26: cache-controller-226 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_6>;
+ };
+
+ L2_CA720_27: cache-controller-227 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_6>;
+ };
+
+ L2_CA720_28: cache-controller-228 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_7>;
+ };
+
+ L2_CA720_29: cache-controller-229 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_7>;
+ };
+
+ L2_CA720_30: cache-controller-230 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_7>;
+ };
+
+ L2_CA720_31: cache-controller-231 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
+ next-level-cache = <&L3_CA720_7>;
+ };
+
+ L3_CA720_0: cache-controller-30 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_1: cache-controller-31 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_2: cache-controller-32 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_3: cache-controller-33 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_4: cache-controller-34 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_5: cache-controller-35 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_6: cache-controller-36 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+
+ L3_CA720_7: cache-controller-37 {
+ compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
+ };
+ };
+
+ extal_clk: extal-clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ /* clock-frequency must be set on board */
+ };
+
+ extalr_clk: extalr-clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ /* clock-frequency must be set on board */
+ };
+
+ /*
+ * In the early phase, there is no clock control support,
+ * so assume that the clocks are enabled by default.
+ * Therefore, dummy clocks are used.
+ */
+ dummy_clk_sgasyncd4: dummy-clk-sgasyncd4 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <266660000>;
+ };
+
+ dummy_clk_sgasyncd16: dummy-clk-sgasyncd16 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <66666000>;
+ };
+
+ /* External SCIF clock - to be overridden by boards that provide it */
+ scif_clk: scif-clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>; /* optional */
+ };
+
+ soc: soc {
+ compatible = "simple-bus";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ prr: chipid@189e0044 {
+ compatible = "renesas,prr";
+ reg = <0 0x189e0044 0 4>;
+ };
+
+ /*
+ * The ARM GIC-720AE - View 1
+ *
+ * see
+ * r19uh0244ej0052-r-carx5h.pdf
+ * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
+ * - sheet [RT]
+ * - line 619
+ */
+ gic: interrupt-controller@39000000 {
+ compatible = "arm,gic-v3";
+ #interrupt-cells = <3>;
+ #address-cells = <0>;
+ interrupt-controller;
+ reg = <0 0x39000000 0 0x20000>,
+ <0 0x39080000 0 0x800000>;
+ interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ };
+
+ scif0: serial@c0700000 {
+ compatible = "renesas,scif-r8a78000", "renesas,rcar-gen5-scif", "renesas,scif";
+ reg = <0 0xc0700000 0 0x40>;
+ interrupts = <GIC_SPI 4074 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd16>, <&dummy_clk_sgasyncd16>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ scif1: serial@c0704000 {
+ compatible = "renesas,scif-r8a78000", "renesas,rcar-gen5-scif", "renesas,scif";
+ reg = <0 0xc0704000 0 0x40>;
+ interrupts = <GIC_SPI 4075 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd16>, <&dummy_clk_sgasyncd16>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ scif3: serial@c0708000 {
+ compatible = "renesas,scif-r8a78000", "renesas,rcar-gen5-scif", "renesas,scif";
+ reg = <0 0xc0708000 0 0x40>;
+ interrupts = <GIC_SPI 4076 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd16>, <&dummy_clk_sgasyncd16>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ scif4: serial@c070c000 {
+ compatible = "renesas,scif-r8a78000", "renesas,rcar-gen5-scif", "renesas,scif";
+ reg = <0 0xc070c000 0 0x40>;
+ interrupts = <GIC_SPI 4077 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd16>, <&dummy_clk_sgasyncd16>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ hscif0: serial@c0710000 {
+ compatible = "renesas,hscif-r8a78000", "renesas,rcar-gen5-hscif", "renesas,hscif";
+ reg = <0 0xc0710000 0 0x60>;
+ interrupts = <GIC_SPI 4078 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd4>, <&dummy_clk_sgasyncd4>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ hscif1: serial@c0714000 {
+ compatible = "renesas,hscif-r8a78000", "renesas,rcar-gen5-hscif", "renesas,hscif";
+ reg = <0 0xc0714000 0 0x60>;
+ interrupts = <GIC_SPI 4079 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd4>, <&dummy_clk_sgasyncd4>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ hscif2: serial@c0718000 {
+ compatible = "renesas,hscif-r8a78000", "renesas,rcar-gen5-hscif", "renesas,hscif";
+ reg = <0 0xc0718000 0 0x60>;
+ interrupts = <GIC_SPI 4080 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd4>, <&dummy_clk_sgasyncd4>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+
+ hscif3: serial@c071c000 {
+ compatible = "renesas,hscif-r8a78000", "renesas,rcar-gen5-hscif", "renesas,hscif";
+ reg = <0 0xc071c000 0 0x60>;
+ interrupts = <GIC_SPI 4081 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dummy_clk_sgasyncd4>, <&dummy_clk_sgasyncd4>, <&scif_clk>;
+ clock-names = "fck", "brg_int", "scif_clk";
+ status = "disabled";
+ };
+ };
+
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 12 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "sec-phys", "phys", "virt", "hyp-phys", "hyp-virt";
+ };
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-18 6:27 ` [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs Kuninori Morimoto
@ 2025-09-18 9:53 ` Geert Uytterhoeven
2025-09-18 10:01 ` Marc Zyngier
1 sibling, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2025-09-18 9:53 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Ian Rogers, Ingo Molnar, James Clark, Jiri Olsa,
John Garry, Krzysztof Kozlowski, Leo Yan, Lorenzo Pieralisi,
Mark Rutland, Mike Leach, Namhyung Kim, Oliver Upton,
Peter Zijlstra, Rob Herring, Shameer Kolothum, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier
Hi Morimoto-san,
On Thu, 18 Sept 2025 at 08:27, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Hai Pham <hai.pham.ud@renesas.com>
>
> Add initial DT support for R8A78000 (R-Car X5H) SoC.
>
> [Kuninori: tidyup for upstreaming]
>
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@renesas.com>
> Signed-off-by: Minh Le <minh.le.aj@renesas.com>
> Signed-off-by: Huy Bui <huy.bui.wm@renesas.com>
> Signed-off-by: Khanh Le <khanh.le.xr@renesas.com>
> Signed-off-by: Phong Hoang <phong.hoang.wz@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks for your patch!
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> + extalr_clk: extalr-clk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + /* clock-frequency must be set on board */
> + };
> +
> + /*
> + * In the early phase, there is no clock control support,
> + * so assume that the clocks are enabled by default.
> + * Therefore, dummy clocks are used.
> + */
> + dummy_clk_sgasyncd4: dummy-clk-sgasyncd4 {
Please keep nodes sorted (alphabetically, by node name).
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <266660000>;
> + };
> +
> + dummy_clk_sgasyncd16: dummy-clk-sgasyncd16 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <66666000>;
> + };
> + soc: soc {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + prr: chipid@189e0044 {
> + compatible = "renesas,prr";
> + reg = <0 0x189e0044 0 4>;
> + };
> +
> + /*
> + * The ARM GIC-720AE - View 1
> + *
> + * see
> + * r19uh0244ej0052-r-carx5h.pdf
> + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> + * - sheet [RT]
> + * - line 619
> + */
> + gic: interrupt-controller@39000000 {
> + compatible = "arm,gic-v3";
> + #interrupt-cells = <3>;
> + #address-cells = <0>;
> + interrupt-controller;
> + reg = <0 0x39000000 0 0x20000>,
The DT bindings say the first region should be GICD (no mention of
GICM), so shouldn't the size be 0x10000?
See Table 21.9 "GIC-720AE Base address".
> + <0 0x39080000 0 0x800000>;
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + scif0: serial@c0700000 {
> + compatible = "renesas,scif-r8a78000", "renesas,rcar-gen5-scif", "renesas,scif";
Some lines are getting a bit long, but that is not something I cannot
fix while applying...
> + reg = <0 0xc0700000 0 0x40>;
> + interrupts = <GIC_SPI 4074 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&dummy_clk_sgasyncd16>, <&dummy_clk_sgasyncd16>, <&scif_clk>;
> + clock-names = "fck", "brg_int", "scif_clk";
> + status = "disabled";
> + };
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-18 6:27 ` [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs Kuninori Morimoto
2025-09-18 9:53 ` Geert Uytterhoeven
@ 2025-09-18 10:01 ` Marc Zyngier
2025-09-19 6:52 ` Geert Uytterhoeven
1 sibling, 1 reply; 21+ messages in thread
From: Marc Zyngier @ 2025-09-18 10:01 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc
3rd resend in a matter of hours -- how about slowing down?
Also, dropping Shameer's bouncing email address from Cc. Surely you
can fix your (enormous, and pretty random) Cc list?
On Thu, 18 Sep 2025 07:27:26 +0100,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
>
[...]
> + /*
> + * The ARM GIC-720AE - View 1
> + *
> + * see
> + * r19uh0244ej0052-r-carx5h.pdf
> + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> + * - sheet [RT]
> + * - line 619
> + */
> + gic: interrupt-controller@39000000 {
> + compatible = "arm,gic-v3";
> + #interrupt-cells = <3>;
> + #address-cells = <0>;
> + interrupt-controller;
> + reg = <0 0x39000000 0 0x20000>,
> + <0 0x39080000 0 0x800000>;
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + };
I already asked for:
- this comment to be dropped, as it serves zero purpose to the common
mortal
- the ITS to be described. The HW has it, it has no dependency on
anything else, so there is no reason to omit it.
So I'd suggest you slow down, and take the comments reviewers give you
into account.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-18 10:01 ` Marc Zyngier
@ 2025-09-19 6:52 ` Geert Uytterhoeven
2025-09-19 8:33 ` Marc Zyngier
0 siblings, 1 reply; 21+ messages in thread
From: Geert Uytterhoeven @ 2025-09-19 6:52 UTC (permalink / raw)
To: Marc Zyngier
Cc: Kuninori Morimoto, Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc
Hi Marc,
On Thu, 18 Sept 2025 at 12:01, Marc Zyngier <maz@kernel.org> wrote:
> On Thu, 18 Sep 2025 07:27:26 +0100,
> Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> > + /*
> > + * The ARM GIC-720AE - View 1
> > + *
> > + * see
> > + * r19uh0244ej0052-r-carx5h.pdf
> > + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> > + * - sheet [RT]
> > + * - line 619
> > + */
> > + gic: interrupt-controller@39000000 {
> > + compatible = "arm,gic-v3";
> > + #interrupt-cells = <3>;
> > + #address-cells = <0>;
> > + interrupt-controller;
> > + reg = <0 0x39000000 0 0x20000>,
> > + <0 0x39080000 0 0x800000>;
> > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > + };
>
> I already asked for:
>
> - this comment to be dropped, as it serves zero purpose to the common
> mortal
What about using a different comment instead?
/* Linux must use I/F Region 1 */
I.e. replace "View 1" by the above.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-19 6:52 ` Geert Uytterhoeven
@ 2025-09-19 8:33 ` Marc Zyngier
2025-09-23 23:56 ` Kuninori Morimoto
0 siblings, 1 reply; 21+ messages in thread
From: Marc Zyngier @ 2025-09-19 8:33 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kuninori Morimoto, Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc
Hi Geert,
On Fri, 19 Sep 2025 07:52:38 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Marc,
>
> On Thu, 18 Sept 2025 at 12:01, Marc Zyngier <maz@kernel.org> wrote:
> > On Thu, 18 Sep 2025 07:27:26 +0100,
> > Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> > > + /*
> > > + * The ARM GIC-720AE - View 1
> > > + *
> > > + * see
> > > + * r19uh0244ej0052-r-carx5h.pdf
> > > + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> > > + * - sheet [RT]
> > > + * - line 619
> > > + */
> > > + gic: interrupt-controller@39000000 {
> > > + compatible = "arm,gic-v3";
> > > + #interrupt-cells = <3>;
> > > + #address-cells = <0>;
> > > + interrupt-controller;
> > > + reg = <0 0x39000000 0 0x20000>,
> > > + <0 0x39080000 0 0x800000>;
> > > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > > + };
> >
> > I already asked for:
> >
> > - this comment to be dropped, as it serves zero purpose to the common
> > mortal
>
> What about using a different comment instead?
>
> /* Linux must use I/F Region 1 */
>
> I.e. replace "View 1" by the above.
I definitely wouldn't mention Linux, as the DT is not specific to any
particular OS. This is more about what block the main CPUs are allowed
to use. Also, "View" is the term used in the TRM to describe the
multiplexing of multiple GIC "instances" on a single GIC
implementation in a mixed-criticality system, so keeping it makes more
sense.
Something like:
/* Application Processors manage View-1 of a GIC-720AE */
and the mention of the TRM and other spreadsheets dropped.
Thanks,
M.
--
Jazz isn't dead. It just smells funny.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-19 8:33 ` Marc Zyngier
@ 2025-09-23 23:56 ` Kuninori Morimoto
2025-09-24 9:37 ` Marc Zyngier
0 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-23 23:56 UTC (permalink / raw)
To: Marc Zyngier
Cc: Geert Uytterhoeven, Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc
Hi Marc
# sorry for late response. I had took day-off
> > > > + /*
> > > > + * The ARM GIC-720AE - View 1
> > > > + *
> > > > + * see
> > > > + * r19uh0244ej0052-r-carx5h.pdf
> > > > + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> > > > + * - sheet [RT]
> > > > + * - line 619
> > > > + */
(snip)
> Something like:
>
> /* Application Processors manage View-1 of a GIC-720AE */
>
> and the mention of the TRM and other spreadsheets dropped.
OK, will do
> the ITS to be described. The HW has it, it has no dependency on
> anything else, so there is no reason to omit it.
I had asked HW team and PCI team, and there is a valid reason
why we would like to skip it. Because we had issues with using ITS on
previous SoCs. Hence we are reluctant to describe it until we can
actually test it.
So far, we never submitted a complete .dtsi in one go, but always enabled
more functionality in incremental steps, after verifying that it actually
works.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
2025-09-23 23:56 ` Kuninori Morimoto
@ 2025-09-24 9:37 ` Marc Zyngier
0 siblings, 0 replies; 21+ messages in thread
From: Marc Zyngier @ 2025-09-24 9:37 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Geert Uytterhoeven, Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc
On Wed, 24 Sep 2025 00:56:28 +0100,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Marc
>
> # sorry for late response. I had took day-off
>
> > > > > + /*
> > > > > + * The ARM GIC-720AE - View 1
> > > > > + *
> > > > > + * see
> > > > > + * r19uh0244ej0052-r-carx5h.pdf
> > > > > + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> > > > > + * - sheet [RT]
> > > > > + * - line 619
> > > > > + */
> (snip)
> > Something like:
> >
> > /* Application Processors manage View-1 of a GIC-720AE */
> >
> > and the mention of the TRM and other spreadsheets dropped.
>
> OK, will do
>
> > the ITS to be described. The HW has it, it has no dependency on
> > anything else, so there is no reason to omit it.
>
> I had asked HW team and PCI team, and there is a valid reason
> why we would like to skip it. Because we had issues with using ITS on
> previous SoCs. Hence we are reluctant to describe it until we can
> actually test it.
Posting patches for partially HW doesn't feel like a great approach.
> So far, we never submitted a complete .dtsi in one go, but always enabled
> more functionality in incremental steps, after verifying that it actually
> works.
Well, the GIC (and specially ARM's implementation) is a whole entity,
not something you can cut and dice. Just like you wouldn't describe
the CPUs without their timers.
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 7/7] arm64: dts: renesas: R8A78000: Add initial Ironhide support
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
` (5 preceding siblings ...)
2025-09-18 6:27 ` [PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs Kuninori Morimoto
@ 2025-09-18 6:27 ` Kuninori Morimoto
2025-09-18 10:01 ` Geert Uytterhoeven
2025-09-18 11:06 ` [PATCH v5 0/7] arm64: add R8A78000 support Will Deacon
7 siblings, 1 reply; 21+ messages in thread
From: Kuninori Morimoto @ 2025-09-18 6:27 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
Will Deacon, devicetree, linux-arm-kernel, linux-perf-users,
linux-renesas-soc, Marc Zyngier
From: Hai Pham <hai.pham.ud@renesas.com>
Add the initial support for Renesas X5H Ironhide board.
Note: It is using "maxcpus" in bootargs to limit number of CPU, because
SMP support is now under development. This limitation will be removed
in the future.
[Kuninori: tidyup for upstreaming]
Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Khanh Le <khanh.le.xr@renesas.com>
Signed-off-by: Huy Bui <huy.bui.wm@renesas.com>
Signed-off-by: Phong Hoang <phong.hoang.wz@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm64/boot/dts/renesas/Makefile | 2 +
.../boot/dts/renesas/r8a78000-ironhide.dts | 85 +++++++++++++++++++
2 files changed, 87 insertions(+)
create mode 100644 arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index ccdf7aaeca13e..dde046a3f25c8 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -136,6 +136,8 @@ dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb
r8a779m5-salvator-xs-panel-aa104xd12-dtbs := r8a779m5-salvator-xs.dtb salvator-panel-aa104xd12.dtbo
dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs-panel-aa104xd12.dtb
+dtb-$(CONFIG_ARCH_R8A78000) += r8a78000-ironhide.dtb
+
dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc.dtb
dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-cru-csi-ov5645.dtbo
dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-du-adv7513.dtbo
diff --git a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
new file mode 100644
index 0000000000000..a721734fbd5d0
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
@@ -0,0 +1,85 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/*
+ * Device Tree Source for the Ironhide board
+ *
+ * Copyright (C) 2025 Renesas Electronics Corp.
+ */
+
+/dts-v1/;
+#include "r8a78000.dtsi"
+
+/ {
+ model = "Renesas Ironhide board based on r8a78000";
+ compatible = "renesas,ironhide", "renesas,r8a78000";
+
+ aliases {
+ serial0 = &hscif0;
+ };
+
+ chosen {
+ stdout-path = "serial0:1843200n8";
+ };
+
+ memory@60600000 {
+ device_type = "memory";
+ /* first 518MiB is reserved for other purposes. */
+ reg = <0x0 0x60600000 0x0 0x5fa00000>;
+ };
+
+ memory@1080000000 {
+ device_type = "memory";
+ reg = <0x10 0x80000000 0x0 0x80000000>;
+ };
+
+ memory@1200000000 {
+ device_type = "memory";
+ reg = <0x12 0x00000000 0x1 0x00000000>;
+ };
+
+ memory@1400000000 {
+ device_type = "memory";
+ reg = <0x14 0x00000000 0x1 0x00000000>;
+ };
+
+ memory@1600000000 {
+ device_type = "memory";
+ reg = <0x16 0x00000000 0x1 0x00000000>;
+ };
+
+ memory@1800000000 {
+ device_type = "memory";
+ reg = <0x18 0x00000000 0x1 0x00000000>;
+ };
+
+ memory@1a00000000 {
+ device_type = "memory";
+ reg = <0x1a 0x00000000 0x1 0x00000000>;
+ };
+
+ memory@1c00000000 {
+ device_type = "memory";
+ reg = <0x1c 0x00000000 0x1 0x00000000>;
+ };
+
+ memory@1e00000000 {
+ device_type = "memory";
+ reg = <0x1e 0x00000000 0x1 0x00000000>;
+ };
+};
+
+&extal_clk {
+ clock-frequency = <16666600>;
+};
+
+&extalr_clk {
+ clock-frequency = <32768>;
+};
+
+&hscif0 {
+ uart-has-rtscts;
+ status = "okay";
+};
+
+&scif_clk {
+ clock-frequency = <26000000>;
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v5 7/7] arm64: dts: renesas: R8A78000: Add initial Ironhide support
2025-09-18 6:27 ` [PATCH v5 7/7] arm64: dts: renesas: R8A78000: Add initial Ironhide support Kuninori Morimoto
@ 2025-09-18 10:01 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2025-09-18 10:01 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Ian Rogers, Ingo Molnar, James Clark, Jiri Olsa,
John Garry, Krzysztof Kozlowski, Leo Yan, Lorenzo Pieralisi,
Mark Rutland, Mike Leach, Namhyung Kim, Oliver Upton,
Peter Zijlstra, Rob Herring, Shameer Kolothum, Will Deacon,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier
Hi Morimoto-san,
Thanks for your patch!
On Thu, 18 Sept 2025 at 08:27, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Hai Pham <hai.pham.ud@renesas.com>
>
> Add the initial support for Renesas X5H Ironhide board.
>
> Note: It is using "maxcpus" in bootargs to limit number of CPU, because
> SMP support is now under development. This limitation will be removed
> in the future.
You forgot to drop this paragraph.
>
> [Kuninori: tidyup for upstreaming]
>
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Khanh Le <khanh.le.xr@renesas.com>
> Signed-off-by: Huy Bui <huy.bui.wm@renesas.com>
> Signed-off-by: Phong Hoang <phong.hoang.wz@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5 0/7] arm64: add R8A78000 support
2025-09-18 6:23 [PATCH v5 0/7] arm64: add R8A78000 support Kuninori Morimoto
` (6 preceding siblings ...)
2025-09-18 6:27 ` [PATCH v5 7/7] arm64: dts: renesas: R8A78000: Add initial Ironhide support Kuninori Morimoto
@ 2025-09-18 11:06 ` Will Deacon
7 siblings, 0 replies; 21+ messages in thread
From: Will Deacon @ 2025-09-18 11:06 UTC (permalink / raw)
To: Liang, Kan, Adrian Hunter, Alexander Shishkin,
Arnaldo Carvalho de Melo, Catalin Marinas, Conor Dooley,
Douglas Anderson, Geert Uytterhoeven, Ian Rogers, Ingo Molnar,
James Clark, Jiri Olsa, John Garry, Krzysztof Kozlowski, Leo Yan,
Lorenzo Pieralisi, Mark Rutland, Mike Leach, Namhyung Kim,
Oliver Upton, Peter Zijlstra, Rob Herring, Shameer Kolothum,
devicetree, linux-arm-kernel, linux-perf-users, linux-renesas-soc,
Marc Zyngier, Kuninori Morimoto
Cc: kernel-team, Will Deacon
On Thu, 18 Sep 2025 06:23:07 +0000, Kuninori Morimoto wrote:
> This is v5 of R8A78000 support for Renesas.
>
> This patch-set adds R8A78000 and Ironhide board support.
> It is based on SDK v4.28.0 or later. It will be released at end of Oct.
>
> Link: https://lore.kernel.org/r/87ecs5abp9.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/87tt13i0lh.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/87o6rjvzf4.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/87tt1c9z7h.wl-kuninori.morimoto.gx@renesas.com
>
> [...]
Applied MIDR bits to arm64 (for-next/cpufeature), thanks!
[4/7] arm64: cputype: Add Cortex-A720AE definitions
https://git.kernel.org/arm64/c/f38c2c3e572c
[5/7] arm64: errata: Expand speculative SSBS workaround for Cortex-A720AE
https://git.kernel.org/arm64/c/3ba8d4aa42bd
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 21+ messages in thread