From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"James Clark" <james.clark@linaro.org>,
"Howard Chu" <howardchu95@gmail.com>,
"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Stephen Brennan" <stephen.s.brennan@oracle.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
"Daniel Xu" <dxu@dxuuu.xyz>,
"Ariel Ben-Yehuda" <ariel.byd@gmail.com>
Subject: Re: [PATCH v2 1/6] perf demangle-rust: Add rustc-demangle C demangler
Date: Wed, 30 Apr 2025 05:37:42 +0200 [thread overview]
Message-ID: <CANiq72ksEJdnT86V42hoNVfB7OpmaouD+eBQwpRJR899nPsttA@mail.gmail.com> (raw)
In-Reply-To: <20250430004128.474388-2-irogers@google.com>
On Wed, Apr 30, 2025 at 2:41 AM Ian Rogers <irogers@google.com> wrote:
>
> Imported at commit 80e40f57d99f ("add comment about finding latest
> version of code") from:
> https://github.com/rust-lang/rustc-demangle/blob/main/crates/native-c/src/demangle.c
> https://github.com/rust-lang/rustc-demangle/blob/main/crates/native-c/include/demangle.h
>
> There is discussion of this issue motivating the import in:
> https://github.com/rust-lang/rust/issues/60705
> https://lore.kernel.org/lkml/20250129193037.573431-1-irogers@google.com/
>
> The SPDX lines reflect the dual license Apache-2 or MIT in:
> https://github.com/rust-lang/rustc-demangle/blob/main/README.md
> Following Migual Ojeda's suggestion comments were added on copyright
> and keeping the code in sync with upstream.
Thanks! I doubled-checked that the files added here are essentially
equal to upstream, modulo trailing whitespace cleanups, the header
addition and the change to the include name, so:
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
(Typo on "Migual", but I don't mind it -- it sounds like "M-equal" :)
Cheers,
Miguel
next prev parent reply other threads:[~2025-04-30 3:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 0:41 [PATCH v2 0/6] Use rustc-demangle for Rust demangling Ian Rogers
2025-04-30 0:41 ` [PATCH v2 1/6] perf demangle-rust: Add rustc-demangle C demangler Ian Rogers
2025-04-30 3:37 ` Miguel Ojeda [this message]
2025-04-30 14:48 ` Ian Rogers
2025-04-30 0:41 ` [PATCH v2 2/6] perf symbol-elf: Integrate rust-v0 demangling Ian Rogers
2025-04-30 0:41 ` [PATCH v2 3/6] perf demangle-rust: Remove previous legacy rust decoder Ian Rogers
2025-04-30 0:41 ` [PATCH v2 4/6] perf test demangle-rust: Add Rust demangling test Ian Rogers
2025-04-30 0:41 ` [PATCH v2 5/6] perf test demangle-java: Switch to using dso__demangle_sym Ian Rogers
2025-04-30 0:41 ` [PATCH v2 6/6] perf test demangle-ocaml: " Ian Rogers
2025-05-09 20:03 ` [PATCH v2 0/6] Use rustc-demangle for Rust demangling Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72ksEJdnT86V42hoNVfB7OpmaouD+eBQwpRJR899nPsttA@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alex.gaynor@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aliceryhl@google.com \
--cc=ariel.byd@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=gary@garyguo.net \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=stephen.s.brennan@oracle.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).