From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C163BC77B60 for ; Sat, 29 Apr 2023 21:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbjD2Va6 (ORCPT ); Sat, 29 Apr 2023 17:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbjD2Va5 (ORCPT ); Sat, 29 Apr 2023 17:30:57 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0833E6B for ; Sat, 29 Apr 2023 14:30:56 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-329577952c5so755485ab.1 for ; Sat, 29 Apr 2023 14:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682803856; x=1685395856; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kzdpTpVqVAbcBmm57skQ5w54yJzO0yjUjXTiorZSwZU=; b=qGHa5T1rAGzVj/YuUB9S4wn/CfiB+WAlGRiaE1+2b2REq3qzpun+H/3Mmx4ymsqOf0 9y0MKDosArJLELDw0W/vyr5Ij1Za1BbV3xrg//xa/1sHVc8G56WK3tkeFSGzuxO2Md1H DsCfeQmhLx5HrACcioHu/1+pVOhFDLmaVpX/0AxEZbxIFXXu0agg+xARXYsc0y/EYiOV T+sNeopW+tkBzbypXiuQB1OqaWH+WuSrPKySjuUE9gw58tYFb5zi+6DfNfVMJR08xrUg ic7IktmxfwesjVHGaFzcCvVeWRbB607GY52EqwJBhSXjwivH539DJBe2L1/5vRJ0GwyQ abBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682803856; x=1685395856; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kzdpTpVqVAbcBmm57skQ5w54yJzO0yjUjXTiorZSwZU=; b=lfuxdJ6lyfMhaE69Jk64+g6a4y708hSlQLwGDZxn7TR3rp2jdkjt8aFm6NHAhjans8 FnP7raHWigHijns0mGEHIEMYaCstrmDy4NRff7wIlX9pnJqAt5hfjgid2M9O7aUpi1+P sOccfTlwLWPUfSzzt/aU4FKEIwIFx8MTxBqcGKVUefZ/7ZtO+AxnCzhwAv5iVjlfTQRq v337Eit1cILn2lobSGSAfrFRrXSOUjKt44HB8jfDIs/lRxbDX50LUCXnVTGwQLM0C86Q vQkg0niOxCW3iqBb/a7kPiU1VMGdDi/pLdwtuP7ezTejloWgfnX+c58qm7jZQcx2gRJ1 FiLQ== X-Gm-Message-State: AC+VfDzB/vCJwhqthCNkyapaBFr8ozfE+vjjCBUDmI6kqLkpGxZCMAYT Gcz8gPyfpi9JuRfyFf3Ys/vW8LT0RJaOagiqpA8T5w== X-Google-Smtp-Source: ACHHUZ4Aiq0TvEoJUc7kDutZjKkhhjfLXc4HK8Wz3M32TsGV+A57Cht7IvWeDX4jqvkwxTGzhyET1vhqhXx7funo4VI= X-Received: by 2002:a05:6e02:1c25:b0:31f:ba43:2ed5 with SMTP id m5-20020a056e021c2500b0031fba432ed5mr169139ilh.11.1682803855773; Sat, 29 Apr 2023 14:30:55 -0700 (PDT) MIME-Version: 1.0 References: <20230428125345.8924-1-adrian.hunter@intel.com> In-Reply-To: <20230428125345.8924-1-adrian.hunter@intel.com> From: Ian Rogers Date: Sat, 29 Apr 2023 14:30:44 -0700 Message-ID: Subject: Re: [PATCH V2 0/1] perf tools: Allow config terms with breakpoints To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, Apr 28, 2023 at 5:54=E2=80=AFAM Adrian Hunter wrote: > > Hi > > Here is a patch (V2) to the event parser for breakpoint events. > I am not that familiar with flex / bison, but it seemed to > need trailing context to stop the mem event colon and slash > delimiters from getting mixed up with delimiters for config > terms or event modifiers. Please look closely at that. > > > Change in V2: > > Add comments to tools/perf/util/parse-events.l > Add a test for 2 mem events back to back with config terms Thanks for the tests/comments! Reviewed-by: Ian Rogers Ian > > Adrian Hunter (1): > perf tools: Allow config terms with breakpoints > > tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++= ++++++ > tools/perf/util/parse-events.c | 23 +++++- > tools/perf/util/parse-events.h | 6 +- > tools/perf/util/parse-events.l | 23 +++++- > tools/perf/util/parse-events.y | 42 ++++++----- > 5 files changed, 224 insertions(+), 27 deletions(-) > > > Regards > Adrian