From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 229E9193 for ; Tue, 16 Jul 2024 00:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721089428; cv=none; b=KVE4lEvImaKJbCcBEGymLi6VXWPoZPi8Skp+zjsH0G6gw9kfi/lMRxb90eFaAHHIeWNZs+l2ujzsB8ZHvaojyjyNKN1pC593utro9D8PpMVdU9iLoLagb74Gubrky5mdvIYYuuAWmrrj773qIQFM+PD7h1gMMzEzL9CRQ+pKdBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721089428; c=relaxed/simple; bh=w+9uP3NYMGiGGm8C01qAIjXCvPwsduD/KyZg9fbAvdc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=b8owHbBUNM239G7weY57G4VmJ7JbnMysBZ81W6NRDIIlxH/F0LpQ7a+RwDoaqxxuvc4b4PJkZ1KqXZLcVd9yCOvi+UqU86iQ7fRA5UBRonioimzJSslxqhJoyTF/LZZyjMqQvX8jvXZDwV1cHLffMGE33IDLlbazyDGMEuBp+sI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SK7S/O+h; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SK7S/O+h" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-447df43324fso88411cf.1 for ; Mon, 15 Jul 2024 17:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721089425; x=1721694225; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=atOyFauWlMezUFieUVAk0q6tNEF19uog8150eFOHK5o=; b=SK7S/O+h0WVibjzp45o+hAVxNfaafgMdhTkGHp65ZtTX8IDjHFBFZoPnTPjsz9TSKU ucaIYXqraXLFQ1ECdr2RQmiaqXxiSmShTApi4XQFtqMls89/7v5wWXao2haOx97LBNpW iyaFuiGlxPnTn6bWN3u4TYnEO1hTbCw4PExaFpPYiWQCsXrepkdtLGXB35OYS+Ii1/OC rJSLLW9D565xy5o3Ff3j8ERdFKkTlTHQU5ZG3QYdT2THvOlxp6CGG2V8Luutz6bftRt6 gc24WNIb1MfrbcaAzlGdf1l+trPvyKuiIuIP0/3vw/hpiW+93mlfeNVxz623fMlwW9fS LhlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721089425; x=1721694225; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=atOyFauWlMezUFieUVAk0q6tNEF19uog8150eFOHK5o=; b=bt9Hfod5NKWtMqFbfZCxbYfqFvp+DBecMLSzwvhiTnwdxfVJpSqyd+1gr4F4dpvhJ8 n5i0uCmOfv8NKKre7Ux8YXrfncb39jc4CSJohJwwo8yCsUbL8fhWULKgF6PYPIZBSkmT EU1drXAjbfhgdJSEs/h/tU6u0Ip1Hv9isx3vZU7ecAUlfVTsa17V1oV9JXT6t5xy3yH3 YEpLmekehZka/4Tf68eOxApvGS2F+3RWmmcWAVAPV72neAmtmYs4P3vV+FTXO3uV0zDk KvqzuaYI4sB1FpVUB9NEHzUlRgRyub7eJu7rYWQ2SzQI+TBw2ILIpGq4aZ61mNuDyiEh kLbQ== X-Forwarded-Encrypted: i=1; AJvYcCUZeWgthglJ7uea9gGN5hdyG8LFdzqQtScYDay8IPNwJtSauP8G6yoUDzN8f/UYhQ1lBtdWidNxEYzWs2laWTpve5QDUo5cUvnE5vxy8sAU/Q== X-Gm-Message-State: AOJu0YwnEk5Zgg0Jm4YV3oEuMkTj+oRiQrFfa/0W2FXRXBacSU6wc/f6 mzLj6vCjqAbQ9l7474r7kWwSkUz167DYw9aVwotzxVmbu+oTEhRptYDMtPzQ12MEvIvbi1B/4yP CeSwyeBIyV92Naivh2aVsYXCoXH8tGpHDJeN1 X-Google-Smtp-Source: AGHT+IE/kw/J8yKZw6NIetUbx7QF0zylSsoXWZkbL5jj7VHdECRTorHmo1jZJ3C3EkNfgS8fl+Q/Qni/Y4/oltYoqD8= X-Received: by 2002:a05:622a:40cc:b0:447:e6c6:bd3 with SMTP id d75a77b69052e-44f7b93f886mr738431cf.21.1721089424804; Mon, 15 Jul 2024 17:23:44 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240525013021.436430-2-irogers@google.com> <202405311548.1e881dea-oliver.sang@intel.com> In-Reply-To: From: Ian Rogers Date: Mon, 15 Jul 2024 17:23:32 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] perf jevents: Autogenerate empty-pmu-events.c To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Weilin Wang , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Jing Zhang , John Garry , Sandipan Das Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 12, 2024 at 8:07=E2=80=AFPM Oliver Sang = wrote: > > > > but make still failed. I still saw below in our build log > > > > > > > > --- pmu-events/empty-pmu-events.c 2024-06-03 08:41:16.0000000= 00 +0000 > > > > +++ pmu-events/test-empty-pmu-events.c 2024-06-03 13:47:19.5224634= 82 +0000 > > > > @@ -136,7 +136,7 @@ > > > > { 2623 }, /* M3\000\0001 / M3\000\000\000\000\000\000\000\00000 */ > > > > { 2078 }, /* cache_miss_cycles\000group1\000dcache_miss_cpi + icac= he_miss_cycles\000\000\000\000\000\000\000\00000 */ > > > > { 1947 }, /* dcache_miss_cpi\000\000l1d\\-loads\\-misses / inst_re= tired.any\000\000\000\000\000\000\000\00000 */ > > > > -{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst= _retiredany\000\000\000\000\000\000\000\00000 */ > > > > +{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst= _retired.any\000\000\000\000\000\000\000\00000 */ Hi Oliver, I tried to reproduce the problem by installing more locales on my machine, setting the environment variables, checking my environment variables, etc. I couldn't reproduce it. Looking more closely at the diff above and the other diffs in your email something strange appears to be happening around dots. From: --- pmu-events/empty-pmu-events.c we know the minus lines are those from the files in this patch series. From: +++ pmu-events/test-empty-pmu-events.c we know the plus lines are those generated by jevents.py. In the diff output above the "inst_retired.any" doesn't match "inst_retiredany" (no dot before the word "any"). The repository file pmu-events/empty-pmu-events.c is missing the dot in the event name but jevents.py is generating it, hence the diff. But looking at pmu-events/empty-pmu-events.c in: https://lore.kernel.org/lkml/20240525013021.436430-2-irogers@google.com/ The dot is present. I think what is happening is that when you apply the patches for some reason the dots are being consumed in tools/perf/pmu-events/empty-pmu-events.c, the build then informs you of this by failing. The locales idea was a red herring and this has something to do with how you apply patches. Does this make sense? Perhaps you can try testing the patches in an ordinary client applying the patches using something like "b4 am 20240525013021.436430-1-irogers@google.com". At the moment I think the patch series is good and I don't have a way to fix what I think the problem is, with how you applied the patches. Thanks, Ian