From: Ian Rogers <irogers@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 0/4] perf annotate-data: small random fixes and updates
Date: Fri, 5 Apr 2024 17:02:20 -0700 [thread overview]
Message-ID: <CAP-5=fUhngjbL3Q7a3EuBSGdDKg8PFjRzpe5yHTDdeLmz4oWDg@mail.gmail.com> (raw)
In-Reply-To: <20240405211800.1412920-1-namhyung@kernel.org>
On Fri, Apr 5, 2024 at 2:18 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> I found some problems in the data type profiling with perf annotate.
> The patch 1 should go to perf-tools and others can go to perf-tools-next.
>
> Thanks,
> Namhyung
>
>
> Namhyung Kim (4):
> perf annotate: Make sure to call symbol__annotate2() in TUI
> perf annotate-data: Fix global variable lookup
> perf annotate-data: Do not delete non-asm lines
> perf annotate: Get rid of symbol__ensure_annotate()
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/util/annotate-data.c | 10 ++-
> tools/perf/util/annotate.c | 104 ++++++++++++++++++++----------
> 3 files changed, 80 insertions(+), 36 deletions(-)
>
>
> base-commit: b6347cb5e04e9c1d17342ab46e2ace2d448de727
> --
> 2.44.0.478.gd926399ef9-goog
>
next prev parent reply other threads:[~2024-04-06 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 21:17 [PATCH 0/4] perf annotate-data: small random fixes and updates Namhyung Kim
2024-04-05 21:17 ` [PATCH 1/4] perf annotate: Make sure to call symbol__annotate2() in TUI Namhyung Kim
2024-04-05 21:17 ` [PATCH 2/4] perf annotate-data: Fix global variable lookup Namhyung Kim
2024-04-05 21:17 ` [PATCH 3/4] perf annotate-data: Do not delete non-asm lines Namhyung Kim
2024-04-05 21:18 ` [PATCH 4/4] perf annotate: Get rid of symbol__ensure_annotate() Namhyung Kim
2024-04-06 0:02 ` Ian Rogers [this message]
2024-04-08 14:15 ` [PATCH 0/4] perf annotate-data: small random fixes and updates Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fUhngjbL3Q7a3EuBSGdDKg8PFjRzpe5yHTDdeLmz4oWDg@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).