linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	 James Clark <james.clark@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Yoshihiro Furudera <fj5100bi@fujitsu.com>,
	Howard Chu <howardchu95@gmail.com>,
	 Thomas Falcon <thomas.falcon@intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Xudong Hao <xudong.hao@intel.com>
Subject: Re: [PATCH v1 3/3] perf parse-events: Add 'X' modifier to exclude an event from being regrouped
Date: Fri, 17 Oct 2025 09:59:20 -0700	[thread overview]
Message-ID: <CAP-5=fUvppttK3t7GHsWyan08bZJRkv4-M_P2vJpe50bOuiCYA@mail.gmail.com> (raw)
In-Reply-To: <18f20d38-070c-4e17-bc90-cf7102e1e53d@linux.intel.com>

On Fri, Oct 17, 2025 at 12:25 AM Mi, Dapeng <dapeng1.mi@linux.intel.com> wrote:
> Hi Ian,
>
> It looks the "X" modifier only works for the cases without explicit group,
> like this.
>
> sudo ./perf record -e cpu/mem-stores/ppu,cpu/slots/uX -- sleep 1
> [ perf record: Woken up 2 times to write data ]
> [ perf record: Captured and wrote 0.019 MB perf.data (7 samples) ]
>
> Once there is an explicit group, the "X" modifier would not work and the
> regroup still happens, e.g.,
>
> sudo ./perf record -e '{cpu/mem-stores/ppu,cpu/slots/uX}' -- sleep 1
> WARNING: events were regrouped to match PMUs
> [ perf record: Woken up 2 times to write data ]
> [ perf record: Captured and wrote 0.019 MB perf.data (7 samples) ]
>
> I suppose we should enhance the "X" modifier and make it work in 2nd case
> as well. How's your idea?

Hi Dapeng,

hopefully fixed in:
https://lore.kernel.org/lkml/20251017165753.206608-1-irogers@google.com/

PTAL. Thanks,
Ian




> Thanks,
>
> Dapeng Mi
>
> > ference|ops|access|misses|miss)

  reply	other threads:[~2025-10-17 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 21:12 [PATCH v1 0/3] Improve event groups for topdown, add X event modifier Ian Rogers
2025-08-25 21:12 ` [PATCH v1 1/3] perf evsel: Give warning for broken Intel topdown event grouping Ian Rogers
2025-08-25 21:12 ` [PATCH v1 2/3] perf stat: Don't skip failing group events Ian Rogers
2025-08-25 21:12 ` [PATCH v1 3/3] perf parse-events: Add 'X' modifier to exclude an event from being regrouped Ian Rogers
2025-10-17  7:25   ` Mi, Dapeng
2025-10-17 16:59     ` Ian Rogers [this message]
2025-08-26  2:30 ` [PATCH v1 0/3] Improve event groups for topdown, add X event modifier Mi, Dapeng
2025-09-12 18:48   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-5=fUvppttK3t7GHsWyan08bZJRkv4-M_P2vJpe50bOuiCYA@mail.gmail.com' \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=fj5100bi@fujitsu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=howardchu95@gmail.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=xudong.hao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).