From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A57CC433EF for ; Fri, 13 May 2022 16:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380277AbiEMQep (ORCPT ); Fri, 13 May 2022 12:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357667AbiEMQen (ORCPT ); Fri, 13 May 2022 12:34:43 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C296A2646 for ; Fri, 13 May 2022 09:34:42 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id k126so5096559wme.2 for ; Fri, 13 May 2022 09:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m7MjpCbJuzCaBF33rM7i8bDmdLy/zgFnMvU0NghdjW4=; b=jaOdYnB5sK1d0IiJeXEU3+MLeEOtcluyGAgIYatubr2/3PuE2Q5rXspsbD3tFfqWtw BsVwESYmN5NGeSov+0gBFv+VrOfCMRu+HKXtk2DpfmePB/XAAL4CBbHw4SjT5a4+Ogcs Gq6y2LM818/o4UnXO2ez1x9padxBnu8RvFpZMqMxjmAauSRs6Dt01UuX1GMVrZGNICkq C0XotBSk7si9VKF+nSuO05iUKfmsAzs8WO/B2HrXnPMkwXJ0crJrh+XdUHnEKMWIZl4S Rbylbx0P26flpGN1OSoQiXUGPepf+dfljZH67dSyLToehSUcRnqE475kSpDL8DP8kpIy rBWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m7MjpCbJuzCaBF33rM7i8bDmdLy/zgFnMvU0NghdjW4=; b=fz9cBsK9K0dYydOn5Am04n0IlFUNcWqv25Vs34z+dNGz/e2r76r2oIDcG/CijKkPGd tS948Hvqfk7fY2iRCwLNsVVceJFGwty7eiCyHH8wTMusSfnS642/bfBVUeoSGySWKn3h MxH7hWfZ8R/+wAVgBYGHYu2olkDP6c7xGCTZX69j0vxd5DZ6fusQrqzasY3Z7/Lhgx68 8X9rKLdUb3iDiwjdQkiMH+OALjqhNe/m6zVXssyQAh86FQqVkqKlNTOB/b+HkzM2gNBe 7MgNXPch5adPnUQFAXzcLNh7QGVfzgV+9cl/3SOhiEqcn/GADC0Olz21z2pxVPJEnd2b dSgQ== X-Gm-Message-State: AOAM530oPikE28c4Qjsh1WQeeD5Ys22IMY1dV4n1XdBnr9iCbgObUzr3 e7tAhk3cZ/ikiwQdb6XHEhqJT/WCUqIU9QkNr5jSjg== X-Google-Smtp-Source: ABdhPJyShbTqrNF2KQLd+GgcRX1iXNoLZ+oxAq+Bs7myKRFD4NSfMvEmbWYewPWIlFZBpzn4/F8ZvZemUKqCWKjz0aY= X-Received: by 2002:a05:600c:2315:b0:394:1f6:f663 with SMTP id 21-20020a05600c231500b0039401f6f663mr15604314wmo.115.1652459681108; Fri, 13 May 2022 09:34:41 -0700 (PDT) MIME-Version: 1.0 References: <20220513040519.1499333-1-irogers@google.com> <20220513040519.1499333-2-irogers@google.com> <6341384c-b3e6-fbe5-f29f-e0db114bd439@huawei.com> In-Reply-To: From: Ian Rogers Date: Fri, 13 May 2022 09:34:27 -0700 Message-ID: Subject: Re: [PATCH 1/7] perf test: Skip reason for suites with 1 test To: John Garry Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Riccardo Mancini , Sohaib Mohamed , Carsten Haitzler , Marco Elver , Michael Petlan , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, May 13, 2022 at 9:26 AM John Garry wrote: > > On 13/05/2022 16:42, Ian Rogers wrote: > >> I was not sure which suite has a single tastcase, so I experimented for > >> libpfm4 by deleting a testcase so it has only 1x remaining, I get: > >> > >> before your change: > >> john@localhost:~/acme/tools/perf> sudo ./perf test 63 > >> 63: Test libpfm4 support : Skip > >> > >> after: > >> > >> john@localhost:~/acme/tools/perf> sudo ./perf test 63 > >> 63: Test libpfm4 support : Skip (not compiled in) > >> > >> Although it is odd to have a single sub-test, is there a reason for > >> which we don't print its name? We print the name when there are multiple > >> sub-tests. > > The reason was to replicate the existing "perf test" behavior before > > the kunit style transition. The main place we get tests with a single > > sub-test is from the DEFINE_SUITE macro: > > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/tests.h?h=perf/core#n67 > > I agree it looks kind of weird and was inheriting the data structures > > from kunit and the format of the output from perf test. > > Out of curiosity, which suite is this that you find only has a single > subtest? Does it possibly only have a single subtest as some others may > be compiled out? I was getting it when I added a skip message to the openat syscall tests in patch 3: https://lore.kernel.org/lkml/20220513040519.1499333-4-irogers@google.com/ I didn't see any changes with any existing tests. Thanks, Ian > Thanks, > John