From: Ian Rogers <irogers@google.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
Riccardo Mancini <rickyman7@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Dave Marchevsky <davemarchevsky@fb.com>,
Song Liu <songliubraving@fb.com>, Leo Yan <leo.yan@linaro.org>,
John Garry <john.garry@huawei.com>,
Florian Fischer <florian.fischer@muhq.space>,
Kan Liang <kan.liang@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Zechuan Chen <chenzechuan1@huawei.com>,
Yang Jihong <yangjihong1@huawei.com>,
German Gomez <german.gomez@arm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
James Clark <james.clark@arm.com>,
Denis Nikitin <denik@chromium.org>,
Lexi Shao <shaolexi@huawei.com>,
Michael Petlan <mpetlan@redhat.com>,
Remi Bernon <rbernon@codeweavers.com>,
Fangrui Song <maskray@google.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf io: Make open and read calls more robust
Date: Wed, 15 Jun 2022 12:17:15 -0700 [thread overview]
Message-ID: <CAP-5=fVAUGMENJhD9d7VA9TbO1JOLJhisDPymJZgW0zr7WDXNA@mail.gmail.com> (raw)
In-Reply-To: <11db049c-c288-71c2-de37-545fd695d486@linux.intel.com>
On Wed, Jun 15, 2022 at 11:47 AM Andi Kleen <ak@linux.intel.com> wrote:
>
>
> On 6/14/2022 11:03 PM, Ian Rogers wrote:
> > Wrap open and read calls with TEMP_FAILURE_RETRY in case a signal
> > causes the syscall to need to restart.
>
>
> Why not just use SA_RESTART on the signals?
As explained to Adrian, existing code is EINTR tolerant, some of the
code is in libraries and for portability shouldn't assume SA_RESTART.
Thanks,
Ian
>
> -Andi
>
prev parent reply other threads:[~2022-06-15 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 6:03 [PATCH] perf io: Make open and read calls more robust Ian Rogers
2022-06-15 6:50 ` Adrian Hunter
2022-06-15 15:34 ` Ian Rogers
2022-06-15 16:40 ` Adrian Hunter
2022-06-15 17:38 ` Ian Rogers
2022-06-15 18:33 ` Andi Kleen
2022-06-15 19:17 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fVAUGMENJhD9d7VA9TbO1JOLJhisDPymJZgW0zr7WDXNA@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=chenzechuan1@huawei.com \
--cc=davemarchevsky@fb.com \
--cc=denik@chromium.org \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rbernon@codeweavers.com \
--cc=rickyman7@gmail.com \
--cc=shaolexi@huawei.com \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).