From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E83C4C433EF for ; Wed, 15 Jun 2022 03:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345988AbiFODNy (ORCPT ); Tue, 14 Jun 2022 23:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351605AbiFODNw (ORCPT ); Tue, 14 Jun 2022 23:13:52 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 963A04D6A0 for ; Tue, 14 Jun 2022 20:13:50 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id n185so5594443wmn.4 for ; Tue, 14 Jun 2022 20:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yzv5eaByYVX50lBqPhTHyIiI1jj84Kw6BozZseArlPM=; b=IIWBoco614YCy/2/A9fNn0flfIzyV0vqrFQEateuhiigUnx6irUW0zgzvfcILyEN01 TZABkUIKmyKLvnNn3RPwkpw4MEV2x81hVQ53g6qOwcVImPorfrQ29VVqbmRufGt4IPEy qLFRdRB60fbIU61X6LJwgmS7pri7yQQBxhZ2bIftmEpKUgycG66mLyTcIDk94Jz33Vhv R6dJSnm/bJsr5mBEe2/oNqYv2GhoaY4nOyfjEyyoLVPyKW0OXKr/lGsibl3XlCIdNSDu bEAqQaRCW3mi2HTtnI1jl1tKV865cvoAk4BKFHbjOx3AU8pJ/sphrM3vqaGNRIFeK1Po CJHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yzv5eaByYVX50lBqPhTHyIiI1jj84Kw6BozZseArlPM=; b=aFpqhP4l84GjS6LY2Yh31F3dEgYN0kzPu2D87Fp9pRIipDAoP5Zq9y7C2zNkwx6m9C iNGnBt7RUBYOkCgc2iPPaB1dTsmPtKjSh7DkRYdbrND724p//UzaqSSYoanxD5TNQmNf VWrYtAsi/jHv5H5qjPvRuN6+OOYSfmu4Ziu/Ka+rnF1WBlTvIKu6UEKPYoOScq6d9Ngo 4+dnp/IqpCoqvqwgXuUz09oJUkLg5J6l8m7PSIUsdOTr8M6USr2tzEfc44jWdoUW+2IE CNtcjl7g4jrCu/qjv+A2YNrytr+x2JKafmk+BASEMukHDDORQHe4Wipo0ZB1vTUgYhGt v+xQ== X-Gm-Message-State: AOAM530Dudz8bU98fro13nu1rbafSQJnw5+FGv1Fe2FeYjrCoAishn8B epzWmSB7CcMbd4qGTVRyP2bwL7wm0yLH/jF2afl/oA== X-Google-Smtp-Source: ABdhPJyc+ioiwIvkUk170KWMBDq2nVqmUPY6DdWy8K66yWGIowx8HzKwMmlFrJy62UL41mTc2zY97koi2C0sOYql2WQ= X-Received: by 2002:a05:600c:29d3:b0:397:4730:ee75 with SMTP id s19-20020a05600c29d300b003974730ee75mr7465039wmd.149.1655262828974; Tue, 14 Jun 2022 20:13:48 -0700 (PDT) MIME-Version: 1.0 References: <20220527185426.240235-1-irogers@google.com> <350b905c-1ac1-3577-6b56-c13f2aeab712@huawei.com> In-Reply-To: <350b905c-1ac1-3577-6b56-c13f2aeab712@huawei.com> From: Ian Rogers Date: Tue, 14 Jun 2022 20:13:36 -0700 Message-ID: Subject: Re: [PATCH v3 0/3] Rewrite jevents program in python To: John Garry Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Andi Kleen , Zhengjun Xing , Felix Fietkau , Qi Liu , Like Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Nick Forrington , Kajol Jain , James Clark , Andrew Kilroy , "Paul A . Clarke" , Will Deacon , Mathieu Poirier , ananth.narayan@amd.com, ravi.bangoria@amd.com, santosh.shukla@amd.com, sandipan.das@amd.com, Caleb Biggers , Perry Taylor , Kshipra Bopardikar , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Tue, Jun 14, 2022 at 9:10 AM John Garry wrote: > > On 14/06/2022 17:03, Ian Rogers wrote: > >> diff -u tools/perf/trace/beauty/include/linux/socket.h > >> include/linux/socket.h > >> Makefile.config:259: *** which python-config not found. Stop. > >> Makefile.perf:239: recipe for target 'sub-make' failed > >> make[1]: *** [sub-make] Error 2 > >> Makefile:69: recipe for target 'all' failed > >> make: *** [all] Error 2 > >> john@debian:~/linux/tools/perf$ > >> > >> JFYI, this is my alternatives: > >> > >> sudo update-alternatives --config python > >> There are 3 choices for the alternative python (providing > >> /usr/bin/python). > >> > >> Selection Path Priority Status > >> ------------------------------------------------------------ > >> 0 /usr/local/bin/python3.6 50 auto mode > >> 1 /usr/bin/python2.7 1 manual mode > >> 2 /usr/bin/python3.5 2 manual mode > >> * 3 /usr/local/bin/python3.6 50 manual mode > >> > >> Press to keep the current choice[*], or type selection number: > > Thanks Gary, > > > > Perhaps it relates to dev packages. Perhaps, apt-get install > > python-dev-is-python3 which should resolve the symlinks. I wonder that > > you have python dev for python2 but python3 installed without the dev. > > We should be able to make a Makefile test for this. > > So I was trying another system here as a sanity test (as my main dev box > is not working either). And this other system is debian and only > supports python up to 3.5, so that is why I have > /usr/local/bin/python3.6 as an alt, i.e. I downloaded and built myself. > > Anyway, I do have python3-dev: > > john@debian:~/linux/tools/perf$ sudo apt-get install python3-dev > Reading package lists... Done > Building dependency tree > Reading state information... Done > python3-dev is already the newest version (3.5.3-1). > It turned out to be something simple. The build is set up to prefer python2 over python3, so if you have both you get python2. I've fixed this now in v4 (PTAL): https://lore.kernel.org/lkml/20220615030438.51477-1-irogers@google.com/ I think we should remove python2 build support as it is confusing and python2 doesn't support setuptools meaning this patch fails: https://lore.kernel.org/lkml/20220615014206.26651-1-irogers@google.com/ and without that patch python3 generates deprecated module warnings. Thanks, Ian