* [PATCH v1] perf test: Add basic callgraph test to record testing
@ 2025-06-19 0:24 Ian Rogers
2025-06-19 8:24 ` James Clark
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2025-06-19 0:24 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Thomas Richter,
Dapeng Mi, Chun-Tse Shao, linux-perf-users, linux-kernel
Give some basic perf record callgraph coverage.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 2022a4f739be..603fa6b79b5d 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
. "${shelldir}"/lib/perf_has_symbol.sh
testsym="test_loop"
+testsym2="brstack"
skip_test_missing_symbol ${testsym}
+skip_test_missing_symbol ${testsym2}
err=0
perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
@@ -359,6 +361,23 @@ test_precise_max() {
fi
}
+test_callgraph() {
+ echo "Callgraph test"
+ if ! perf record -o "${perfdata}" -g perf test -w brstack
+ then
+ echo "Callgraph test [Failed missing output]"
+ err=1
+ return
+ fi
+ if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
+ then
+ echo "Callgraph test [Failed missing symbol]"
+ err=1
+ return
+ fi
+ echo "Callgraph test [Success]"
+}
+
# raise the limit of file descriptors to minimum
if [[ $default_fd_limit -lt $min_fd_limit ]]; then
ulimit -Sn $min_fd_limit
@@ -374,6 +393,7 @@ test_uid
test_leader_sampling
test_topdown_leader_sampling
test_precise_max
+test_callgraph
# restore the default value
ulimit -Sn $default_fd_limit
--
2.50.0.rc2.701.gf1e915cc24-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] perf test: Add basic callgraph test to record testing
2025-06-19 0:24 Ian Rogers
@ 2025-06-19 8:24 ` James Clark
2025-06-20 20:00 ` Namhyung Kim
0 siblings, 1 reply; 5+ messages in thread
From: James Clark @ 2025-06-19 8:24 UTC (permalink / raw)
To: Ian Rogers, Thomas Richter
Cc: Dapeng Mi, Chun-Tse Shao, linux-perf-users, linux-kernel,
Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Adrian Hunter, Kan Liang
On 19/06/2025 1:24 am, Ian Rogers wrote:
> Give some basic perf record callgraph coverage.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 2022a4f739be..603fa6b79b5d 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
> . "${shelldir}"/lib/perf_has_symbol.sh
>
> testsym="test_loop"
> +testsym2="brstack"
>
> skip_test_missing_symbol ${testsym}
> +skip_test_missing_symbol ${testsym2}
>
> err=0
> perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> @@ -359,6 +361,23 @@ test_precise_max() {
> fi
> }
>
> +test_callgraph() {
> + echo "Callgraph test"
> + if ! perf record -o "${perfdata}" -g perf test -w brstack
Looking at 2dac1f089 ("perf test: Fix 'perf script' tests on s390"), it
looks like this won't work there. Although I'm not sure why the fix
wasn't to change the default -g mode to dwarf on s390 if fp doesn't work
at all. That wouldn't fix -e cpu-clock being required though.
Thanks
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] perf test: Add basic callgraph test to record testing
2025-06-19 8:24 ` James Clark
@ 2025-06-20 20:00 ` Namhyung Kim
0 siblings, 0 replies; 5+ messages in thread
From: Namhyung Kim @ 2025-06-20 20:00 UTC (permalink / raw)
To: James Clark
Cc: Ian Rogers, Thomas Richter, Dapeng Mi, Chun-Tse Shao,
linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Adrian Hunter, Kan Liang
On Thu, Jun 19, 2025 at 09:24:04AM +0100, James Clark wrote:
>
>
> On 19/06/2025 1:24 am, Ian Rogers wrote:
> > Give some basic perf record callgraph coverage.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/tests/shell/record.sh | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index 2022a4f739be..603fa6b79b5d 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
> > . "${shelldir}"/lib/perf_has_symbol.sh
> > testsym="test_loop"
> > +testsym2="brstack"
> > skip_test_missing_symbol ${testsym}
> > +skip_test_missing_symbol ${testsym2}
> > err=0
> > perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> > @@ -359,6 +361,23 @@ test_precise_max() {
> > fi
> > }
> > +test_callgraph() {
> > + echo "Callgraph test"
> > + if ! perf record -o "${perfdata}" -g perf test -w brstack
>
> Looking at 2dac1f089 ("perf test: Fix 'perf script' tests on s390"), it
> looks like this won't work there. Although I'm not sure why the fix wasn't
> to change the default -g mode to dwarf on s390 if fp doesn't work at all.
> That wouldn't fix -e cpu-clock being required though.
Maybe we can add a new 'perf check callchain' subcommand to check the
relevant information and display and/or verify them properly.
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1] perf test: Add basic callgraph test to record testing
@ 2025-06-28 1:35 Ian Rogers
2025-06-28 1:54 ` Ian Rogers
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2025-06-28 1:35 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Dapeng Mi,
Thomas Richter, Chun-Tse Shao, linux-perf-users, linux-kernel
Give some basic perf record callgraph coverage.
Signed-off-by: Ian Rogers <irogers@google.com>
---
v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
Clark <james.clark@linaro.org>.
---
tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 2022a4f739be..b1ad24fb3b33 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
. "${shelldir}"/lib/perf_has_symbol.sh
testsym="test_loop"
+testsym2="brstack"
skip_test_missing_symbol ${testsym}
+skip_test_missing_symbol ${testsym2}
err=0
perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
@@ -359,6 +361,33 @@ test_precise_max() {
fi
}
+test_callgraph() {
+ echo "Callgraph test"
+
+ case $(uname -m)
+ in s390x)
+ cmd_flags="--call-graph dwarf -e cpu-clock";;
+ *)
+ cmd_flags="-g";;
+ esac
+
+ if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
+ then
+ echo "Callgraph test [Failed missing output]"
+ err=1
+ return
+ fi
+
+ if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
+ then
+ echo "Callgraph test [Failed missing symbol]"
+ err=1
+ return
+ fi
+
+ echo "Callgraph test [Success]"
+}
+
# raise the limit of file descriptors to minimum
if [[ $default_fd_limit -lt $min_fd_limit ]]; then
ulimit -Sn $min_fd_limit
@@ -374,6 +403,7 @@ test_uid
test_leader_sampling
test_topdown_leader_sampling
test_precise_max
+test_callgraph
# restore the default value
ulimit -Sn $default_fd_limit
--
2.50.0.727.gbf7dc18ff4-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] perf test: Add basic callgraph test to record testing
2025-06-28 1:35 [PATCH v1] perf test: Add basic callgraph test to record testing Ian Rogers
@ 2025-06-28 1:54 ` Ian Rogers
0 siblings, 0 replies; 5+ messages in thread
From: Ian Rogers @ 2025-06-28 1:54 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Dapeng Mi,
Thomas Richter, Chun-Tse Shao, linux-perf-users, linux-kernel
On Fri, Jun 27, 2025 at 6:35 PM Ian Rogers <irogers@google.com> wrote:
>
> Give some basic perf record callgraph coverage.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
> Clark <james.clark@linaro.org>.
Sorry the version is wrong in the subject, I'll resend.
Ian
> ---
> tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 2022a4f739be..b1ad24fb3b33 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
> . "${shelldir}"/lib/perf_has_symbol.sh
>
> testsym="test_loop"
> +testsym2="brstack"
>
> skip_test_missing_symbol ${testsym}
> +skip_test_missing_symbol ${testsym2}
>
> err=0
> perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> @@ -359,6 +361,33 @@ test_precise_max() {
> fi
> }
>
> +test_callgraph() {
> + echo "Callgraph test"
> +
> + case $(uname -m)
> + in s390x)
> + cmd_flags="--call-graph dwarf -e cpu-clock";;
> + *)
> + cmd_flags="-g";;
> + esac
> +
> + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
> + then
> + echo "Callgraph test [Failed missing output]"
> + err=1
> + return
> + fi
> +
> + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
> + then
> + echo "Callgraph test [Failed missing symbol]"
> + err=1
> + return
> + fi
> +
> + echo "Callgraph test [Success]"
> +}
> +
> # raise the limit of file descriptors to minimum
> if [[ $default_fd_limit -lt $min_fd_limit ]]; then
> ulimit -Sn $min_fd_limit
> @@ -374,6 +403,7 @@ test_uid
> test_leader_sampling
> test_topdown_leader_sampling
> test_precise_max
> +test_callgraph
>
> # restore the default value
> ulimit -Sn $default_fd_limit
> --
> 2.50.0.727.gbf7dc18ff4-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-28 1:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-28 1:35 [PATCH v1] perf test: Add basic callgraph test to record testing Ian Rogers
2025-06-28 1:54 ` Ian Rogers
-- strict thread matches above, loose matches on Subject: below --
2025-06-19 0:24 Ian Rogers
2025-06-19 8:24 ` James Clark
2025-06-20 20:00 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).