From: Ian Rogers <irogers@google.com>
To: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
Zhuo Song <zhuo.song@linux.alibaba.com>,
Shuai Xue <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v7 5/8] perf test: Make matching_pmu effective
Date: Thu, 24 Aug 2023 21:27:19 -0700 [thread overview]
Message-ID: <CAP-5=fVfc1RQO_OnSFAU4rtKfSTiWpS5PghovFjuPxruty19LQ@mail.gmail.com> (raw)
In-Reply-To: <1692606977-92009-6-git-send-email-renyu.zj@linux.alibaba.com>
On Mon, Aug 21, 2023 at 1:36 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote:
>
> The perf_pmu_test_event.matching_pmu didn't work. No matter what its
> value is, it does not affect the test results. So let matching_pmu be
> used for matching perf_pmu_test_pmu.pmu.name.
Could you rebase this onto the latest perf-tools-next, I'd like to test this.
Thanks,
Ian
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> ---
> tools/perf/tests/pmu-events.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c
> index 1dff863b..3204252 100644
> --- a/tools/perf/tests/pmu-events.c
> +++ b/tools/perf/tests/pmu-events.c
> @@ -238,7 +238,7 @@ struct perf_pmu_test_pmu {
> },
> .alias_str = "event=0x2b",
> .alias_long_desc = "ddr write-cycles event. Unit: uncore_sys_ddr_pmu ",
> - .matching_pmu = "uncore_sys_ddr_pmu",
> + .matching_pmu = "uncore_sys_ddr_pmu0",
> };
>
> static const struct perf_pmu_test_event sys_ccn_pmu_read_cycles = {
> @@ -252,7 +252,7 @@ struct perf_pmu_test_pmu {
> },
> .alias_str = "config=0x2c",
> .alias_long_desc = "ccn read-cycles event. Unit: uncore_sys_ccn_pmu ",
> - .matching_pmu = "uncore_sys_ccn_pmu",
> + .matching_pmu = "uncore_sys_ccn_pmu4",
> };
>
> static const struct perf_pmu_test_event *sys_events[] = {
> @@ -599,6 +599,11 @@ static int __test_uncore_pmu_event_aliases(struct perf_pmu_test_pmu *test_pmu)
> struct pmu_event const *event = &test_event->event;
>
> if (!strcmp(event->name, alias->name)) {
> + if (strcmp(pmu_name, test_event->matching_pmu)) {
> + pr_debug("testing aliases uncore PMU %s: mismatched matching_pmu, %s vs %s\n",
> + pmu_name, test_event->matching_pmu, pmu_name);
> + continue;
> + }
> if (compare_alias_to_test_event(alias,
> test_event,
> pmu_name)) {
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2023-08-25 4:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 8:36 [PATCH v7 0/8] perf vendor events: Add JSON metrics for Arm CMN Jing Zhang
2023-08-21 8:36 ` [PATCH v7 1/8] perf pmu: "Compat" supports matching multiple identifiers Jing Zhang
2023-08-24 15:05 ` Robin Murphy
2023-08-25 8:40 ` Jing Zhang
2023-08-25 4:11 ` Ian Rogers
2023-08-25 6:12 ` Jing Zhang
2023-08-21 8:36 ` [PATCH v7 2/8] perf metric: " Jing Zhang
2023-08-25 4:16 ` Ian Rogers
2023-08-21 8:36 ` [PATCH v7 4/8] perf jevents: Support more event fields Jing Zhang
2023-08-23 9:12 ` Robin Murphy
2023-08-25 4:42 ` Ian Rogers
2023-08-21 8:36 ` [PATCH v7 5/8] perf test: Make matching_pmu effective Jing Zhang
2023-08-25 4:27 ` Ian Rogers [this message]
2023-08-25 6:30 ` Jing Zhang
2023-08-21 8:36 ` [PATCH v7 6/8] perf test: Add pmu-event test for "Compat" and new event_field Jing Zhang
2023-08-25 4:30 ` Ian Rogers
2023-08-25 6:30 ` Jing Zhang
2023-08-21 8:36 ` [PATCH v7 7/8] perf jevents: Add support for Arm CMN PMU aliasing Jing Zhang
2023-08-23 9:33 ` Robin Murphy
2023-08-24 2:12 ` Jing Zhang
2023-08-21 8:36 ` [PATCH v7 8/8] perf vendor events: Add JSON metrics for Arm CMN Jing Zhang
2023-08-25 4:13 ` Ian Rogers
2023-08-25 6:47 ` Jing Zhang
2023-08-23 8:12 ` [PATCH v7 0/8] " John Garry
2023-08-24 2:33 ` Jing Zhang
2023-09-06 16:05 ` Arnaldo Carvalho de Melo
2023-09-07 2:42 ` Jing Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fVfc1RQO_OnSFAU4rtKfSTiWpS5PghovFjuPxruty19LQ@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).