From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C053BC001DE for ; Fri, 28 Jul 2023 15:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236359AbjG1PrM (ORCPT ); Fri, 28 Jul 2023 11:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjG1PrL (ORCPT ); Fri, 28 Jul 2023 11:47:11 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 011C6E0 for ; Fri, 28 Jul 2023 08:47:10 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-40550136e54so348371cf.0 for ; Fri, 28 Jul 2023 08:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690559230; x=1691164030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c5kOzcNksCR4x2pHItXcAlkQd0Sq49clDfLGooTZWTQ=; b=FGXxPL1ytN3CB6f6k2GL8CUzTgC/qgshBaaNPmbKooV3WMiXzgpi0hkilO8oCK1nhd ZQf1RWXL+HwIWRomC8cytIT6Xp4UODREmAWLDxy1Y0PcCFoGmk09V6HWeZfra1lltxXT mu4hlkIvgoHq5j/sAo4vvngu63goXbxEYMmZy2vkbfMYIk3a7OE53xpPRO9THerSRrYE dRQGR8/t7lTkt+dsuoaJChqXtAZ6CEX2dKZuYJQIts7olNcc3XG3q3al/GZjrnCrrG2N wPFK9BPkNRVH6pPyjEq81s07JCVsfrjVZpq+B71sPugkT8zoFlYomt7WGiFUVlJzktVd /lsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690559230; x=1691164030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c5kOzcNksCR4x2pHItXcAlkQd0Sq49clDfLGooTZWTQ=; b=Lh4/OoHlK0lDp/gsHu0CxU7CTF0h0Esj++yJuV9tWQ8JnOLyzEEazJrXRQ3gCEX1Jp 19ZLaEGF7RiAMP056MWLDK/8dpV4hKJXu+ZnOzgmewDBiB0DYp6BpSlpvYdqfqmBB3Xj SA6tSxQ/hI0FnYaq0EVEPBhLt3CQrX4xItDgRKTHDMbjwR24v5he/v7W5QHrIFa+MtLL 4szRofM/HRRXdH4gVNsEsnonsuBeWsVP9EcTabw5jO1+vsbHySX2vNUFt1mvYIEOS/HL CDPBERgD9x/zVEfZYmZO0xi1P6Fx4owbBtA5/QE3fnTsU3VFKH1uNAY+Zrg2Q5kOewJj SBMg== X-Gm-Message-State: ABy/qLbA7sJykMTvNje7azzgSnJbvXE9RyrA8LyRqEuC43fgfKb3bkKI ofCOfqbBzFuxtdixrgbsNnjpJ3wFjhZiRYsWCn4BRQ== X-Google-Smtp-Source: APBJJlEvfgnC/azHL/CZCqlcM439djFU3LDgROiAsgo3y2VeCSzSpfZB9+O5UMLQ1w3mvtFJNlKo5TcAN8tB8JLGKAw= X-Received: by 2002:a05:622a:1486:b0:3f0:af20:1a37 with SMTP id t6-20020a05622a148600b003f0af201a37mr267553qtx.15.1690559230067; Fri, 28 Jul 2023 08:47:10 -0700 (PDT) MIME-Version: 1.0 References: <20230728151812.454806-2-georgmueller@gmx.net> In-Reply-To: <20230728151812.454806-2-georgmueller@gmx.net> From: Ian Rogers Date: Fri, 28 Jul 2023 08:46:58 -0700 Message-ID: Subject: Re: [PATCH] perf probe: skip test_uprobe_from_different_cu if there is no gcc To: =?UTF-8?Q?Georg_M=C3=BCller?= Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , "Masami Hiramatsu (Google)" , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, Jul 28, 2023 at 8:19=E2=80=AFAM Georg M=C3=BCller wrote: > > Without gcc, the test will fail. > > On cleanup, ignore probe removal errors. Otherwise, in case of an error > adding the probe, the temporary directory is not removed. > > Fixes: 56cbeacf1435 ("perf probe: Add test for regression introduced by s= witch to die_get_decl_file()") > Signed-off-by: Georg M=C3=BCller > Link: https://lore.kernel.org/r/CAP-5=3DfUP6UuLgRty3t2=3DfQsQi3k4hDMz415v= Wdp1x88QMvZ8ug@mail.gmail.com/ Acked-by: Ian Rogers Thanks! Ian > --- > tools/perf/tests/shell/test_uprobe_from_different_cu.sh | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/shell/test_uprobe_from_different_cu.sh b/to= ols/perf/tests/shell/test_uprobe_from_different_cu.sh > index 00d2e0e2e0c2..319f36ebb9a4 100755 > --- a/tools/perf/tests/shell/test_uprobe_from_different_cu.sh > +++ b/tools/perf/tests/shell/test_uprobe_from_different_cu.sh > @@ -4,6 +4,12 @@ > > set -e > > +# skip if there's no gcc > +if ! [ -x "$(command -v gcc)" ]; then > + echo "failed: no gcc compiler" > + exit 2 > +fi > + > temp_dir=3D$(mktemp -d /tmp/perf-uprobe-different-cu-sh.XXXXXXXXXX) > > cleanup() > @@ -11,7 +17,7 @@ cleanup() > trap - EXIT TERM INT > if [[ "${temp_dir}" =3D~ ^/tmp/perf-uprobe-different-cu-sh.*$ ]];= then > echo "--- Cleaning up ---" > - perf probe -x ${temp_dir}/testfile -d foo > + perf probe -x ${temp_dir}/testfile -d foo || true > rm -f "${temp_dir}/"* > rmdir "${temp_dir}" > fi > -- > 2.41.0 >