From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Andi Kleen <ak@linux.intel.com>,
James Clark <james.clark@arm.com>,
Sandipan Das <sandipan.das@amd.com>,
German Gomez <german.gomez@arm.com>, Leo Yan <leo.yan@linaro.org>,
Timothy Hayes <timothy.hayes@arm.com>,
Kan Liang <kan.liang@linux.intel.com>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>,
Kim Phillips <kim.phillips@amd.com>,
Riccardo Mancini <rickyman7@gmail.com>,
Sean Christopherson <seanjc@google.com>,
shaomin Deng <dengshaomin@cdjrlc.com>,
Eelco Chaudron <echaudro@redhat.com>,
Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
bpf@vger.kernel.org, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v1 0/5] build/libtraceevent resends
Date: Wed, 14 Dec 2022 10:10:31 -0800 [thread overview]
Message-ID: <CAP-5=fW8n-8ayzjLj0q588d0ZVpTPOGNGLB0Oj2GkF7f7CA=cg@mail.gmail.com> (raw)
In-Reply-To: <Y5oPQ0Cf/9JGME3n@kernel.org>
On Wed, Dec 14, 2022 at 10:00 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Wed, Dec 14, 2022 at 11:22:45AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Dec 13, 2022 at 03:26:46PM -0800, Ian Rogers escreveu:
> > > All patches on the acme perf/core branch.
> > >
> > > Resend incremental build fix python plugin:
> > > https://lore.kernel.org/lkml/20221205225940.3079667-4-irogers@google.com/
> > >
> > > Break apart and resend libtraceevent debug logging support:
> > > https://lore.kernel.org/linux-perf-users/20210923001024.550263-4-irogers@google.com/
> > >
> > > Switch "#if HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE" to "#if
> > > MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) <= LIBTRACEEVENT_VERSION",
> > > ensuring trace-event.h is included as discussed on the mailing list.
> > >
> > > Resend removal of --group option:
> > > https://lore.kernel.org/lkml/20220707195610.303254-1-irogers@google.com/
> >
> > Thanks, applied.
>
> Building on arm64:
>
> /home/acme/git/perf/tools/perf/util/evsel.c: In function ‘evsel__rawptr’:
> /home/acme/git/perf/tools/perf/util/evsel.c:2787:65: error: operator '<=' has no right operand
> 2787 | #if MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) <= LIBTRACEEVENT_VERSION
> | ^
> error: command '/usr/bin/gcc' failed with exit code 1
> cp: cannot stat '/tmp/build/perf/python_ext_build/lib/perf*.so': No such file or directory
>
> make[2]: *** [Makefile.perf:651: /tmp/build/perf/python/perf.cpython-310-aarch64-linux-gnu.so] Error 1
> make[2]: *** Waiting for unfinished jobs....
> LD /tmp/build/perf/libbpf/staticobjs/libbpf-in.o
>
> Trying to fix...
Thanks, I suspect the CFLAGS aren't passed through maybe, given this
is the python code. Perhaps an include of util/trace-event.h is also
necessary, but I thought that was already present:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/util/evsel.c?h=perf/core#n43
Thanks for digging into it,
Ian
> > - Arnaldo
> >
> >
> > > Ian Rogers (5):
> > > perf build: Fix python/perf.so library's name
> > > perf trace-event: Add libtraceevent version tools to header
> > > libtraceevent: Increase libtraceevent logging when verbose
> > > perf trace-event: Use version check to avoid 1 define
> > > perf evlist: Remove group option.
> > >
> > > tools/perf/Documentation/perf-record.txt | 4 ----
> > > tools/perf/Documentation/perf-top.txt | 7 ++----
> > > tools/perf/Makefile.config | 8 +++----
> > > tools/perf/Makefile.perf | 2 +-
> > > tools/perf/builtin-record.c | 2 --
> > > tools/perf/builtin-stat.c | 6 -----
> > > tools/perf/builtin-top.c | 2 --
> > > tools/perf/builtin-trace.c | 2 +-
> > > tools/perf/tests/attr/README | 2 --
> > > tools/perf/tests/attr/test-record-group | 22 -------------------
> > > tools/perf/tests/attr/test-stat-group | 17 --------------
> > > tools/perf/util/data-convert-bt.c | 3 ++-
> > > tools/perf/util/debug.c | 10 +++++++++
> > > tools/perf/util/evlist.c | 2 +-
> > > tools/perf/util/evlist.h | 2 --
> > > tools/perf/util/evsel.c | 2 +-
> > > tools/perf/util/python.c | 10 +--------
> > > tools/perf/util/record.c | 7 ------
> > > tools/perf/util/record.h | 1 -
> > > .../util/scripting-engines/trace-event-perl.c | 2 +-
> > > .../scripting-engines/trace-event-python.c | 2 +-
> > > tools/perf/util/sort.c | 3 ++-
> > > tools/perf/util/trace-event.h | 13 +++++++++++
> > > 23 files changed, 39 insertions(+), 92 deletions(-)
> > > delete mode 100644 tools/perf/tests/attr/test-record-group
> > > delete mode 100644 tools/perf/tests/attr/test-stat-group
> > >
> > > --
> > > 2.39.0.314.g84b9a713c41-goog
> >
> > --
> >
> > - Arnaldo
>
> --
>
> - Arnaldo
prev parent reply other threads:[~2022-12-14 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 23:26 [PATCH v1 0/5] build/libtraceevent resends Ian Rogers
2022-12-13 23:26 ` [PATCH v1 1/5] perf build: Fix python/perf.so library's name Ian Rogers
2022-12-13 23:26 ` [PATCH v1 2/5] perf trace-event: Add libtraceevent version tools to header Ian Rogers
2022-12-13 23:26 ` [PATCH v1 3/5] libtraceevent: Increase libtraceevent logging when verbose Ian Rogers
2022-12-13 23:26 ` [PATCH v1 4/5] perf trace-event: Use version check to avoid 1 define Ian Rogers
2022-12-13 23:26 ` [PATCH v1 5/5] perf evlist: Remove group option Ian Rogers
2022-12-14 14:22 ` [PATCH v1 0/5] build/libtraceevent resends Arnaldo Carvalho de Melo
2022-12-14 18:00 ` Arnaldo Carvalho de Melo
2022-12-14 18:10 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fW8n-8ayzjLj0q588d0ZVpTPOGNGLB0Oj2GkF7f7CA=cg@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=dengshaomin@cdjrlc.com \
--cc=echaudro@redhat.com \
--cc=eranian@google.com \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=timothy.hayes@arm.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).