From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98DD2C7EE21 for ; Thu, 4 May 2023 16:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbjEDQ2j (ORCPT ); Thu, 4 May 2023 12:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbjEDQ2i (ORCPT ); Thu, 4 May 2023 12:28:38 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 003CD19A2 for ; Thu, 4 May 2023 09:28:33 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-32f4e0f42a7so549585ab.1 for ; Thu, 04 May 2023 09:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683217713; x=1685809713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9+VP3uaKzWcb6ZT765WK3PqiJOkmOv7Wd1FEYE1adxQ=; b=pyuv8v4iubf2f73ykjeTCk5GaXz2MiECBM6bup/C/NXaN9cAwKrDTIg7k/LAuBmQLB viNHdlA9JcmoT4hk0lT8HKNYcq6Kv94b7o8tdV5yScO6WruRYLvdG57tzkS+EDgaesXm 9UuVBX42y8ordCZMJNau3MX1kBUvyIqoSlQtMXvnOf9v3QIhfjPevMklmTfHRhZWD/Ud raId0TItu2gSAfJ9/4uGL/xAcWhkwexGPLgOm9euCgrHwrUvIR0alBnFN/OAhod0fjEa 6GmueNk/itVNuYlGjGJUiq1VHZKxNJM2/8tV3mTkS6BP0a3pYkVl+PmMvNg1hMfdV/cG 6nkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683217713; x=1685809713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9+VP3uaKzWcb6ZT765WK3PqiJOkmOv7Wd1FEYE1adxQ=; b=GgNfuTXPPRzcuqi3dusnnpkPSpo/mnXmNw68LbscgMXKdS0zBUTvVbxoW/brmqw3qn h6v7GRl38/hSrA8yPuCktzNGU2nF/6oYaI7GHqXIcxBvtfn7g5rpOK673ROYfPvx8zxU XH0Eub2ovtf6/GHmPZgJ3vqVwvtajfSkfmgvJ5eVHsBtter//C6fpp4QfoNe+Hd7eTun 8cN1mFZavUhxGfxISCQ6+s8xN7zF9hIR0ws45aWGY3khVRSd6fj6qj4Z9LBfUmff9q9b liOE7bHAdzyhViksHpJTaDE3dEpySnEdCR5lay6cw9igIw9IvbZrCGQxXKLum83V01HT dy3A== X-Gm-Message-State: AC+VfDxrrYg67f5ak/9stPt4KVRiJk8JTeCslNMX5EbiktLRtFamd2Lj oINvxt+NUXQa7umMYXxY5kttZjuQwiMlCxq7k5WUdw== X-Google-Smtp-Source: ACHHUZ4ZPLptbystmtU6trjEckG8NUNPWsLG3nKkmqFCf8jC+wSuxd2Bn8iMtwsBlnJr/5XYF9Sv1VNeLfJP8hepHQA= X-Received: by 2002:a92:c24d:0:b0:313:93c8:e71f with SMTP id k13-20020a92c24d000000b0031393c8e71fmr241253ilo.19.1683217713083; Thu, 04 May 2023 09:28:33 -0700 (PDT) MIME-Version: 1.0 References: <20230504160845.2065510-1-james.clark@arm.com> In-Reply-To: <20230504160845.2065510-1-james.clark@arm.com> From: Ian Rogers Date: Thu, 4 May 2023 09:28:21 -0700 Message-ID: Subject: Re: [PATCH] perf: arm64: Fix build with refcount checking To: James Clark Cc: linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Thu, May 4, 2023 at 9:09=E2=80=AFAM James Clark wr= ote: > > With EXTRA_CFLAGS=3D-DREFCNT_CHECKING=3D1 and build-test, some unwrapped > map accesses appear. Wrap it in the new accessor to fix the error: > > error: 'struct perf_cpu_map' has no member named 'map' > > Signed-off-by: James Clark Thanks James and sorry for the breakage! Acked-by: Ian Rogers Ian > --- > tools/perf/arch/arm64/util/header.c | 4 ++-- > tools/perf/arch/arm64/util/pmu.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/arch/arm64/util/header.c b/tools/perf/arch/arm64/= util/header.c > index d730666ab95d..80b9f6287fe2 100644 > --- a/tools/perf/arch/arm64/util/header.c > +++ b/tools/perf/arch/arm64/util/header.c > @@ -29,8 +29,8 @@ static int _get_cpuid(char *buf, size_t sz, struct perf= _cpu_map *cpus) > char path[PATH_MAX]; > FILE *file; > > - scnprintf(path, PATH_MAX, "%s/devices/system/cpu/cpu%d"MI= DR, > - sysfs, cpus->map[cpu]); > + scnprintf(path, PATH_MAX, "%s/devices/system/cpu/cpu%d" M= IDR, > + sysfs, RC_CHK_ACCESS(cpus)->map[cpu].cpu); > > file =3D fopen(path, "r"); > if (!file) { > diff --git a/tools/perf/arch/arm64/util/pmu.c b/tools/perf/arch/arm64/uti= l/pmu.c > index fa143acb4c8d..ef1ed645097c 100644 > --- a/tools/perf/arch/arm64/util/pmu.c > +++ b/tools/perf/arch/arm64/util/pmu.c > @@ -18,7 +18,7 @@ static struct perf_pmu *pmu__find_core_pmu(void) > * The cpumap should cover all CPUs. Otherwise, some CPUs= may > * not support some events or have different event IDs. > */ > - if (pmu->cpus->nr !=3D cpu__max_cpu().cpu) > + if (RC_CHK_ACCESS(pmu->cpus)->nr !=3D cpu__max_cpu().cpu) > return NULL; > > return pmu; > -- > 2.34.1 >