From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AE2EB64DA for ; Fri, 30 Jun 2023 18:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232939AbjF3SCI (ORCPT ); Fri, 30 Jun 2023 14:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjF3SCH (ORCPT ); Fri, 30 Jun 2023 14:02:07 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 864471705 for ; Fri, 30 Jun 2023 11:02:05 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-401f4408955so28251cf.1 for ; Fri, 30 Jun 2023 11:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688148124; x=1690740124; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qg3LqEdLU3wZEunyax8ElGaV027EQp1GLKpP0FoAtZ4=; b=nUtk3UHqQQUVq/3fAMJN8zld0gA+IYs5zYdT7Uo+1PoprdBu4MRtnsgBqmZY7TI6MQ tF+X0kYmjcEQh+NLQuxHYi5w+WkoU8bV9BBveB9LXFmW2MbKYNQEmS/DlNZilCC9dkO2 eXjXEXYWe+97MJD14YN0gih7SwS53IBd0qr21WILpoLONQ5E2vS7B2NwXYBH0Vic9nqo PqArhZicfpl3NhBLgwWCIeIs8WYB7Fw5YmLqsS/+BpjNQNsJiHwEEVRvel5M3CTg/Iyt NvlOtAq6UcKM4UnQTXsP+5B4Fx71MrZzTzRRuIpn1QQGAbgyBTjMdxta1nuj0NWDMjhK Tdmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688148124; x=1690740124; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qg3LqEdLU3wZEunyax8ElGaV027EQp1GLKpP0FoAtZ4=; b=UTEUa/QJVfgjadCus+vDv1k6hTxi9A7jK3YorIYd3GdQZA4/26waIMVVP+zS6Tk9UV Y8Ila/cJWLhcGN0HUYDytPY1cSUzq5VXpwyddS2P9k6AJaI378pWfAdVTA2ma94gQMGT 0/bpyy8Hmz3uQ4CI0ip7xqzRcrcV+0jq6lgDQvt8G1UuVZH1NhIfYPJ1xN/clEITXcxN mUjasBPErkyueilOqwbvldpP0UNvhFXMAZxSKlC/gi6vM7oUd7JEwgugRPYgxyfywxOC lfUl/Hs0MAbzk/i/hE8lcX7iDyDiAD+8rCDFlRZtnLeoJRWiVVU5t4Ei1k16gGUkDkjZ TpHQ== X-Gm-Message-State: ABy/qLaJwzPuLcbcohwz4SpVwQm0ZhxbJkXdXjITyrKv2z87KlFZUyA4 X2pQCH9w+63dHk96IlM/vMafBTDN8ui8kHM4OdlFJeS+/pGe1MfZBXQ= X-Google-Smtp-Source: APBJJlHT2B/Kk6L2SpQUQcP6e9OV8JTKhSdmmFsb/AO5updG8vO6F+jx9bKgQAdCEXIYQy2VJpQxAAi77H3Vm/HQL5Y= X-Received: by 2002:a05:622a:10d:b0:3f2:2c89:f1ef with SMTP id u13-20020a05622a010d00b003f22c89f1efmr25916qtw.5.1688148124390; Fri, 30 Jun 2023 11:02:04 -0700 (PDT) MIME-Version: 1.0 References: <20230627181030.95608-2-irogers@google.com> <8dab7522-31de-2137-7474-991885932308@web.de> <59e92b31-cd78-5c0c-ef87-f0d824cd20f7@web.de> <44d77ec3-9a19-cfd5-4bba-4a23d0cd526b@web.de> In-Reply-To: From: Ian Rogers Date: Fri, 30 Jun 2023 11:01:53 -0700 Message-ID: Subject: Re: [v2 01/13] perf parse-events: Remove unused PE_PMU_EVENT_FAKE token To: Markus Elfring Cc: linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, kernel-janitors@vger.kernel.org, Adrian Hunter , Alexander Shishkin , Arnaldo Carvalho de Melo , Athira Rajeev , Ingo Molnar , Jiri Olsa , Kan Liang , Mark Rutland , Namhyung Kim , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri, Jun 30, 2023 at 10:52=E2=80=AFAM Markus Elfring wrote: > > >> Can the mentioned patch review concern be adjusted with wording altern= atives > >> for improved commit messages? > > > > Sorry, checked with a colleague and kernel contributor, > > Interesting =E2=80=A6 > > > > we don't know what is being requested here, > > Another bit of attention for a known information source: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D= ocumentation/process/submitting-patches.rst?h=3Dv6.4#n94 > > > > "imperative mood" makes no sense, > > How does such an opinion fit to the Linux development documentation? > > > > as such I don't have a fix for what you're requesting. > > I got the impression that further possibilities can be taken better into = account > also for improved change descriptions. Thanks Markus, I appreciate you feel you have a real point here, I'm just not getting it. Perhaps you can write a commit message that fulfils requirements like being in the correct "imperative mood" and I will learn and improve. Thanks, Ian > Regards, > Markus