linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: linux@treblig.org
Cc: yangyicong@hisilicon.com, jonathan.cameron@huawei.com,
	 peterz@infradead.org, mingo@redhat.com, jolsa@kernel.org,
	 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
Date: Mon, 3 Jun 2024 09:31:58 -0700	[thread overview]
Message-ID: <CAP-5=fXaaDZPL44Nar9uR94QvqgiYaaDjEpM1rb1mgiU69178A@mail.gmail.com> (raw)
In-Reply-To: <20240602000709.213116-1-linux@treblig.org>

On Sat, Jun 1, 2024 at 5:07 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@google.com>

Ian

> ---
>  tools/perf/util/hisi-ptt.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
>         u32 pmu_type;
>  };
>
> -struct hisi_ptt_queue {
> -       struct hisi_ptt *ptt;
> -       struct auxtrace_buffer *buffer;
> -};
> -
>  static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
>  {
>         uint32_t head = *(uint32_t *)buf;
> --
> 2.45.1
>

  parent reply	other threads:[~2024-06-03 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02  0:07 [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue' linux
2024-06-03  8:31 ` Jonathan Cameron
2024-06-03 16:31 ` Ian Rogers [this message]
2024-06-06 17:11 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-5=fXaaDZPL44Nar9uR94QvqgiYaaDjEpM1rb1mgiU69178A@mail.gmail.com' \
    --to=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).