From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D779C05027 for ; Mon, 6 Feb 2023 14:40:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbjBFOkg (ORCPT ); Mon, 6 Feb 2023 09:40:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjBFOkf (ORCPT ); Mon, 6 Feb 2023 09:40:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471CE1B56F for ; Mon, 6 Feb 2023 06:40:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D342960F0F for ; Mon, 6 Feb 2023 14:40:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6347C433EF; Mon, 6 Feb 2023 14:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675694433; bh=t9iIrsUHTjnBmZRzJ5/uLbX5TRcXl3Ays/RfP1ZqCqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jbP4NAyvNcSXGgnAjYhKRuD1pIR9A8EpHbhws0dnenQqM9P8D9icca8BDpED1bJsT ucWDtRpVSAZSkaOf5X7sqmxGWK8+p8hWcG3EKKvvGG5WgU1xpUCobOZz2VAk48l/7n wVOjjaq8by53lmqpXFjbRFUO1CcnhDH3OL7C1WUguPIlY6aqSZIejBNyGSICe1ErHC LCUhEEy+G7aQlaFGleRSfRaWAhmZqbaJ9WjpsOkyQz/N0ezV6oug44EAzSJxwMSx0q p6CbTfTZMHuPGbE36G+Y40iep9jURww4QAbcxYzDPhvR3JA0ggcbKVbDMFbgqkMf2R XB/NCkChFwhug== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BDF6A405BE; Mon, 6 Feb 2023 11:40:29 -0300 (-03) Date: Mon, 6 Feb 2023 11:40:29 -0300 From: Arnaldo Carvalho de Melo To: Athira Rajeev Cc: Jiri Olsa , Andi Kleen , Namhyung Kim , Ian Rogers , James Clark , Michael Ellerman , linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.vnet.ibm.com, Nageswara Sastry , Kajol Jain , disgoel@linux.ibm.com Subject: Re: [PATCH] tests/bpf: Fix the bpf test to check for libtraceevent support Message-ID: References: <20230131135001.54578-1-atrajeev@linux.vnet.ibm.com> <628A923D-A993-4A35-A90E-8F6798549FD0@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <628A923D-A993-4A35-A90E-8F6798549FD0@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Feb 06, 2023 at 09:27:13AM +0530, Athira Rajeev escreveu: > > On 02-Feb-2023, at 6:27 AM, Arnaldo Carvalho de Melo wrote: > > > > Em Tue, Jan 31, 2023 at 07:20:01PM +0530, Athira Rajeev escreveu: > >> "bpf" tests fails in environment with missing libtraceevent > >> support as below: > >> > >> # ./perf test 36 > >> 36: BPF filter : > >> 36.1: Basic BPF filtering : FAILED! > >> 36.2: BPF pinning : FAILED! > >> 36.3: BPF prologue generation : FAILED! > >> > >> The environment has clang but missing the libtraceevent > >> devel. Hence perf is compiled without libtraceevent support. > > > > Thanks, applied. > > Hi, > > Thanks for checking > > Arnaldo, this is applied to tmp.perf/core branch ? I thought I had this in :-\ Now its in tmp.perf/core. - Arnaldo > Athira > > > > - Arnaldo > > > > > >> Detailed logs: > >> ./perf test -v "Basic BPF filtering" > >> > >> Failed to add BPF event syscalls:sys_enter_epoll_pwait > >> bpf: tracepoint call back failed, stop iterate > >> Failed to add events selected by BPF > >> > >> The bpf tests tris to add probe event which fails > >> at "parse_events_add_tracepoint" function due to missing > >> libtraceevent. Add check for "HAVE_LIBTRACEEVENT" in the > >> "tests/bpf.c" before proceeding with the test. > >> > >> With the change, > >> > >> # ./perf test 36 > >> 36: BPF filter : > >> 36.1: Basic BPF filtering : Skip (not compiled in or missing libtraceevent support) > >> 36.2: BPF pinning : Skip (not compiled in or missing libtraceevent support) > >> 36.3: BPF prologue generation : Skip (not compiled in or missing libtraceevent support) > >> > >> Signed-off-by: Athira Rajeev > >> --- > >> tools/perf/tests/bpf.c | 22 +++++++++++----------- > >> 1 file changed, 11 insertions(+), 11 deletions(-) > >> > >> diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c > >> index 17c023823713..4af39528f611 100644 > >> --- a/tools/perf/tests/bpf.c > >> +++ b/tools/perf/tests/bpf.c > >> @@ -23,7 +23,7 @@ > >> #define NR_ITERS 111 > >> #define PERF_TEST_BPF_PATH "/sys/fs/bpf/perf_test" > >> > >> -#ifdef HAVE_LIBBPF_SUPPORT > >> +#if defined(HAVE_LIBBPF_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > >> #include > >> #include > >> > >> @@ -330,10 +330,10 @@ static int test__bpf(int i) > >> static int test__basic_bpf_test(struct test_suite *test __maybe_unused, > >> int subtest __maybe_unused) > >> { > >> -#ifdef HAVE_LIBBPF_SUPPORT > >> +#if defined(HAVE_LIBBPF_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > >> return test__bpf(0); > >> #else > >> - pr_debug("Skip BPF test because BPF support is not compiled\n"); > >> + pr_debug("Skip BPF test because BPF or libtraceevent support is not compiled\n"); > >> return TEST_SKIP; > >> #endif > >> } > >> @@ -341,10 +341,10 @@ static int test__basic_bpf_test(struct test_suite *test __maybe_unused, > >> static int test__bpf_pinning(struct test_suite *test __maybe_unused, > >> int subtest __maybe_unused) > >> { > >> -#ifdef HAVE_LIBBPF_SUPPORT > >> +#if defined(HAVE_LIBBPF_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > >> return test__bpf(1); > >> #else > >> - pr_debug("Skip BPF test because BPF support is not compiled\n"); > >> + pr_debug("Skip BPF test because BPF or libtraceevent support is not compiled\n"); > >> return TEST_SKIP; > >> #endif > >> } > >> @@ -352,17 +352,17 @@ static int test__bpf_pinning(struct test_suite *test __maybe_unused, > >> static int test__bpf_prologue_test(struct test_suite *test __maybe_unused, > >> int subtest __maybe_unused) > >> { > >> -#if defined(HAVE_LIBBPF_SUPPORT) && defined(HAVE_BPF_PROLOGUE) > >> +#if defined(HAVE_LIBBPF_SUPPORT) && defined(HAVE_BPF_PROLOGUE) && defined(HAVE_LIBTRACEEVENT) > >> return test__bpf(2); > >> #else > >> - pr_debug("Skip BPF test because BPF support is not compiled\n"); > >> + pr_debug("Skip BPF test because BPF or libtraceevent support is not compiled\n"); > >> return TEST_SKIP; > >> #endif > >> } > >> > >> > >> static struct test_case bpf_tests[] = { > >> -#ifdef HAVE_LIBBPF_SUPPORT > >> +#if defined(HAVE_LIBBPF_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > >> TEST_CASE("Basic BPF filtering", basic_bpf_test), > >> TEST_CASE_REASON("BPF pinning", bpf_pinning, > >> "clang isn't installed or environment missing BPF support"), > >> @@ -373,9 +373,9 @@ static struct test_case bpf_tests[] = { > >> TEST_CASE_REASON("BPF prologue generation", bpf_prologue_test, "not compiled in"), > >> #endif > >> #else > >> - TEST_CASE_REASON("Basic BPF filtering", basic_bpf_test, "not compiled in"), > >> - TEST_CASE_REASON("BPF pinning", bpf_pinning, "not compiled in"), > >> - TEST_CASE_REASON("BPF prologue generation", bpf_prologue_test, "not compiled in"), > >> + TEST_CASE_REASON("Basic BPF filtering", basic_bpf_test, "not compiled in or missing libtraceevent support"), > >> + TEST_CASE_REASON("BPF pinning", bpf_pinning, "not compiled in or missing libtraceevent support"), > >> + TEST_CASE_REASON("BPF prologue generation", bpf_prologue_test, "not compiled in or missing libtraceevent support"), > >> #endif > >> { .name = NULL, } > >> }; > >> -- > >> 2.39.0 > >> > > > > -- > > > > - Arnaldo > -- - Arnaldo