* [PATCH linux-next] perf: Use strscpy() instead of strlcpy()
@ 2022-10-20 8:54 cuijinpeng666
2022-10-20 9:48 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: cuijinpeng666 @ 2022-10-20 8:54 UTC (permalink / raw)
To: peterz, mingo
Cc: acme, mark.rutland, namhyung, linux-perf-users, linux-kernel,
Jinpeng Cui, Zeal Robot
From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
The implementation of strscpy() is more robust and safer.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
kernel/events/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 01933db7629c..5adf68cbd173 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8053,7 +8053,7 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event)
unsigned int size;
memset(comm, 0, sizeof(comm));
- strlcpy(comm, comm_event->task->comm, sizeof(comm));
+ strscpy(comm, comm_event->task->comm, sizeof(comm));
size = ALIGN(strlen(comm)+1, sizeof(u64));
comm_event->comm = comm;
@@ -8508,7 +8508,7 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)
}
cpy_name:
- strlcpy(tmp, name, sizeof(tmp));
+ strscpy(tmp, name, sizeof(tmp));
name = tmp;
got_name:
/*
@@ -8937,7 +8937,7 @@ void perf_event_ksymbol(u16 ksym_type, u64 addr, u32 len, bool unregister,
ksym_type == PERF_RECORD_KSYMBOL_TYPE_UNKNOWN)
goto err;
- strlcpy(name, sym, KSYM_NAME_LEN);
+ strscpy(name, sym, KSYM_NAME_LEN);
name_len = strlen(name) + 1;
while (!IS_ALIGNED(name_len, sizeof(u64)))
name[name_len++] = '\0';
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] perf: Use strscpy() instead of strlcpy()
2022-10-20 8:54 [PATCH linux-next] perf: Use strscpy() instead of strlcpy() cuijinpeng666
@ 2022-10-20 9:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-10-20 9:48 UTC (permalink / raw)
To: cuijinpeng666
Cc: peterz, mingo, acme, mark.rutland, namhyung, linux-perf-users,
linux-kernel, Jinpeng Cui, Zeal Robot
On Thu, Oct 20, 2022 at 08:54:11AM +0000, cuijinpeng666@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> ---
Please ignore based on this response:
https://lore.kernel.org/r/Y1EVnZS9BalesrC1@kroah.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 8:54 [PATCH linux-next] perf: Use strscpy() instead of strlcpy() cuijinpeng666
2022-10-20 9:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).