From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E5DFA373F for ; Mon, 24 Oct 2022 22:54:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbiJXWyy (ORCPT ); Mon, 24 Oct 2022 18:54:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbiJXWye (ORCPT ); Mon, 24 Oct 2022 18:54:34 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEC39321FE6; Mon, 24 Oct 2022 14:16:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6B8F3CE132B; Mon, 24 Oct 2022 11:39:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75F69C433B5; Mon, 24 Oct 2022 11:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666611593; bh=fCEDp+PSEpDcC1ByB+UoAAPsz26Ay97tQb1BDgCAMcw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QSrakSOHsS3P5RL6IVRNLl5dfP43mYfX5r5hqT2sjPb1KXq9PkhUgrQVjF4/g82ZQ mfxoyjfTbGOYo/3mWl0Q+flNELb7tHYPdD2m5FOsxMWHG24jsJTvfRZhRrDBSRDsD3 PeMIIbEgLURz4ntcCQYZuVkJPaQZhGHQm3wIT9FmEuEJRINx5oBrm9hwvl4KOME4Zq 8GS75NZ0KRDOqjMuyCmN1vutpmVilT2xGBJD2mTpBDH4qn9coOOGAv0OQcNLTGiGbU ed0fRsuDR8fJMfBcJeqLt/UDgZayIC67sZiQS+zlJFXqUHXnnPW9XY3DtJ4lYUmLk/ 5IvECQW6HEkJA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D915F404BE; Mon, 24 Oct 2022 08:39:51 -0300 (-03) Date: Mon, 24 Oct 2022 08:39:51 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Adrian Hunter , linux-perf-users@vger.kernel.org, Ammy Yi Subject: Re: [PATCH v2] perf test: Do not fail Intel-PT misc test w/o libpython Message-ID: References: <20221021181055.60183-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Oct 21, 2022 at 03:00:04PM -0700, Ian Rogers escreveu: > On Fri, Oct 21, 2022 at 11:11 AM Namhyung Kim wrote: > > > > The virtuall LBR test uses a python script to check the max size of > > nit: virtual Thanks, fixed and applied. - Arnaldo > > branch stack in the Intel-PT generated LBR. But it didn't check whether > > python scripting is available (as it's optional). > > > > Let's skip the test if the python support is not available. > > > > Fixes: f77811a0f625 ("perf test: test_intel_pt.sh: Add 9 tests") > > Cc: Ammy Yi > > Signed-off-by: Namhyung Kim > > Acked-by: Ian Rogers > > Thanks, > Ian > > > --- > > tools/perf/tests/shell/test_intel_pt.sh | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/tools/perf/tests/shell/test_intel_pt.sh b/tools/perf/tests/shell/test_intel_pt.sh > > index 4c0aabbe33bd..f5ed7b1af419 100755 > > --- a/tools/perf/tests/shell/test_intel_pt.sh > > +++ b/tools/perf/tests/shell/test_intel_pt.sh > > @@ -526,6 +526,12 @@ test_kernel_trace() > > test_virtual_lbr() > > { > > echo "--- Test virtual LBR ---" > > + # Check if python script is supported > > + libpython=$(perf version --build-options | grep python | grep -cv OFF) > > + if [ "${libpython}" != "1" ] ; then > > + echo "SKIP: python scripting is not supported" > > + return 2 > > + fi > > > > # Python script to determine the maximum size of branch stacks > > cat << "_end_of_file_" > "${maxbrstack}" > > -- > > 2.38.0.135.g90850a2211-goog > > -- - Arnaldo