From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: Shang XiaoJing <shangxiaojing@huawei.com>,
will@kernel.org, james.clark@arm.com, mike.leach@linaro.org,
leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org, kjain@linux.ibm.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/3] perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics
Date: Wed, 26 Oct 2022 11:03:12 -0300 [thread overview]
Message-ID: <Y1k+IPn+uvgdyY5c@kernel.org> (raw)
In-Reply-To: <c84fa985-7c86-880a-a10b-088120fb2b06@huawei.com>
Em Wed, Oct 26, 2022 at 10:07:44AM +0100, John Garry escreveu:
> On 21/10/2022 11:50, Shang XiaoJing wrote:
> > Commit 0cc177cfc95d ("perf vendor events arm64: Add Hisi hip08 L3
> > metrics") add L3 metrics of hip08, but some metrics (IF_BP_MISP_BR_RET,
> > IF_BP_MISP_BR_RET, IF_BP_MISP_BR_BL) have incorrect event number due to
> > the mistakes in document, which caused incorrect result. Fix the
> > incorrect metrics.
> >
> > before:
> > 65,811,214,308 armv8_pmuv3_0/event=0x1014/ # 18.87 push_branch
> > # -40.19 other_branch
> > 3,564,316,780 BR_MIS_PRED # 0.51 indirect_branch
> > # 21.81 pop_branch
> >
> > after:
> > 6,537,146,245 BR_MIS_PRED # 0.48 indirect_branch
> > # 0.47 pop_branch
> > # 0.00 push_branch
> > # 0.05 other_branch
> >
> > Fixes: 0cc177cfc95d ("perf vendor events arm64: Add Hisi hip08 L3 metrics")
> > Signed-off-by: Shang XiaoJing<shangxiaojing@huawei.com>
> > Cc: John Garry<john.garry@huawei.com>
> > Acked-by: James Clark<james.clark@arm.com>
>
> Reviewed-by: John Garry <john.garry@huawei.com>
Applied to perf/urgent.
- Arnaldo
next prev parent reply other threads:[~2022-10-26 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 10:50 [PATCH v2 0/3] perf vendor events arm64: Fix incorrect metrics and improve readability Shang XiaoJing
2022-10-21 10:50 ` [PATCH v2 1/3] perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics Shang XiaoJing
2022-10-26 9:07 ` John Garry
2022-10-26 14:03 ` Arnaldo Carvalho de Melo [this message]
2022-10-21 10:50 ` [PATCH v2 2/3] perf vendor events arm64: Add HiSilicon hip08 core events Shang XiaoJing
2022-10-26 9:23 ` John Garry
2022-10-21 10:50 ` [PATCH v2 3/3] perf vendor events arm64: Use event name instead of event code Shang XiaoJing
2022-10-26 9:25 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1k+IPn+uvgdyY5c@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=shangxiaojing@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).