linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>,
	linux-perf-users@vger.kernel.org, mingo@redhat.com,
	jolsa@kernel.org
Subject: Re: [RFC PATCH v1] perf data: Add fields when converting to json
Date: Thu, 10 Nov 2022 15:37:25 -0300	[thread overview]
Message-ID: <Y21E5RpLbBchuOdC@kernel.org> (raw)
In-Reply-To: <CAP-5=fXgO4ai5EvsYHw+_F2FUYqBRkBzXuBOZg_wHK0=_ymgFg@mail.gmail.com>

Em Tue, Nov 08, 2022 at 05:35:28PM -0800, Ian Rogers escreveu:
> On Tue, Nov 8, 2022 at 11:00 AM Dmitrii Dolgov <9erthalion6@gmail.com> wrote:
> >
> > When converting recorded data into json format, perf data omits probe
> > variables. Add them to the output in the format "field name": "field value"
> > using tep_print_field:
> >
> >     $ perf data convert --to-json output.json
> >
> >     // output.json
> >     {
> >         "linux-perf-json-version": 1,
> >         "headers": { ... },
> >         "samples": [
> >             {
> >             "timestamp": 29182079082999,
> >             "pid": 309194,
> >                     [...]
> >             "__probe_ip": "0x93ee35",
> >             "query_string_string": "select 2;",
> >             "nxids": "0"
> >             }
> >         ]
> >     }
> >
> > Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo


      parent reply	other threads:[~2022-11-10 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 19:00 [RFC PATCH v1] perf data: Add fields when converting to json Dmitrii Dolgov
2022-11-09  1:35 ` Ian Rogers
2022-11-09 10:37   ` Dmitry Dolgov
2022-11-10 18:37   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y21E5RpLbBchuOdC@kernel.org \
    --to=acme@kernel.org \
    --cc=9erthalion6@gmail.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).