From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
German Gomez <german.gomez@arm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 0/8] Update to C11, fix signal undefined behavior
Date: Thu, 3 Nov 2022 10:04:52 -0300 [thread overview]
Message-ID: <Y2O8dD/Noe+XnyT4@kernel.org> (raw)
In-Reply-To: <20221024181913.630986-1-irogers@google.com>
Em Mon, Oct 24, 2022 at 11:19:05AM -0700, Ian Rogers escreveu:
> The use of C11 is mainstream in the kernel [1]. There was some
> confusion on volatile and signal handlers in [2] for which atomics
> (present in C11) make things clearer. Switch to using volatile
> sig_atomic_t as per [3]. Thanks to Leo Yan <leo.yan@linaro.org> for
> the suggestions.
Thanks, applied and testing building it now.
- Arnaldo
> [1] https://lore.kernel.org/lkml/CAHk-=whWbENRz-vLY6vpESDLj6kGUTKO3khGtVfipHqwewh2HQ@mail.gmail.com/
> [2] https://lore.kernel.org/lkml/20221024011024.462518-1-irogers@google.com/
> [3] https://wiki.sei.cmu.edu/confluence/display/c/SIG31-C.+Do+not+access+shared+objects+in+signal+handlers
>
> v2. Remove unneeded stdatomic.h includes for sig_atomic_t as it is
> declared in signal.h.
>
> Ian Rogers (8):
> perf build: Update to C standard to gnu11
> perf record: Use sig_atomic_t for signal handlers
> perf daemon: Use sig_atomic_t to avoid UB
> perf ftrace: Use sig_atomic_t to avoid UB
> perf session: Change type to avoid UB
> perf stat: Use sig_atomic_t to avoid UB
> perf top: Use sig_atomic_t to avoid UB
> perf trace: Use sig_atomic_t to avoid UB
>
> tools/perf/Makefile.config | 2 +-
> tools/perf/builtin-daemon.c | 2 +-
> tools/perf/builtin-ftrace.c | 4 ++--
> tools/perf/builtin-record.c | 8 ++++----
> tools/perf/builtin-stat.c | 8 ++++----
> tools/perf/builtin-top.c | 4 ++--
> tools/perf/builtin-trace.c | 4 ++--
> tools/perf/util/session.c | 3 ++-
> 8 files changed, 18 insertions(+), 17 deletions(-)
>
> --
> 2.38.0.135.g90850a2211-goog
--
- Arnaldo
prev parent reply other threads:[~2022-11-03 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 18:19 [PATCH v2 0/8] Update to C11, fix signal undefined behavior Ian Rogers
2022-10-24 18:19 ` [PATCH v2 1/8] perf build: Update to C standard to gnu11 Ian Rogers
2022-10-24 18:19 ` [PATCH v2 2/8] perf record: Use sig_atomic_t for signal handlers Ian Rogers
2022-10-24 18:19 ` [PATCH v2 3/8] perf daemon: Use sig_atomic_t to avoid UB Ian Rogers
2022-10-24 18:19 ` [PATCH v2 4/8] perf ftrace: " Ian Rogers
2022-10-24 18:19 ` [PATCH v2 5/8] perf session: Change type " Ian Rogers
2022-10-24 18:19 ` [PATCH v2 6/8] perf stat: Use sig_atomic_t " Ian Rogers
2022-10-24 18:19 ` [PATCH v2 7/8] perf top: " Ian Rogers
2022-10-24 18:19 ` [PATCH v2 8/8] perf trace: " Ian Rogers
2022-11-03 13:04 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2O8dD/Noe+XnyT4@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=eranian@google.com \
--cc=german.gomez@arm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).