linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Michael Petlan <mpetlan@redhat.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf test: Fix record test on KVM guests
Date: Wed, 23 Nov 2022 10:35:56 -0300	[thread overview]
Message-ID: <Y34hvEyFjST2GDK6@kernel.org> (raw)
In-Reply-To: <CAP-5=fUj11rCAA8t6FUN1N+pLO4-FWE-buAVor-v41gYJ7M3hw@mail.gmail.com>

Em Tue, Nov 22, 2022 at 09:31:49PM -0800, Ian Rogers escreveu:
> On Tue, Nov 22, 2022 at 12:33 AM Michael Petlan <mpetlan@redhat.com> wrote:
> >
> > Using precise flag with br_inst_retired.near_call causes the test fail
> > on KVM guests, even when the guests have PMU forwarding enabled and the
> > event itself is supported.
> >
> > Remove the precise flag in order to make the test work on KVM guests.
> >
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/tests/shell/record.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index e93b3a8871fe..a796222288ec 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -134,7 +134,7 @@ test_register_capture() {
> >      echo "Register capture test [Skipped missing registers]"
> >      return
> >    fi
> > -  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
> > +  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call \
> >      -c 1000 --per-thread ${testprog} 2> /dev/null \
> >      | perf script -F ip,sym,iregs -i - 2> /dev/null \
> >      | grep -q "DI:"
> > --
> > 2.18.4
> >

-- 

- Arnaldo

      reply	other threads:[~2022-11-23 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  8:31 [PATCH] perf test: Fix record test on KVM guests Michael Petlan
2022-11-23  5:31 ` Ian Rogers
2022-11-23 13:35   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y34hvEyFjST2GDK6@kernel.org \
    --to=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mpetlan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).