[PATCH] perf test: Fix record test on KVM guests

[PATCH] perf test: Fix record test on KVM guests

[Michael Petlan]

Using precise flag with br_inst_retired.near_call causes the test fail
on KVM guests, even when the guests have PMU forwarding enabled and the
event itself is supported.

Remove the precise flag in order to make the test work on KVM guests.

Signed-off-by: Michael Petlan <mpetlan@redhat.com>
---
 tools/perf/tests/shell/record.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index e93b3a8871fe..a796222288ec 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -134,7 +134,7 @@ test_register_capture() {
     echo "Register capture test [Skipped missing registers]"
     return
   fi
-  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
+  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call \
     -c 1000 --per-thread ${testprog} 2> /dev/null \
     | perf script -F ip,sym,iregs -i - 2> /dev/null \
     | grep -q "DI:"
-- 
2.18.4

Re: [PATCH] perf test: Fix record test on KVM guests

[Ian Rogers]

On Tue, Nov 22, 2022 at 12:33 AM Michael Petlan <mpetlan@redhat.com> wrote:
>
> Using precise flag with br_inst_retired.near_call causes the test fail
> on KVM guests, even when the guests have PMU forwarding enabled and the
> event itself is supported.
>
> Remove the precise flag in order to make the test work on KVM guests.
>
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/record.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index e93b3a8871fe..a796222288ec 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -134,7 +134,7 @@ test_register_capture() {
>      echo "Register capture test [Skipped missing registers]"
>      return
>    fi
> -  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
> +  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call \
>      -c 1000 --per-thread ${testprog} 2> /dev/null \
>      | perf script -F ip,sym,iregs -i - 2> /dev/null \
>      | grep -q "DI:"
> --
> 2.18.4
>

Re: [PATCH] perf test: Fix record test on KVM guests

[Arnaldo Carvalho de Melo]

Em Tue, Nov 22, 2022 at 09:31:49PM -0800, Ian Rogers escreveu:
> On Tue, Nov 22, 2022 at 12:33 AM Michael Petlan <mpetlan@redhat.com> wrote:
> >
> > Using precise flag with br_inst_retired.near_call causes the test fail
> > on KVM guests, even when the guests have PMU forwarding enabled and the
> > event itself is supported.
> >
> > Remove the precise flag in order to make the test work on KVM guests.
> >
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/tests/shell/record.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index e93b3a8871fe..a796222288ec 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -134,7 +134,7 @@ test_register_capture() {
> >      echo "Register capture test [Skipped missing registers]"
> >      return
> >    fi
> > -  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
> > +  if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call \
> >      -c 1000 --per-thread ${testprog} 2> /dev/null \
> >      | perf script -F ip,sym,iregs -i - 2> /dev/null \
> >      | grep -q "DI:"
> > --
> > 2.18.4
> >

-- 

- Arnaldo