From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Steven Rostedt <rostedt@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v1 1/2] perf build: Require libtraceevent from the system
Date: Fri, 18 Nov 2022 12:02:38 -0300 [thread overview]
Message-ID: <Y3eejjLjChlGC96I@kernel.org> (raw)
In-Reply-To: <Y3dQxVNwGmQMWPP0@hirez.programming.kicks-ass.net>
Em Fri, Nov 18, 2022 at 10:30:45AM +0100, Peter Zijlstra escreveu:
> On Thu, Nov 17, 2022 at 02:49:51PM -0800, Ian Rogers wrote:
> > Unconditionally require libtraceevent to come from the system. Force
> > the determination of the libtracefs version if it is present.
>
> -ENOMOTIVATION
Yeah, I was going to ask for that as well :-\
And the motivation was spelled out in the discussion that led to this
patch:
https://lore.kernel.org/lkml/CAP-5=fWxAjEia-Qbm0RVzKOxyiod8rUOBieqaGK=DtQboDe3Qw@mail.gmail.com
> also:
>
> Makefile.config:1196: *** Error: libtraceevent is missing, please install libtraceevent-dev. Stop.
yeah, this probably should work like with other libraries, don't stop
the build, just don't build features that depend on libtraceevent,
warning the user that features foo, bar and baz won't be available.
For people working with just hardware, software, cache events, no
problem.
- Arnaldo
next prev parent reply other threads:[~2022-11-18 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 22:49 [PATCH v1 0/2] perf always use system libtraceevent Ian Rogers
2022-11-17 22:49 ` [PATCH v1 1/2] perf build: Require libtraceevent from the system Ian Rogers
2022-11-18 9:30 ` Peter Zijlstra
2022-11-18 15:02 ` Arnaldo Carvalho de Melo [this message]
2022-11-18 15:33 ` Steven Rostedt
2022-11-18 16:34 ` Arnaldo Carvalho de Melo
2022-11-19 0:37 ` Namhyung Kim
[not found] ` <20221117224952.358639-3-irogers@google.com>
2022-11-17 23:16 ` [PATCH v1 2/2] tools lib traceevent: Remove libtraceevent Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3eejjLjChlGC96I@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rostedt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).