From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D1CC4321E for ; Mon, 5 Dec 2022 13:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbiLENDp (ORCPT ); Mon, 5 Dec 2022 08:03:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231579AbiLENDn (ORCPT ); Mon, 5 Dec 2022 08:03:43 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B2717076; Mon, 5 Dec 2022 05:03:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DD508B80F79; Mon, 5 Dec 2022 13:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C79DC433D6; Mon, 5 Dec 2022 13:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670245416; bh=Quf8sZ9+qKyYMVb9fzP+lHM/3KdkQrgRIaq463QOEqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mnPeEla3sDLBZSYO61/ydsUn2P/Tr91kbJ+GSZTiOUrs9nA6IwjkQj1QrIUqDwxgr E36EfikIxwS3d2OsMWeoY43FguQ+Akvy0RlH3MeXKqqruOoAknH5jljzhr30OKjy02 PZzq50RMCu0KLCA6472I9kX66T0kDlUSVXG5ylKzdlcTGOiLSRunSNjCjqhdsGpJhY iy+BGA7ZfouBBIQGjozOiBCRGfPcbpSu+5OJstmCK7bY/FDpKlpL3t6EYa+wm2jHGc V450oEKFy7w78OSDdr3obgQLmM6CSbwTaABz2Y4pDTEse7NR68OCMH9fZ7BbMP4gwE puqaRHd3bRSrA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4B26940404; Mon, 5 Dec 2022 10:03:34 -0300 (-03) Date: Mon, 5 Dec 2022 10:03:34 -0300 From: Arnaldo Carvalho de Melo To: "Wang, Weilin" Cc: Namhyung Kim , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , "Hunter, Adrian" , "linux-perf-users@vger.kernel.org" , Kan Liang , Zhengjun Xing , James Clark , Athira Jajeev Subject: Re: [PATCH] perf stat: Fix multi-line metric output in JSON Message-ID: References: <20221202190447.1588680-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Dec 02, 2022 at 07:31:59PM +0000, Wang, Weilin escreveu: > Namhyung, it works. Thanks! Thanks, applied and added a Tested-by: Weilin, ok? - Arnaldo > -----Original Message----- > From: Namhyung Kim On Behalf Of Namhyung Kim > Sent: Friday, December 2, 2022 11:05 AM > To: Arnaldo Carvalho de Melo ; Jiri Olsa > Cc: Ingo Molnar ; Peter Zijlstra ; LKML ; Ian Rogers ; Hunter, Adrian ; linux-perf-users@vger.kernel.org; Kan Liang ; Zhengjun Xing ; James Clark ; Athira Jajeev ; Wang, Weilin > Subject: [PATCH] perf stat: Fix multi-line metric output in JSON > > When a metric produces more than one values, it missed to print the opening bracket. > > Fixes: ab6baaae2735 ("perf stat: Fix JSON output in metric-only mode") > Reported-by: "Wang, Weilin" > Signed-off-by: Namhyung Kim > --- > Weilin, could you please verify it fixes your problem? > > tools/perf/util/stat-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index f1ee4b052198..8d0bdd57163d 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -440,7 +440,7 @@ static void new_line_json(struct perf_stat_config *config, void *ctx) { > struct outstate *os = ctx; > > - fputc('\n', os->fh); > + fputs("\n{", os->fh); > if (os->prefix) > fprintf(os->fh, "%s", os->prefix); > aggr_printout(config, os->evsel, os->id, os->nr); > -- > 2.39.0.rc0.267.gcb52ba06e7-goog -- - Arnaldo