From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org,
James Clark <james.clark@arm.com>,
Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH] Revert "perf stat: Rename "aggregate-number" to "cpu-count" in JSON"
Date: Mon, 5 Dec 2022 10:09:36 -0300 [thread overview]
Message-ID: <Y43tkBsn5gZhIkXa@kernel.org> (raw)
In-Reply-To: <20221130193613.1046804-1-namhyung@kernel.org>
Em Wed, Nov 30, 2022 at 11:36:13AM -0800, Namhyung Kim escreveu:
> This reverts commit c4b41b83c25073c09bfcc4e5ec496c9dd316656b.
>
> As Ian said, the "cpu-count" is not appropriate for uncore events, also it
> caused a perf test failure.
This was applied, thanks.
- Arnaldo
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/stat-display.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 847acdb5dc40..f1ee4b052198 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -281,19 +281,19 @@ static void print_aggr_id_json(struct perf_stat_config *config,
>
> switch (config->aggr_mode) {
> case AGGR_CORE:
> - fprintf(output, "\"core\" : \"S%d-D%d-C%d\", \"cpu-count\" : %d, ",
> + fprintf(output, "\"core\" : \"S%d-D%d-C%d\", \"aggregate-number\" : %d, ",
> id.socket, id.die, id.core, nr);
> break;
> case AGGR_DIE:
> - fprintf(output, "\"die\" : \"S%d-D%d\", \"cpu-count\" : %d, ",
> + fprintf(output, "\"die\" : \"S%d-D%d\", \"aggregate-number\" : %d, ",
> id.socket, id.die, nr);
> break;
> case AGGR_SOCKET:
> - fprintf(output, "\"socket\" : \"S%d\", \"cpu-count\" : %d, ",
> + fprintf(output, "\"socket\" : \"S%d\", \"aggregate-number\" : %d, ",
> id.socket, nr);
> break;
> case AGGR_NODE:
> - fprintf(output, "\"node\" : \"N%d\", \"cpu-count\" : %d, ",
> + fprintf(output, "\"node\" : \"N%d\", \"aggregate-number\" : %d, ",
> id.node, nr);
> break;
> case AGGR_NONE:
> --
> 2.38.1.584.g0f3c55d4c2-goog
--
- Arnaldo
prev parent reply other threads:[~2022-12-05 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 19:36 [PATCH] Revert "perf stat: Rename "aggregate-number" to "cpu-count" in JSON" Namhyung Kim
2022-12-05 13:09 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y43tkBsn5gZhIkXa@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).