From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF985C3A5A7 for ; Tue, 6 Dec 2022 16:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234510AbiLFQam (ORCPT ); Tue, 6 Dec 2022 11:30:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232324AbiLFQal (ORCPT ); Tue, 6 Dec 2022 11:30:41 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0B22BC99; Tue, 6 Dec 2022 08:30:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94E69B81AB4; Tue, 6 Dec 2022 16:30:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEF38C433D6; Tue, 6 Dec 2022 16:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670344237; bh=uSs6ZfsXTI/wj4FOJ5tx7pLbTvH5TLILgvDFOd+upCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jpTEBnQ4ijo+hjdHrhyL5S4f3BbTcxVAHDyIGBS4hFyi57RZBNDTT65FzCS4ywwX+ 6/WF1iLkxyjCQZi4hvXM0mewXlUMLtlF8VFLHb5G1qSCq29ORVnifXEjtAmFK60Ocd TvcMQbVlDmMWEf9Ddj6XLjtSQh6SwE7QJHfssCDvfHDxWtZpgwMJ4kvnSUUMGYJ7R0 RL3dU19QCDbwoVZ8e4o3Kga1ApFXz5pbJFDNfYyH2lTdZLPWnLA/YVlgIhnC3osAZ7 wuasijiyF1xWX3J1TK29Qe/erQADZSYnzvauGbcRW8ZY/Vh240lMhCk9ghz0A7czbf kjfnblnZyFTqw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 91D9740404; Tue, 6 Dec 2022 13:30:33 -0300 (-03) Date: Tue, 6 Dec 2022 13:30:33 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Nick Desaulniers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/3] perf build: Use libtraceevent from the system Message-ID: References: <20221205225940.3079667-1-irogers@google.com> <20221205225940.3079667-3-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Dec 06, 2022 at 01:23:45PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Dec 06, 2022 at 01:20:12PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > util/scripting-engines/trace-event-perl.c:104:43: error: ‘struct tep_print_flag_sym’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > 104 | static void define_symbolic_values(struct tep_print_flag_sym *field, > > | ^~~~~~~~~~~~~~~~~~ > > util/scripting-engines/trace-event-perl.c: In function ‘define_symbolic_values’: > > This cured it, folding into your patch: > > diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/perf/util/scripting-engines/trace-event-perl.c > index 5b602b6d46854133..0bacb49408f84adf 100644 > --- a/tools/perf/util/scripting-engines/trace-event-perl.c > +++ b/tools/perf/util/scripting-engines/trace-event-perl.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > > #include > /* perl needs the following define, right after including stdbool.h */ Building with NO_LIBTRACEEVENT=1 I get: CC /tmp/build/perf/util/cap.o util/data-convert-bt.c: In function ‘get_tracepoint_field_type’: util/data-convert-bt.c:194:36: error: invalid use of undefined type ‘struct tep_format_field’ 194 | unsigned long flags = field->flags; | ^~ util/data-convert-bt.c:196:21: error: ‘TEP_FIELD_IS_STRING’ undeclared (first use in this function) 196 | if (flags & TEP_FIELD_IS_STRING) | ^~~~~~~~~~~~~~~~~~~ util/data-convert-bt.c:196:21: note: each undeclared identifier is reported only once for each function it appears in util/data-convert-bt.c:199:23: error: ‘TEP_FIELD_IS_SIGNED’ undeclared (first use in this function) 199 | if (!(flags & TEP_FIELD_IS_SIGNED)) { | ^~~~~~~~~~~~~~~~~~~ util/data-convert-bt.c:201:29: error: ‘TEP_FIELD_IS_LONG’ undeclared (first use in this function) 201 | if (flags & TEP_FIELD_IS_LONG || flags & TEP_FIELD_IS_POINTER) | ^~~~~~~~~~~~~~~~~ working on it...