From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA589C4332F for ; Tue, 20 Dec 2022 18:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233966AbiLTSif (ORCPT ); Tue, 20 Dec 2022 13:38:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231638AbiLTSif (ORCPT ); Tue, 20 Dec 2022 13:38:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 677DFDE9F; Tue, 20 Dec 2022 10:38:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 293FCB8172E; Tue, 20 Dec 2022 18:38:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ECD0C433D2; Tue, 20 Dec 2022 18:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671561511; bh=Xj/b06Er8ntqgengAsZZnDqTEhBrCfhXtWgAuFSnylU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=REr7hAuAOSJYgw5/ADVLCc+eloLEo7UiZFp/jMsL5nZ5RzTGZ2PspmgYejx0Nwkc7 W8iGTsYJiZrM5uKoX9qIrEWcHJ3X3kInoflfd5yv33UhtSq+O9tZaScahDCakkzbCK zhqNu7/+Z/+Gi2G3c/bmd62tCY4z0OUr4OMz6Fxrrye/JUUGgF8Y2vZYtSfP1bZwG+ RXH6VteXcmeM7/PzHtYSFHQE1WenXJp/zjy00UlNDY/SltzHKJIE5pHoHtpmAAsaNC NQVzs+QMfBZZhOtkw5RIGLoPUyZQ9dZSJZlCJWjBChTbJ0puddBc2sknX7KFcCUJLJ xIf3POhdwCzGw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0C5A240367; Tue, 20 Dec 2022 15:38:29 -0300 (-03) Date: Tue, 20 Dec 2022 15:38:29 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Andi Kleen , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Milian Wolff , Leo Yan Subject: Re: [PATCH 2/9] perf report: Ignore SIGPIPE for srcline Message-ID: References: <20221215192817.2734573-1-namhyung@kernel.org> <20221215192817.2734573-3-namhyung@kernel.org> <18594a2a-553a-c2b8-2c4f-6f7563ae3727@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Dec 16, 2022 at 10:08:50AM -0800, Namhyung Kim escreveu: > Hi Andi, > > On Thu, Dec 15, 2022 at 11:25 PM Andi Kleen wrote: > > > > > > On 12/15/2022 9:28 PM, Namhyung Kim wrote: > > > It can get SIGPIPE when it uses an external addr2line process and the > > > process was terminated unexpectedly. Let's ignore the signal and move > > > on to the next sample. The sample will get the default srcline value > > > anyway. > > > > > > That's a bit dangerous -- if perf report output is piped to something > > else you really want to stop on SIGPIPE. > > Maybe we can handle the pipe write errors gracefully, but it'd require > more changes in many places. > > > > > You would need to find a way to distinguish those cases. > > Hmm.. ok. I guess we can just drop this for now. With checking > the .debug_line section, problematic cases should be gone mostly. So just skip this one, ok, I'll cherry pick the rest. Done. - Arnaldo