From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 329D6C38159 for ; Fri, 20 Jan 2023 05:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjATF3V (ORCPT ); Fri, 20 Jan 2023 00:29:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231243AbjATF2p (ORCPT ); Fri, 20 Jan 2023 00:28:45 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B43AF72C0F; Thu, 19 Jan 2023 21:23:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C4A94B825FA; Thu, 19 Jan 2023 16:27:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28611C433EF; Thu, 19 Jan 2023 16:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674145652; bh=rFKR1hKMBI+MtzO4V9xJtCxqUhqcAJzkDhj8cS00xzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f8trZE7TrGfyonP7IswrV7OueQT1uyfwewfYfh66CVY9NIK5grGPOzqOAtVbZzXkW bvaa8xviYC+dbzeEFB4b6rz5eXP2BmbYOtNcp4iBPqK52dIhIRaWdFT9bWbWtBf/UK TAmHvBCuDPUb6f7GpCFI5QKuBdaOSghJOj1cfEVyTLnZ+IHeDw30R129Oh2cOw6M5j sbpAX1r+svuq9YUfY6a48qe/yO1AS7DLL3ukqWrlrB+19FSDkZD0sgOWIYRqlrlt1M 1JuBv6BRmiYfHMLhIMktjfW9S40j6vmkqTSomJKfeCFuslvQZYAEKnzJZldVN0QrGE CV4svrcc6dSBg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 37660405BE; Thu, 19 Jan 2023 13:27:28 -0300 (-03) Date: Thu, 19 Jan 2023 13:27:28 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Yang Jihong , Kan Liang , Kim Phillips , German Gomez , Sean Christopherson , Paolo Bonzini , Eelco Chaudron , Leo Yan , Athira Rajeev , Stephane Eranian , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] perf tools: Remove HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE Message-ID: References: <20230111070641.1728726-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Jan 19, 2023 at 08:01:32AM -0800, Ian Rogers escreveu: > On Tue, Jan 10, 2023 at 11:06 PM Ian Rogers wrote: > > > > Switch HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE to be a version number > > test on libtraceevent being >= to version 1.5.0. This also corrects a > > greater-than test to be greater-than-or-equal. > > > > Discussed here: > > https://lore.kernel.org/lkml/20221205225940.3079667-3-irogers@google.com/ > > > > Fixes: b9a49f8cb02f ("perf tools: Check if libtracevent has TEP_FIELD_IS_RELATIVE") > > Signed-off-by: Ian Rogers > > Ping. Remove one ifdef in favor of a consistent version check, gets > debug logging from libtraceevent going. Thanks, applied. - Arnaldo