From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org, tanmay@marvell.com,
leo.yan@linaro.org, mike.leach@linaro.org, sgoutham@marvell.com,
gcherian@marvell.com, lcherian@marvell.com,
bbhushan2@marvell.com,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/8] perf cs_etm: Basic support for virtual/kernel timestamps
Date: Fri, 20 Jan 2023 13:58:46 -0300 [thread overview]
Message-ID: <Y8rIRuUd4h+309cE@kernel.org> (raw)
In-Reply-To: <72843540-fe25-d805-df76-3a3556fb5774@arm.com>
Em Fri, Jan 20, 2023 at 02:39:30PM +0000, James Clark escreveu:
>
>
> On 19/01/2023 16:58, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 19, 2023 at 03:42:59PM +0000, James Clark escreveu:
> >> Changes since v3:
> >>
> >> * Scale time estimates by INSTR_PER_NS, rather than assuming 1
> >> instruction = 1ns
> >> * Add a new commit that fixes some issues around timestamps going
> >> backwards
> >> * Use nanoseconds inside cs-etm-decoder.c, rather than storing the
> >> raw time values and converting when a sample is synthesized. This
> >> simplifies some of the code like estimating the first timestamp.
> >
> > I would check this myself, but since Suzuki had some review comments and
> > you may consider a v5, please check this:
> >
> > Cover: ./v4_20230119_james_clark_perf_cs_etm_basic_support_for_virtual_kernel_timestamps.cover
> > Link: https://lore.kernel.org/r/20230119154308.3815108-1-james.clark@arm.com
> > git checkout -b v4_20230119_james_clark_arm_com 69b41ac87e4a664de78a395ff97166f0b2943210
> > git am ./v4_20230119_james_clark_perf_cs_etm_basic_support_for_virtual_kernel_timestamps.mbx
> > [acme@quaco perf]$ git am ./v4_20230119_james_clark_perf_cs_etm_basic_support_for_virtual_kernel_timestamps.mbx
> > Applying: perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH
> > error: patch failed: tools/perf/util/pmu.c:1993
> > error: tools/perf/util/pmu.c: patch does not apply
> > error: patch failed: tools/perf/util/pmu.h:259
> > error: tools/perf/util/pmu.h: patch does not apply
> > Patch failed at 0001 perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH
> > hint: Use 'git am --show-current-patch=diff' to see the failed patch
> > When you have resolved this problem, run "git am --continue".
> > If you prefer to skip this patch, run "git am --skip" instead.
> > To restore the original branch and stop patching, run "git am --abort".
> > [acme@quaco perf]$
> >
> > Probably a conflict with one of these:
> >
> > [acme@quaco perf]$ git log --oneline -5 tools/perf/util/pmu.c
> > acef233b7ca749fd perf pmu: Add #slots literal support for arm64
> > 336b92da1aa4228a perf tool: Move pmus list variable to a new file
> > 49bd97c28b7e7f01 perf tools: Use dedicated non-atomic clear/set bit helpers
> > e5c6109f4813246a perf list: Reorganize to use callbacks to allow honouring command line options
> > eb2d4514a5971444 perf pmu: Restructure print_pmu_events() to avoid memory allocations
> > [acme@quaco perf]$
> >
> > Update to my perf/core branch or even tmp.perf/core which is newer but
> > still needs the full set of container build tests.
>
> Oops I must have just missed the latest perf/core update. I fixed the
> conflict and sent a v5, and decided to not make any changes for Suzuki's
> comments.
Trying it now
prev parent reply other threads:[~2023-01-20 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:42 [PATCH v4 0/8] perf cs_etm: Basic support for virtual/kernel timestamps James Clark
2023-01-19 15:43 ` [PATCH v4 1/8] perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH James Clark
2023-01-19 15:43 ` [PATCH v4 2/8] perf: Use perf_pmu__open_file() and perf_pmu__scan_file() James Clark
2023-01-19 15:43 ` [PATCH v4 3/8] perf: Remove remaining duplication of bus/event_source/devices/ James Clark
2023-01-19 15:43 ` [PATCH v4 4/8] perf pmu: Add function to check if a pmu file exists James Clark
2023-01-19 15:43 ` [PATCH v4 5/8] perf cs_etm: Keep separate symbols for ETMv4 and ETE parameters James Clark
2023-01-19 15:43 ` [PATCH v4 6/8] perf cs_etm: Record ts_source in AUXTRACE_INFO for ETMv4 and ETE James Clark
2023-01-19 15:56 ` Suzuki K Poulose
2023-01-19 16:49 ` James Clark
2023-01-19 15:43 ` [PATCH v4 7/8] perf cs_etm: Set the time field in the synthetic samples James Clark
2023-01-19 15:43 ` [PATCH v4 8/8] perf: cs-etm: Ensure that Coresight timestamps don't go backwards James Clark
2023-01-19 16:58 ` [PATCH v4 0/8] perf cs_etm: Basic support for virtual/kernel timestamps Arnaldo Carvalho de Melo
2023-01-20 14:39 ` James Clark
2023-01-20 16:58 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8rIRuUd4h+309cE@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bbhushan2@marvell.com \
--cc=coresight@lists.linaro.org \
--cc=gcherian@marvell.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=lcherian@marvell.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sgoutham@marvell.com \
--cc=suzuki.poulose@arm.com \
--cc=tanmay@marvell.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).