From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14976C636D4 for ; Fri, 3 Feb 2023 14:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232809AbjBCOgg (ORCPT ); Fri, 3 Feb 2023 09:36:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232603AbjBCOgf (ORCPT ); Fri, 3 Feb 2023 09:36:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4066E83FA; Fri, 3 Feb 2023 06:36:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F19C61F48; Fri, 3 Feb 2023 14:36:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7245C433EF; Fri, 3 Feb 2023 14:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675434993; bh=28utDxiV3Rp5JUpEe2sC6Dt8bzeVHrv1nst7Z5amXrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G/VQIdSD73xW8QY8ihx6OdRO2O4L+7xe6S5V7LFKkPxC5QMnyGa/aLQKyZQH0h3bi MwXvNHi/b+5oIX0kPZRlqKQPLeIzCnXFdBE2WnJpvgCZVJO1p1F8AQuptvZFr0mQ/j /pUmyNxxajhvQkINPwuPjAu/iDajZyxFQtuFzfbSbKns7rQ013mQFNY03Pj1wMWSeM gc/RVbiV24j87vku/8r7nYcdhVEIATMi8DQ0hhcjmnO/HaPOPDRiaVYz1dVvszajJY UU++TKmpzJaRJdUmUb22vBMWPFw2obXsKuU5Xn1W6vaxkDiUlt/4q5E3Mwuw/DawkC yRsrJ9Iwz2g5g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BCBC4405BE; Fri, 3 Feb 2023 11:36:30 -0300 (-03) Date: Fri, 3 Feb 2023 11:36:30 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain , Stephane Eranian , Perry Taylor , Caleb Biggers Subject: Re: [PATCH v1] perf pmu: Fix aarch64 build Message-ID: References: <20230203014014.75720-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu: > > > On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote: > > > > > > > > ARM64 overrides a weak function but a previous change had broken the > > > > build. > > > > > > > > Fixes: 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") > > > > > > As 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") is > > > only on tmp.perf/core then it may be best to just squash this fix into > > > that. > > > > Yeah, that was my intention, I'll fold it there to keep bisection, > > thanks for fixing it so fast, I'll double check on my rk3399 board and > > on again on the cross-build container. > > Nope, that is not what I reported yesterday, trying to build it on the > rk3399 board: Sorry, pulled the trigger too soon, this is _before_ applying your fix, I should't multitask too much :-\ I'll double check now, - Arnaldo