From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55555C636CD for ; Thu, 2 Feb 2023 00:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbjBBAq2 (ORCPT ); Wed, 1 Feb 2023 19:46:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjBBAq1 (ORCPT ); Wed, 1 Feb 2023 19:46:27 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1B5C3C295; Wed, 1 Feb 2023 16:46:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 13FE5CE269F; Thu, 2 Feb 2023 00:46:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1704DC433D2; Thu, 2 Feb 2023 00:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675298783; bh=xk6f4NHas/vT/Qe7b8z9Hi0bMapUpjdB9ydGAUQ5Ocw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IivLYCFt96qUfOs4fVGoC5rgdG4i6lQiSf5clLOhito5sc2MJErMOUXJQj4VxNt7C Kp4M7MS9mfqwxQpsVVV/4YHGJDoWELKE3/32AJjHiwlXHKDc5dRdaYpblSlrtmkRew MqYwJXC529Dso0kabD6QmKlWbc2wodyuYh8lsk96qZae1nPyGecyP7nmU3W0/ytQFP PBnuAjerep2WYl5Nwr9fJuhDCQadNvLtCgR5iklxQQ7Y5YBYVl4aRXJfjaGgKX+4Mh wFWk+9+KvSbB3OokfG80ZcEYIZFoRxbDMBKK/smxo+hPv/NbPSzB49PEkLoNOQL30n /t8YhC04snewg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EFE54405BE; Wed, 1 Feb 2023 21:46:20 -0300 (-03) Date: Wed, 1 Feb 2023 21:46:20 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Adrian Hunter , Jiri Olsa , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH V2 0/9] perf symbols: Improve dso__synthesize_plt_symbols() for x86 Message-ID: References: <20230131131625.6964-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Jan 31, 2023 at 10:59:58PM -0800, Namhyung Kim escreveu: > Hi Adrian, > > On Tue, Jan 31, 2023 at 5:16 AM Adrian Hunter wrote: > > > > Hi > > > > This is version 2 of the second of 2 patchsets to improve > > dso__synthesize_plt_symbols(). > > This patchset focuses on getting rid of unknown symbols that show up in > > Intel PT traces. > > > > x86 has 2 more plt's, namely .plt.sec and .plt.got, so support is added for > > synthesizing symbols for them. Special handing is needed for IFUNC symbols, > > and it is also possible to have a .plt for static executables, so support is > > added for that. > > > > > > Changes in V2: > > > > perf symbols: Add support for x86 .plt.sec > > Amend commit message and example about -z plt > > > > perf symbols: Get symbols for .plt.got for x86-64 > > Fix get_plt_got_name() not to segfault with EM_386 > > > > > > Adrian Hunter (9): > > perf symbols: Correct plt entry sizes for x86 > > perf symbols: Add support for x86 .plt.sec > > perf symbols: Sort plt relocations for x86 > > perf symbols: Record whether a symbol is an alias for an IFUNC symbol > > perf symbols: Add support for IFUNC symbols for x86_64 > > perf symbols: Allow for .plt without header > > perf symbols: Allow for static executables with .plt > > perf symbols: Start adding support for .plt.got for x86 > > perf symbols: Get symbols for .plt.got for x86-64 > > Reviewed-by: Namhyung Kim Thanks, applied. - Arnaldo > Thanks, > Namhyung > > > > > > tools/perf/util/symbol-elf.c | 365 ++++++++++++++++++++++++++++++++++++++++--- > > tools/perf/util/symbol.c | 4 + > > tools/perf/util/symbol.h | 2 + > > tools/perf/util/symsrc.h | 1 + > > 4 files changed, 350 insertions(+), 22 deletions(-) > > > > > > Regards > > Adrian -- - Arnaldo