From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Sandipan Das <sandipan.das@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
x86@kernel.org, peterz@infradead.org, bp@alien8.de,
namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de,
mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, dave.hansen@linux.intel.com,
james.clark@arm.com, irogers@google.com, eranian@google.com,
ananth.narayan@amd.com, ravi.bangoria@amd.com,
santosh.shukla@amd.com
Subject: Re: [PATCH v3 1/2] perf script: Show branch speculation info
Date: Wed, 1 Feb 2023 23:37:56 -0300 [thread overview]
Message-ID: <Y9siBA2xfhFeWJku@kernel.org> (raw)
In-Reply-To: <Y9shRsZuhGgpNi25@kernel.org>
Em Wed, Feb 01, 2023 at 11:34:46PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Feb 01, 2023 at 10:13:03PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Jan 30, 2023 at 05:09:10PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Mon, Jan 30, 2023 at 04:04:58PM +0530, Sandipan Das escreveu:
> > > > Sorry but I realized later that this change breaks the builtin branch test.
> > > > The additional change below fixes that.
> > >
> > > Please wait a bit for people to be able to review the other patches and
> > > then submit a v2 series.
> >
> > So I applied it manually, no need to send v2.
>
> Please send v2 after figuring out why 'perf test "Sample parsing"'
> fails,
>
> I removed both patches for now.
Triple checking:
[acme@quaco perf]$ git log --oneline -1
24a617c84f0da540 (HEAD -> perf/core) perf session: Show branch speculation info in raw dump
[acme@quaco perf]$ perf -v
perf version 6.2.rc5.g24a617c84f0d
[acme@quaco perf]$ perf test "Sample testing"
[acme@quaco perf]$ perf test "Sample parsing"
27: Sample parsing : FAILED!
80: x86 Sample parsing : Ok
[acme@quaco perf]$ git reset --hard HEAD~
HEAD is now at 1fad7c0ae6516706 perf script: Show branch speculation info
[acme@quaco perf]$ git log --oneline -1
1fad7c0ae6516706 (HEAD -> perf/core) perf script: Show branch speculation info
[acme@quaco perf]$ perf -v
perf version 6.2.rc5.g1fad7c0ae651
[acme@quaco perf]$ perf test 27
27: Sample parsing : FAILED!
[acme@quaco perf]$ git reset --hard HEAD~
HEAD is now at d4a6f399c89520ba perf bench syscall: Add execve syscall benchmark
[acme@quaco perf]$
[acme@quaco perf]$ git log --oneline -1
d4a6f399c89520ba (HEAD -> perf/core, five/perf/core) perf bench syscall: Add execve syscall benchmark
[acme@quaco perf]$ perf -v
perf version 6.2.rc5.gd4a6f399c895
[acme@quaco perf]$ perf test 27
27: Sample parsing : Ok
[acme@quaco perf]$
- Arnaldo
next prev parent reply other threads:[~2023-02-02 2:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 5:59 [PATCH v3 0/2] tools perf: Add branch speculation info Sandipan Das
2023-01-30 5:59 ` [PATCH v3 1/2] perf script: Show " Sandipan Das
2023-01-30 10:34 ` Sandipan Das
2023-01-30 20:09 ` Arnaldo Carvalho de Melo
2023-02-02 1:13 ` Arnaldo Carvalho de Melo
2023-02-02 2:34 ` Arnaldo Carvalho de Melo
2023-02-02 2:37 ` Arnaldo Carvalho de Melo [this message]
2023-01-30 5:59 ` [PATCH v3 2/2] perf session: Show branch speculation info in raw dump Sandipan Das
2023-02-02 1:05 ` [PATCH v3 0/2] tools perf: Add branch speculation info Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9siBA2xfhFeWJku@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).