* [PATCH] perf tools: Fix *probe_vfs_getname.sh test failures
@ 2021-08-25 16:42 James Clark
2021-08-25 17:09 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: James Clark @ 2021-08-25 16:42 UTC (permalink / raw)
To: acme, linux-perf-users
Cc: James Clark, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Namhyung Kim, linux-kernel
The commit 4d6101f5fd5d ("perf probe: Clarify error message about not
finding kernel modules debuginfo") changed the error message "Failed to
find the path for kernel" to "Failed to find the path for the kernel".
Update the regex so that the tests still skip rather than fail when
kernel debug symbols aren't present.
Signed-off-by: James Clark <james.clark@arm.com>
---
tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
index c2cc42daf924..5b17d916c555 100644
--- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh
+++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
@@ -19,6 +19,6 @@ add_probe_vfs_getname() {
}
skip_if_no_debuginfo() {
- add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for kernel|Debuginfo-analysis is not supported)" && return 2
+ add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)" && return 2
return 1
}
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf tools: Fix *probe_vfs_getname.sh test failures
2021-08-25 16:42 [PATCH] perf tools: Fix *probe_vfs_getname.sh test failures James Clark
@ 2021-08-25 17:09 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-08-25 17:09 UTC (permalink / raw)
To: James Clark
Cc: linux-perf-users, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Namhyung Kim, linux-kernel
Em Wed, Aug 25, 2021 at 05:42:59PM +0100, James Clark escreveu:
> The commit 4d6101f5fd5d ("perf probe: Clarify error message about not
> finding kernel modules debuginfo") changed the error message "Failed to
> find the path for kernel" to "Failed to find the path for the kernel".
>
> Update the regex so that the tests still skip rather than fail when
> kernel debug symbols aren't present.
Thanks, applied.
- Arnaldo
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> index c2cc42daf924..5b17d916c555 100644
> --- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> +++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> @@ -19,6 +19,6 @@ add_probe_vfs_getname() {
> }
>
> skip_if_no_debuginfo() {
> - add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for kernel|Debuginfo-analysis is not supported)" && return 2
> + add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)" && return 2
> return 1
> }
> --
> 2.28.0
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-25 16:42 [PATCH] perf tools: Fix *probe_vfs_getname.sh test failures James Clark
2021-08-25 17:09 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).