linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@redhat.com, namhyung@kernel.org, kim.phillips@amd.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] perf annotate: Fix fused instr logic for assembly functions
Date: Mon, 13 Sep 2021 16:53:31 -0300	[thread overview]
Message-ID: <YT+sOxJeEplSm2pl@kernel.org> (raw)
In-Reply-To: <211bb79d-80ff-e9b6-1851-1aaed987301d@linux.intel.com>

Em Mon, Sep 13, 2021 at 09:54:00AM +0800, Jin, Yao escreveu:
> Hi Arnaldo, Ravi
> 
> On 9/12/2021 3:03 AM, Arnaldo Carvalho de Melo wrote:
> > Em Sat, Sep 11, 2021 at 10:08:53AM +0530, Ravi Bangoria escreveu:
> > > Some x86 microarchitectures fuse a subset of cmp/test/ALU instructions
> > > with branch instructions, and thus perf annotate highlight such valid
> > > pairs as fused.
> > 
> > Jin, are you ok with this? Can I have your reviewed-by?
> > 
> > - Arnaldo
> 
> Oh, my original patch could only handle the case like:
> 
> cmp xxx
> je  aaa
> 
> But it didn't consider Ravi's case something like:
> 
> cmp xxx
> cmp yyy
> je  aaa
> je  bbb
> 
> Thanks for Ravi fixing this issue! Backward searching is probably a better solution.
> 
> Frankly I can't reproduce Ravi's case, but for my test suite, Ravi's patch works as well.
> 
> Reviewed-by: Jin Yao <yao.jin@linux.intel.com>

Thanks, applied.

- Arnaldo


      reply	other threads:[~2021-09-13 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  4:38 [PATCH v2 1/2] perf annotate: Fix fused instr logic for assembly functions Ravi Bangoria
2021-09-11  4:38 ` [PATCH v2 2/2] perf annotate: Add fusion logic for AMD microarchs Ravi Bangoria
2021-09-11 19:03 ` [PATCH v2 1/2] perf annotate: Fix fused instr logic for assembly functions Arnaldo Carvalho de Melo
2021-09-13  1:54   ` Jin, Yao
2021-09-13 19:53     ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YT+sOxJeEplSm2pl@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@amd.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).