From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65622C433F5 for ; Fri, 3 Sep 2021 11:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 490BB6108E for ; Fri, 3 Sep 2021 11:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234932AbhICLGL (ORCPT ); Fri, 3 Sep 2021 07:06:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:51138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348487AbhICLGJ (ORCPT ); Fri, 3 Sep 2021 07:06:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 41F106101A; Fri, 3 Sep 2021 11:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630667109; bh=ZYJJfNfDBDoEd9auwZs1I3zRjMJaKASoHmWShb2DHD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y6OjZ+ui3ulw9uaS74ytWqqRvhHTsFdgUizXzu8tn3dghLK6Dq4TP7yl+lNmFaaB4 +4w5u9+OFRLrg5pgz75abQjlmvRcpItiigCrNkTaCrZoxxVIjrxjhL3bsTwszO7zBM +9DnMcRekOhFqiAF8fCnkRjNJn8DrjOEcvtcaF4U1L3ol3bBPTZQtuY4qtRAYxG4jt W8XDYPbIS6l5r8eXnprF3lUqRHV2ltQ19H4M3E2+2Pnl9CKDn0qo6rReDQ9JWaDdDZ tBtWTFrHo7ugboOkBK2r8aPCYDWw2SG/ae01MDSjZUw7WZjDFVNEle7Jtgzlsu+n06 2gy1fFp6dKxcg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id C59ED4007E; Fri, 3 Sep 2021 08:05:06 -0300 (-03) Date: Fri, 3 Sep 2021 08:05:06 -0300 From: Arnaldo Carvalho de Melo To: Suzuki K Poulose Cc: James Clark , mathieu.poirier@linaro.org, leo.yan@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] perf cs-etm: Refactor initialisation of decoder params. Message-ID: References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-2-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Sep 03, 2021 at 09:52:14AM +0100, Suzuki K Poulose escreveu: > On 06/08/2021 14:41, James Clark wrote: > > The initialisation of the decoder params is duplicated between > > creation of the packet printer and packet decoder. Put them both > > into one function so that future changes only need to be made in one > > place. > > > > Reviewed-by: Leo Yan > > Signed-off-by: James Clark > > Acked-by: Suzuki K Poulose Thanks, collected the Acked-by. - Arnaldo