From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E569AC433F5 for ; Tue, 19 Oct 2021 16:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C84B760E76 for ; Tue, 19 Oct 2021 16:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbhJSQcV (ORCPT ); Tue, 19 Oct 2021 12:32:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:52998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhJSQcV (ORCPT ); Tue, 19 Oct 2021 12:32:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 69C2E6113B; Tue, 19 Oct 2021 16:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634661008; bh=qZa2i87QZSwsPPDAbWTt875cMqtvmMLZ0A9OP4OhgGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sxFskTOJpw136yFjzkIavwxPtlK8QwZQh9Q5vyjt6KeIwmhOsBe9/f6zqLycNj8E+ 44eYntQE9QwxZ3KLWtTA4ipi7jso6QjJvTBD3IeiuqhOv4V9dEe24MyGQcZIq5ahjl Y+1gyCiRpzlOS87xff/jCwoxlM6iHBdygESrqaZcvFn5keZAvDMryVUPjBEhOJQmvl dg7CLVcwRw3cSGpMBXiiTvmpaPV1gCD26mbnWrloOkD2t1l1CeZKJ401ohX5SuGuNI o/M0X2G9iqCIQGTOgAI5D84k3kAJX+0NHCEJWl3q+cswREOhOd+h91zWKoBoIzKHLr Jpa+1XvkPq67g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 02BDD410A1; Tue, 19 Oct 2021 13:30:05 -0300 (-03) Date: Tue, 19 Oct 2021 13:30:05 -0300 From: Arnaldo Carvalho de Melo To: Athira Rajeev Cc: jolsa@kernel.org, mpe@ellerman.id.au, linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.vnet.ibm.com, rnsastry@linux.ibm.com, kjain@linux.ibm.com Subject: Re: [V4 0/2] tools/perf: Add instruction and data address registers to extended regs in powerpc Message-ID: References: <20211018114948.16830-1-atrajeev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018114948.16830-1-atrajeev@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Oct 18, 2021 at 05:19:46PM +0530, Athira Rajeev escreveu: > Patch set adds PMU registers namely Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs > in PowerPC. These registers provides the instruction/data address and > adding these to extended regs helps in debug purposes. > > Patch 1/2 refactors the existing macro definition of > PERF_REG_PMU_MASK_300 and PERF_REG_PMU_MASK_31 to make it more > readable. > Patch 2/2 includes perf tools side changes to add the SPRs to > sample_reg_mask to use with -I? option. Thanks, applied. - Arnaldo > Changelog: > Change from v3 -> v4: > - Spilt tools side patches separately since kernel side > changes are in powerpc/next. There is no code wise changes > from v3. > Link to previous version: > https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=265811&state=* > > Kernel patches are taken to powerpc/next: > [1/4] powerpc/perf: Refactor the code definition of perf reg extended mask > https://git.kernel.org/powerpc/c/02b182e67482d9167a13a0ff19b55037b70b21ad > [3/4] powerpc/perf: Expose instruction and data address registers as part of extended regs > https://git.kernel.org/powerpc/c/29908bbf7b8960d261dfdd428bbaa656275e80f3 > > Change from v2 -> v3: > Addressed review comments from Michael Ellerman > - Fixed the macro definition to use "unsigned long long" > which otherwise will cause build error with perf on > 32-bit. > - Added Reviewed-by from Daniel Axtens for patch3. > > Change from v1 -> v2: > Addressed review comments from Michael Ellerman > - Refactored the perf reg extended mask value macros for > PERF_REG_PMU_MASK_300 and PERF_REG_PMU_MASK_31 to > make it more readable. Also moved PERF_REG_EXTENDED_MAX > along with enum definition similar to PERF_REG_POWERPC_MAX. > > Athira Rajeev (2): > tools/perf: Refactor the code definition of perf reg extended mask in > tools side header file > tools/perf: Add perf tools support to expose instruction and data > address registers as part of extended regs > > .../arch/powerpc/include/uapi/asm/perf_regs.h | 28 ++++++++++++------- > tools/perf/arch/powerpc/include/perf_regs.h | 2 ++ > tools/perf/arch/powerpc/util/perf_regs.c | 2 ++ > 3 files changed, 22 insertions(+), 10 deletions(-) > > -- > 2.33.0 -- - Arnaldo