From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Dave Marchevsky <davemarchevsky@fb.com>,
bpf <bpf@vger.kernel.org>,
"linux-perf-use." <linux-perf-users@vger.kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 bpf-next 3/4] perf: pull in bpf_program__get_prog_info_linear
Date: Sun, 31 Oct 2021 14:13:31 -0300 [thread overview]
Message-ID: <YX7Ou9UALUMYqgQI@kernel.org> (raw)
In-Reply-To: <5080FF1F-8E7A-4AF7-AD7E-7349E58CFEDB@fb.com>
Em Thu, Oct 28, 2021 at 08:44:51PM +0000, Song Liu escreveu:
>
>
> > On Oct 20, 2021, at 10:37 AM, Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> >
> > On Mon, Oct 11, 2021 at 1:20 AM Dave Marchevsky <davemarchevsky@fb.com> wrote:
> >>
> >> To prepare for impending deprecation of libbpf's
> >> bpf_program__get_prog_info_linear, pull in the function and associated
> >> helpers into the perf codebase and migrate existing uses to the perf
> >> copy.
> >>
> >> Since libbpf's deprecated definitions will still be visible to perf, it
> >> is necessary to rename perf's definitions.
> >>
> >> Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
> >> ---
> >
> > LGTM, but, Song, can you please take a look as well?
>
> Sorry for the delay.
>
> Acked-by: Song Liu <songliubraving@fb.com>
>
> Also cc'ing Arnaldo's other email.
Thanks, I'll get to this.
- Arnaldo
next prev parent reply other threads:[~2021-10-31 17:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 8:20 [PATCH v2 bpf-next 0/4] libbpf: deprecate bpf_program__get_prog_info_linear Dave Marchevsky
2021-10-11 8:20 ` [PATCH v2 bpf-next 1/4] libbpf: migrate internal use of bpf_program__get_prog_info_linear Dave Marchevsky
2021-10-20 17:36 ` Andrii Nakryiko
2021-10-11 8:20 ` [PATCH v2 bpf-next 2/4] bpftool: use bpf_obj_get_info_by_fd directly Dave Marchevsky
2021-10-20 17:37 ` Andrii Nakryiko
2021-10-20 22:15 ` Quentin Monnet
2021-10-11 8:20 ` [PATCH v2 bpf-next 3/4] perf: pull in bpf_program__get_prog_info_linear Dave Marchevsky
2021-10-20 17:37 ` Andrii Nakryiko
[not found] ` <5080FF1F-8E7A-4AF7-AD7E-7349E58CFEDB@fb.com>
2021-10-31 17:13 ` Arnaldo Carvalho de Melo [this message]
2021-10-11 8:20 ` [PATCH v2 bpf-next 4/4] libbpf: deprecate bpf_program__get_prog_info_linear Dave Marchevsky
2021-10-20 17:37 ` Andrii Nakryiko
2021-10-20 21:01 ` Toke Høiland-Jørgensen
[not found] ` <d3de589a-21f3-7a0d-59de-126d3c70fba1@fb.com>
2021-10-22 19:26 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX7Ou9UALUMYqgQI@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).